[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 12/29] Include hw/irq.h a lot less
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v2 12/29] Include hw/irq.h a lot less |
Date: |
Wed, 7 Aug 2019 22:09:29 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 8/7/19 9:27 PM, Markus Armbruster wrote:
>>>> typedef void SaveStateHandler(QEMUFile *f, void *opaque);
>>>> typedef int LoadStateHandler(QEMUFile *f, void *opaque, int version_id);
>>>> +typedef void (*qemu_irq_handler)(void *opaque, int n, int level);
>>
>> Should we prefer a consistent form for function pointer typedefs? Here,
>> we've mixed 'rettype Name(params)' with 'rettype (*name)(params)'.
>
> Which of the two difference I can see do you mean?
Eric asked about function type vs pointer-to-function type.
In usage,
SaveStateHandler *variable;
vs
qemu_irq_handler variable;
r~
- Re: [Qemu-devel] Is network backend netmap worth keeping?, (continued)
[Qemu-devel] [PATCH v2 19/29] Include qemu/queue.h slightly less, Markus Armbruster, 2019/08/06
[Qemu-devel] [PATCH v2 12/29] Include hw/irq.h a lot less, Markus Armbruster, 2019/08/06
[Qemu-devel] [PATCH v2 29/29] sysemu: Split sysemu/runstate.h off sysemu/sysemu.h, Markus Armbruster, 2019/08/06
[Qemu-devel] [PATCH v2 15/29] Include migration/vmstate.h less, Markus Armbruster, 2019/08/06
[Qemu-devel] [PATCH v2 18/29] Include hw/hw.h exactly where needed, Markus Armbruster, 2019/08/06
[Qemu-devel] [PATCH v2 21/29] Include hw/qdev-properties.h less, Markus Armbruster, 2019/08/06
Re: [Qemu-devel] [PATCH v2 00/29] Tame a few "touch this, recompile the world" headers, no-reply, 2019/08/06