Re: [Qemu-devel] [PATCH v2 19/29] Include qemu/queue.h slightly less

[Alex Bennée]

Markus Armbruster <address@hidden> writes:

> Signed-off-by: Markus Armbruster <address@hidden>
> ---
<snip>
>  nbd/client.c                | 1 +
>  nbd/nbd-internal.h          | 1 -
>  nbd/server.c                | 1 +
<snip>
> diff --git a/nbd/client.c b/nbd/client.c
> index 4de30630c7..d554ae353d 100644
> --- a/nbd/client.c
> +++ b/nbd/client.c
> @@ -19,6 +19,7 @@
>
>  #include "qemu/osdep.h"
>  #include "qapi/error.h"
> +#include "qemu/queue.h"
>  #include "trace.h"
>  #include "nbd-internal.h"
>  #include "qemu/cutils.h"
> diff --git a/nbd/nbd-internal.h b/nbd/nbd-internal.h
> index 049f83df77..ec3d2e2ebc 100644
> --- a/nbd/nbd-internal.h
> +++ b/nbd/nbd-internal.h
> @@ -28,7 +28,6 @@
>  #endif
>
>  #include "qemu/bswap.h"
> -#include "qemu/queue.h"
>  #include "qemu/main-loop.h"
>
>  /* This is all part of the "official" NBD API.
> diff --git a/nbd/server.c b/nbd/server.c
> index 10faedcfc5..dbd2ff8555 100644
> --- a/nbd/server.c
> +++ b/nbd/server.c
> @@ -19,6 +19,7 @@
>
>  #include "qemu/osdep.h"
>  #include "qapi/error.h"
> +#include "qemu/queue.h"

I don't see any queue primitives in server.c and indeed I can comment it out.

--
Alex Bennée