Re: [Qemu-devel] [RFC PATCH 00/20] i386: Add support for Intel SGX

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [RFC PATCH 00/20] i386: Add support for Intel SGX
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Submodule 'capstone' (https://git.qemu.org/git/capstone.git) registered for 
path 'capstone'
Submodule 'dtc' (https://git.qemu.org/git/dtc.git) registered for path 'dtc'
Submodule 'roms/QemuMacDrivers' (https://git.qemu.org/git/QemuMacDrivers.git) 
registered for path 'roms/QemuMacDrivers'
Submodule 'roms/SLOF' (https://git.qemu.org/git/SLOF.git) registered for path 
'roms/SLOF'
Submodule 'roms/edk2' (https://git.qemu.org/git/edk2.git) registered for path 
'roms/edk2'
Submodule 'roms/ipxe' (https://git.qemu.org/git/ipxe.git) registered for path 
'roms/ipxe'
Submodule 'roms/openbios' (https://git.qemu.org/git/openbios.git) registered 
for path 'roms/openbios'
Submodule 'roms/openhackware' (https://git.qemu.org/git/openhackware.git) 
registered for path 'roms/openhackware'
Submodule 'roms/opensbi' (https://git.qemu.org/git/opensbi.git) registered for 
path 'roms/opensbi'
Submodule 'roms/qemu-palcode' (https://git.qemu.org/git/qemu-palcode.git) 
registered for path 'roms/qemu-palcode'
Submodule 'roms/seabios' (https://git.qemu.org/git/seabios.git/) registered for 
path 'roms/seabios'
Submodule 'roms/seabios-hppa' (https://git.qemu.org/git/seabios-hppa.git) 
registered for path 'roms/seabios-hppa'
Submodule 'roms/sgabios' (https://git.qemu.org/git/sgabios.git) registered for 
path 'roms/sgabios'
Submodule 'roms/skiboot' (https://git.qemu.org/git/skiboot.git) registered for 
path 'roms/skiboot'
Submodule 'roms/u-boot' (https://git.qemu.org/git/u-boot.git) registered for 
path 'roms/u-boot'
Submodule 'roms/u-boot-sam460ex' (https://git.qemu.org/git/u-boot-sam460ex.git) 
registered for path 'roms/u-boot-sam460ex'
Submodule 'slirp' (https://git.qemu.org/git/libslirp.git) registered for path 
'slirp'
Submodule 'tests/fp/berkeley-softfloat-3' 
(https://git.qemu.org/git/berkeley-softfloat-3.git) registered for path 
'tests/fp/berkeley-softfloat-3'
Submodule 'tests/fp/berkeley-testfloat-3' 
(https://git.qemu.org/git/berkeley-testfloat-3.git) registered for path 
'tests/fp/berkeley-testfloat-3'
Submodule 'ui/keycodemapdb' (https://git.qemu.org/git/keycodemapdb.git) 
registered for path 'ui/keycodemapdb'
Cloning into 'capstone'...
Submodule path 'capstone': checked out 
'22ead3e0bfdb87516656453336160e0a37b066bf'
Cloning into 'dtc'...
Submodule path 'dtc': checked out '88f18909db731a627456f26d779445f84e449536'
Cloning into 'roms/QemuMacDrivers'...
Submodule path 'roms/QemuMacDrivers': checked out 
'90c488d5f4a407342247b9ea869df1c2d9c8e266'
Cloning into 'roms/SLOF'...
Submodule path 'roms/SLOF': checked out 
'ba1ab360eebe6338bb8d7d83a9220ccf7e213af3'
Cloning into 'roms/edk2'...
Submodule path 'roms/edk2': checked out 
'20d2e5a125e34fc8501026613a71549b2a1a3e54'
Submodule 'SoftFloat' (https://github.com/ucb-bar/berkeley-softfloat-3.git) 
registered for path 'ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3'
Submodule 'CryptoPkg/Library/OpensslLib/openssl' 
(https://github.com/openssl/openssl) registered for path 
'CryptoPkg/Library/OpensslLib/openssl'
Cloning into 'ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3'...
Submodule path 'roms/edk2/ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3': 
checked out 'b64af41c3276f97f0e181920400ee056b9c88037'
Cloning into 'CryptoPkg/Library/OpensslLib/openssl'...
Submodule path 'roms/edk2/CryptoPkg/Library/OpensslLib/openssl': checked out 
'50eaac9f3337667259de725451f201e784599687'
Submodule 'boringssl' (https://boringssl.googlesource.com/boringssl) registered 
for path 'boringssl'
Submodule 'krb5' (https://github.com/krb5/krb5) registered for path 'krb5'
Submodule 'pyca.cryptography' (https://github.com/pyca/cryptography.git) 
registered for path 'pyca-cryptography'
Cloning into 'boringssl'...
Submodule path 'roms/edk2/CryptoPkg/Library/OpensslLib/openssl/boringssl': 
checked out '2070f8ad9151dc8f3a73bffaa146b5e6937a583f'
Cloning into 'krb5'...
Submodule path 'roms/edk2/CryptoPkg/Library/OpensslLib/openssl/krb5': checked 
out 'b9ad6c49505c96a088326b62a52568e3484f2168'
Cloning into 'pyca-cryptography'...
Submodule path 
'roms/edk2/CryptoPkg/Library/OpensslLib/openssl/pyca-cryptography': checked out 
'09403100de2f6f1cdd0d484dcb8e620f1c335c8f'
Cloning into 'roms/ipxe'...
Submodule path 'roms/ipxe': checked out 
'de4565cbe76ea9f7913a01f331be3ee901bb6e17'
Cloning into 'roms/openbios'...
Submodule path 'roms/openbios': checked out 
'c79e0ecb84f4f1ee3f73f521622e264edd1bf174'
Cloning into 'roms/openhackware'...
Submodule path 'roms/openhackware': checked out 
'c559da7c8eec5e45ef1f67978827af6f0b9546f5'
Cloning into 'roms/opensbi'...
Submodule path 'roms/opensbi': checked out 
'ce228ee0919deb9957192d723eecc8aaae2697c6'
Cloning into 'roms/qemu-palcode'...
Submodule path 'roms/qemu-palcode': checked out 
'bf0e13698872450164fa7040da36a95d2d4b326f'
Cloning into 'roms/seabios'...
Submodule path 'roms/seabios': checked out 
'a5cab58e9a3fb6e168aba919c5669bea406573b4'
Cloning into 'roms/seabios-hppa'...
Submodule path 'roms/seabios-hppa': checked out 
'0f4fe84658165e96ce35870fd19fc634e182e77b'
Cloning into 'roms/sgabios'...
Submodule path 'roms/sgabios': checked out 
'cbaee52287e5f32373181cff50a00b6c4ac9015a'
Cloning into 'roms/skiboot'...
Submodule path 'roms/skiboot': checked out 
'261ca8e779e5138869a45f174caa49be6a274501'
Cloning into 'roms/u-boot'...
Submodule path 'roms/u-boot': checked out 
'd3689267f92c5956e09cc7d1baa4700141662bff'
Cloning into 'roms/u-boot-sam460ex'...
Submodule path 'roms/u-boot-sam460ex': checked out 
'60b3916f33e617a815973c5a6df77055b2e3a588'
Cloning into 'slirp'...
Submodule path 'slirp': checked out '126c04acbabd7ad32c2b018fe10dfac2a3bc1210'
Cloning into 'tests/fp/berkeley-softfloat-3'...
Submodule path 'tests/fp/berkeley-softfloat-3': checked out 
'b64af41c3276f97f0e181920400ee056b9c88037'
Cloning into 'tests/fp/berkeley-testfloat-3'...
Submodule path 'tests/fp/berkeley-testfloat-3': checked out 
'5a59dcec19327396a011a17fd924aed4fec416b3'
Cloning into 'ui/keycodemapdb'...
Submodule path 'ui/keycodemapdb': checked out 
'6b3d716e2b6472eb7189d3220552280ef3d832ce'
Switched to a new branch 'test'
88f6b6b i440fx: Add support for SGX EPC
1cc3a7c q35: Add support for SGX EPC
19593c8 i386: acpi: Add SGX EPC entry to ACPI tables
bf6e456 i386/pc: Add e820 entry for SGX EPC section(s)
45bd563 hw/i386/pc: Account for SGX EPC sections when calculating device memory
427b437 hw/i386/pc: Set SGX bits in feature control fw_cfg accordingly
8b354d9 i386: Adjust min CPUID level to 0x12 when SGX is enabled
9f79c37 i386: Propagate SGX CPUID sub-leafs to KVM
1214b69 i386: kvm: Add support for exposing PROVISIONKEY to guest
a0e8db2 linux-headers: Add temporary placeholder for KVM_CAP_SGX_ATTRIBUTE
c8b58e5 i386: Update SGX CPUID info according to hardware/KVM/user input
cec40de i386: Add feature control MSR dependency when SGX is enabled
084a80f i386: Add get/set/migrate support for SGX LE public key hash MSRs
8cdb3f5 i386: Add SGX CPUID leaf FEAT_SGX_12_1_EBX
4baa417 i386: Add SGX CPUID leaf FEAT_SGX_12_1_EAX
58a1f80 i386: Add SGX CPUID leaf FEAT_SGX_12_0_EAX
992c530 i386: Add primary SGX CPUID and MSR defines
b2436a7 vl: Add "sgx-epc" option to expose SGX EPC sections to guest
1ad151c i386: Add 'sgx-epc' device to expose EPC sections to guest
3807ef1 hostmem: Add hostmem-epc as a backend for SGX EPC

=== OUTPUT BEGIN ===
1/20 Checking commit 3807ef1edf72 (hostmem: Add hostmem-epc as a backend for 
SGX EPC)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#37: 
new file mode 100644

total: 0 errors, 1 warnings, 95 lines checked

Patch 1/20 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/20 Checking commit 1ad151c8a37a (i386: Add 'sgx-epc' device to expose EPC 
sections to guest)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#30: 
new file mode 100644

WARNING: line over 80 characters
#94: FILE: hw/i386/sgx-epc.c:60:
+            "'" TYPE_SGX_EPC "' can't be created after vCPUs, e.g. via 
-device");

WARNING: Block comments use a leading /* on a separate line
#162: FILE: hw/i386/sgx-epc.c:128:
+    di->node = 0 /* TODO: EPC NUMA spec not yet defined */;

total: 0 errors, 3 warnings, 265 lines checked

Patch 2/20 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/20 Checking commit b2436a7d3978 (vl: Add "sgx-epc" option to expose SGX EPC 
sections to guest)
WARNING: Block comments use a leading /* on a separate line
#147: FILE: hw/i386/sgx-epc.c:265:
+        { /* end of list */ }

total: 0 errors, 1 warnings, 204 lines checked

Patch 3/20 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/20 Checking commit 992c530ef717 (i386: Add primary SGX CPUID and MSR defines)
ERROR: spaces required around that '<<' (ctx:VxV)
#46: FILE: target/i386/cpu.h:353:
+#define FEATURE_CONTROL_VMXON_ENABLED_INSIDE_SMX  (1<<1)
                                                     ^

ERROR: spaces required around that '<<' (ctx:VxV)
#48: FILE: target/i386/cpu.h:355:
+#define FEATURE_CONTROL_SGX_LC                    (1<<17)
                                                     ^

ERROR: spaces required around that '<<' (ctx:VxV)
#49: FILE: target/i386/cpu.h:356:
+#define FEATURE_CONTROL_SGX                       (1<<18)
                                                     ^

total: 3 errors, 0 warnings, 47 lines checked

Patch 4/20 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

5/20 Checking commit 58a1f8087e54 (i386: Add SGX CPUID leaf FEAT_SGX_12_0_EAX)
6/20 Checking commit 4baa417cdf54 (i386: Add SGX CPUID leaf FEAT_SGX_12_1_EAX)
WARNING: Block comments use a leading /* on a separate line
#50: FILE: target/i386/cpu.c:1251:
+            NULL /* sgx-init */, "sgx-debug", "sgx-mode64", NULL,

total: 0 errors, 1 warnings, 39 lines checked

Patch 6/20 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/20 Checking commit 8cdb3f58b140 (i386: Add SGX CPUID leaf FEAT_SGX_12_1_EBX)
8/20 Checking commit 084a80f3d2bd (i386: Add get/set/migrate support for SGX LE 
public key hash MSRs)
ERROR: line over 90 characters
#71: FILE: target/i386/kvm.c:3273:
+            env->msr_ia32_sgxlepubkeyhash[index - MSR_IA32_SGXLEPUBKEYHASH0] = 
msrs[i].data;

total: 1 errors, 0 warnings, 78 lines checked

Patch 8/20 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

9/20 Checking commit cec40de7ffd8 (i386: Add feature control MSR dependency 
when SGX is enabled)
10/20 Checking commit c8b58e5b0b68 (i386: Update SGX CPUID info according to 
hardware/KVM/user input)
11/20 Checking commit a0e8db24ba97 (linux-headers: Add temporary placeholder 
for KVM_CAP_SGX_ATTRIBUTE)
12/20 Checking commit 1214b6995d8e (i386: kvm: Add support for exposing 
PROVISIONKEY to guest)
13/20 Checking commit 9f79c37092ee (i386: Propagate SGX CPUID sub-leafs to KVM)
14/20 Checking commit 8b354d984599 (i386: Adjust min CPUID level to 0x12 when 
SGX is enabled)
15/20 Checking commit 427b437b1f4a (hw/i386/pc: Set SGX bits in feature control 
fw_cfg accordingly)
16/20 Checking commit 45bd56319897 (hw/i386/pc: Account for SGX EPC sections 
when calculating device memory)
17/20 Checking commit bf6e45641073 (i386/pc: Add e820 entry for SGX EPC 
section(s))
18/20 Checking commit 19593c815040 (i386: acpi: Add SGX EPC entry to ACPI 
tables)
19/20 Checking commit 1cc3a7c09de6 (q35: Add support for SGX EPC)
20/20 Checking commit 88f6b6bb2f2b (i440fx: Add support for SGX EPC)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden