[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] util/hbitmap: fix unaligned reset
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] util/hbitmap: fix unaligned reset |
Date: |
Tue, 6 Aug 2019 01:31:08 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 02/08/19 23:19, Max Reitz wrote:
>
> But I don’t know whether this patch is the best way forward still. I
> think call hbitmap_reset() with unaligned boundaries generally calls for
> trouble, as John has laid out. If mirror’s do_sync_target_write() is
> the only offender right now, I’d prefer for hbitmap_reset() to assert
> that the boundaries are aligned
I agree (it's not a bug, it's a feature though a nasty one).
Paolo
Re: [Qemu-devel] [PATCH] util/hbitmap: fix unaligned reset, Max Reitz, 2019/08/05