Re: [Qemu-devel] [PATCHv3 2/6] block: introduce bdrv_runtime_opts

[Stefan Hajnoczi]

On Sat, Oct 25, 2014 at 06:55:49PM +0200, Peter Lieven wrote:
> This patch (orginally by Kevin) adds a bdrv_runtime_opts QemuOptsList.
> The list will absorb all options that belong to the BDS (and not the
> BlockBackend) and will be parsed and handled in bdrv_open_common.
> 
> Signed-off-by: Kevin Wolf <address@hidden>
> Signed-off-by: Peter Lieven <address@hidden>
> Reviewed-by: Max Reitz <address@hidden>
> ---
>  block.c |   38 +++++++++++++++++++++++++++++++++-----
>  1 file changed, 33 insertions(+), 5 deletions(-)

Is this purely because the QemuOptsList API is more convenient than
qdict?

I don't see a deeper reason why we must use QemuOptsList here.

The code is fine, however:

Reviewed-by: Stefan Hajnoczi <address@hidden>

pgpLr0LxhgHXd.pgp
Description: PGP signature