Re: [Qemu-devel] [PATCHv3 5/6] block: add qemu-iotest for write-merge parameter

[Peter Lieven]

On 27.10.2014 10:08, Max Reitz wrote:
> On 2014-10-25 at 18:55, Peter Lieven wrote:
> > Signed-off-by: Peter Lieven <address@hidden>
> > ---
> >   tests/qemu-iotests/109     |  113 ++++++++++++++++++++++++++++++++++++++++++++
> >   tests/qemu-iotests/109.out |   68 ++++++++++++++++++++++++++
> >   tests/qemu-iotests/group   |    1 +
> >   3 files changed, 182 insertions(+)
> >   create mode 100755 tests/qemu-iotests/109
> >   create mode 100644 tests/qemu-iotests/109.out
>
> First:
>
> Reviewed-by: Max Reitz <address@hidden>
>
> Second: Why are you using query-block at all? Just give both the format and the 
> protocol BDS a (different) node name and you could use only 
> query-named-block-nodes.

It was the useless try to make the lines shorter than 995 characters...

Peter

> Max


--

Mit freundlichen Grüßen

Peter Lieven

...........................................................

  KAMP Netzwerkdienste GmbH
  Vestische Str. 89-91 | 46117 Oberhausen
  Tel: +49 (0) 208.89 402-50 | Fax: +49 (0) 208.89 402-40
  address@hidden | http://www.kamp.de

  Geschäftsführer: Heiner Lante | Michael Lante
  Amtsgericht Duisburg | HRB Nr. 12154
  USt-Id-Nr.: DE 120607556

...........................................................