Re: [Qemu-devel] [PATCH 9/9] target-arm: A64: implement SVC, BRK

[Richard Henderson]

On 12/09/2013 10:12 AM, Peter Maydell wrote:
> +    case 0:
> +        /* SVC, HVC, SMC; since we don't support the Virtualization
> +         * or TrustZone extensions these all UNDEF except SVC.
> +         */
> +        if (op2_ll != 1) {
> +            unallocated_encoding(s);
> +            break;
> +        }
> +        gen_exception_insn(s, 0, EXCP_SWI);
> +        break;

Should the imm16 should be stored somewhere, for exception.syndrome?

I can only presume from this that the AA64 userland doesn't encode its syscall
number in the insn...

Otherwise,

Reviewed-by: Richard Henderson <address@hidden>


r~