[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 8/9] target-arm: A64: add support for 3 src data
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH 8/9] target-arm: A64: add support for 3 src data proc insns |
Date: |
Mon, 09 Dec 2013 13:52:47 -0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 |
On 12/09/2013 10:12 AM, Peter Maydell wrote:
> + if (is_high) {
> + /* SMULH and UMULH go via helpers for the 64x64->128 multiply */
> + if (is_signed) {
> + gen_helper_smulh(cpu_reg(s, rd), cpu_reg(s, rn), cpu_reg(s, rm));
> + } else {
> + gen_helper_umulh(cpu_reg(s, rd), cpu_reg(s, rn), cpu_reg(s, rm));
> + }
Should use tcg_gen_mul[su]2_i64, with a dummy temp for the first arg; the
highpart result is placed into the second arg.
r~
- Re: [Qemu-devel] [PATCH 3/9] target-arm: A64: add support for ld/st unsigned imm, (continued)
- [Qemu-devel] [PATCH 5/9] target-arm: A64: add support for ld/st with index, Peter Maydell, 2013/12/09
- [Qemu-devel] [PATCH 2/9] target-arm: A64: add support for ldp (load pair), Peter Maydell, 2013/12/09
- [Qemu-devel] [PATCH 4/9] target-arm: A64: add support for ld/st with reg offset, Peter Maydell, 2013/12/09
- [Qemu-devel] [PATCH 8/9] target-arm: A64: add support for 3 src data proc insns, Peter Maydell, 2013/12/09
- Re: [Qemu-devel] [PATCH 8/9] target-arm: A64: add support for 3 src data proc insns,
Richard Henderson <=
- [Qemu-devel] [PATCH 6/9] target-arm: A64: add support for add, addi, sub, subi, Peter Maydell, 2013/12/09
- [Qemu-devel] [PATCH 1/9] target-arm: A64: add support for stp (store pair), Peter Maydell, 2013/12/09
- [Qemu-devel] [PATCH 9/9] target-arm: A64: implement SVC, BRK, Peter Maydell, 2013/12/09
- Re: [Qemu-devel] [PATCH 0/9] target-arm: A64 decoder set 3: loads, stores, misc integer, Peter Maydell, 2013/12/09