Re: [Qemu-devel] [PATCH 04/18] savevm: set right return value for qemu_file_rate_limit

[Paolo Bonzini]

Il 23/08/2013 11:18, Lei Li ha scritto:
>>>
>>> And now as qemu_file_rate_limit() never return negative value, what's
>>> the
>>> meaning for the check: if (qemu_file_rate_limit(f) < 0) in
>>> ram_save_iterate()?
>> I only see a "while ((ret = qemu_file_rate_limit(f)) == 0)", no
>> less-than-zero check.
>>
>> Are we looking at the same code? :)
> 
> I think so, hehe.
> You might want to look a little more. After the while(..), there is a
> check:
> 
> if (ret < 0) {
>     bytes_transferred += total_sent;
>     return ret;
> }

Aha, there you are.  It's dead code, you can delete it.

Paolo