[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/18] bugfix: wrong error set by ram_control_lo
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 06/18] bugfix: wrong error set by ram_control_load_hook() |
Date: |
Wed, 21 Aug 2013 12:40:55 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8 |
Il 21/08/2013 09:18, Lei Li ha scritto:
> It should set negative error value if there has been an error.
>
> Signed-off-by: Lei Li <address@hidden>
> ---
> savevm.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/savevm.c b/savevm.c
> index 1522d95..f10e031 100644
> --- a/savevm.c
> +++ b/savevm.c
> @@ -649,7 +649,7 @@ void ram_control_after_iterate(QEMUFile *f, uint64_t
> flags)
>
> void ram_control_load_hook(QEMUFile *f, uint64_t flags)
> {
> - int ret = 0;
> + int ret = -1;
-EINVAL
otherwise looks good thanks!
Paolo
> if (f->ops->hook_ram_load) {
> ret = f->ops->hook_ram_load(f, f->opaque, flags);
>
- Re: [Qemu-devel] [PATCH 04/18] savevm: set right return value for qemu_file_rate_limit, (continued)
- Re: [Qemu-devel] [PATCH 04/18] savevm: set right return value for qemu_file_rate_limit, Lei Li, 2013/08/22
- Re: [Qemu-devel] [PATCH 04/18] savevm: set right return value for qemu_file_rate_limit, Paolo Bonzini, 2013/08/23
- Re: [Qemu-devel] [PATCH 04/18] savevm: set right return value for qemu_file_rate_limit, Lei Li, 2013/08/23
- Re: [Qemu-devel] [PATCH 04/18] savevm: set right return value for qemu_file_rate_limit, Paolo Bonzini, 2013/08/23
- Re: [Qemu-devel] [PATCH 04/18] savevm: set right return value for qemu_file_rate_limit, Lei Li, 2013/08/23
- Re: [Qemu-devel] [PATCH 04/18] savevm: set right return value for qemu_file_rate_limit, Paolo Bonzini, 2013/08/23
- Re: [Qemu-devel] [PATCH 04/18] savevm: set right return value for qemu_file_rate_limit, Lei Li, 2013/08/23
[Qemu-devel] [PATCH 05/18] savevm: add comments for qemu_file_get_error(), Lei Li, 2013/08/21
[Qemu-devel] [PATCH 06/18] bugfix: wrong error set by ram_control_load_hook(), Lei Li, 2013/08/21
- Re: [Qemu-devel] [PATCH 06/18] bugfix: wrong error set by ram_control_load_hook(),
Paolo Bonzini <=
[Qemu-devel] [PATCH 08/18] migration-local: introduce qemu_fopen_local(), Lei Li, 2013/08/21
- Re: [Qemu-devel] [PATCH 08/18] migration-local: introduce qemu_fopen_local(), Michael R. Hines, 2013/08/22
- Re: [Qemu-devel] [PATCH 08/18] migration-local: introduce qemu_fopen_local(), Lei Li, 2013/08/23
- Re: [Qemu-devel] [PATCH 08/18] migration-local: introduce qemu_fopen_local(), Lei Li, 2013/08/27
- Re: [Qemu-devel] [PATCH 08/18] migration-local: introduce qemu_fopen_local(), Paolo Bonzini, 2013/08/28
- Re: [Qemu-devel] [PATCH 08/18] migration-local: introduce qemu_fopen_local(), Lei Li, 2013/08/29
- Re: [Qemu-devel] [PATCH 08/18] migration-local: introduce qemu_fopen_local(), Michael R. Hines, 2013/08/29