[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 9/9] kvm: shorten the parameter list for get_real_dev
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PULL 9/9] kvm: shorten the parameter list for get_real_device() |
Date: |
Fri, 23 Aug 2013 11:03:35 +0200 |
get_real_device() has 5 parameters with the last 4 is contained in the first
structure.
This patch removes the last 4 parameters and directly use them from the first
parameter.
Acked-by: Alex Williamson <address@hidden>
Signed-off-by: Wei Yang <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
hw/i386/kvm/pci-assign.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/hw/i386/kvm/pci-assign.c b/hw/i386/kvm/pci-assign.c
index ff33dc8..73941b2 100644
--- a/hw/i386/kvm/pci-assign.c
+++ b/hw/i386/kvm/pci-assign.c
@@ -568,8 +568,7 @@ static int get_real_device_id(const char *devpath, uint16_t
*val)
return get_real_id(devpath, "device", val);
}
-static int get_real_device(AssignedDevice *pci_dev, uint16_t r_seg,
- uint8_t r_bus, uint8_t r_dev, uint8_t r_func)
+static int get_real_device(AssignedDevice *pci_dev)
{
char dir[128], name[128];
int fd, r = 0, v;
@@ -582,7 +581,8 @@ static int get_real_device(AssignedDevice *pci_dev,
uint16_t r_seg,
dev->region_number = 0;
snprintf(dir, sizeof(dir), "/sys/bus/pci/devices/%04x:%02x:%02x.%x/",
- r_seg, r_bus, r_dev, r_func);
+ pci_dev->host.domain, pci_dev->host.bus,
+ pci_dev->host.slot, pci_dev->host.function);
snprintf(name, sizeof(name), "%sconfig", dir);
@@ -1769,8 +1769,7 @@ static int assigned_initfn(struct PCIDevice *pci_dev)
memcpy(dev->emulate_config_write, dev->emulate_config_read,
sizeof(dev->emulate_config_read));
- if (get_real_device(dev, dev->host.domain, dev->host.bus,
- dev->host.slot, dev->host.function)) {
+ if (get_real_device(dev)) {
error_report("pci-assign: Error: Couldn't get real device (%s)!",
dev->dev.qdev.id);
goto out;
--
1.8.3.1
- [Qemu-devel] [PULL 0/9] KVM changes for 2013-08-23, Paolo Bonzini, 2013/08/23
- [Qemu-devel] [PULL 1/9] Initialize IA32_FEATURE_CONTROL MSR in reset and migration, Paolo Bonzini, 2013/08/23
- [Qemu-devel] [PULL 5/9] kvm: x86: fix setting IA32_FEATURE_CONTROL with nested VMX disabled, Paolo Bonzini, 2013/08/23
- [Qemu-devel] [PULL 6/9] kvm: Simplify kvm_handle_io, Paolo Bonzini, 2013/08/23
- [Qemu-devel] [PULL 2/9] target-i386: remove tabs from target-i386/cpu.h, Paolo Bonzini, 2013/08/23
- [Qemu-devel] [PULL 3/9] kvm: migrate vPMU state, Paolo Bonzini, 2013/08/23
- [Qemu-devel] [PULL 4/9] kvm: add KVM_IRQFD_FLAG_RESAMPLE support, Paolo Bonzini, 2013/08/23
- [Qemu-devel] [PULL 7/9] kvm-all.c: max_cpus should not exceed KVM vcpu limit, Paolo Bonzini, 2013/08/23
- [Qemu-devel] [PULL 8/9] kvm: i386: fix LAPIC TSC deadline timer save/restore, Paolo Bonzini, 2013/08/23
- [Qemu-devel] [PULL 9/9] kvm: shorten the parameter list for get_real_device(),
Paolo Bonzini <=
- [Qemu-devel] [PULL 0/9] KVM changes for 2013-08-23, Paolo Bonzini, 2013/08/23
- [Qemu-devel] [PULL 2/9] target-i386: remove tabs from target-i386/cpu.h, Paolo Bonzini, 2013/08/23
- [Qemu-devel] [PULL 5/9] kvm: x86: fix setting IA32_FEATURE_CONTROL with nested VMX disabled, Paolo Bonzini, 2013/08/23
- [Qemu-devel] [PULL 3/9] kvm: migrate vPMU state, Paolo Bonzini, 2013/08/23
- [Qemu-devel] [PULL 6/9] kvm: Simplify kvm_handle_io, Paolo Bonzini, 2013/08/23