Re: [Qemu-devel] [PATCH V8 01/11] NUMA: add NumaOptions, NumaNodeOptions and NumaMemOptions

[Paolo Bonzini]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Il 22/08/2013 04:29, Eric Blake ha scritto:
>>>>> If everything is optional, then what defaults are used if
>>>>> I specify nothing?  Should nodeid be mandatory (here, and
>>>>> in NumaNodeOptions)?
>>> 
>>> The defaults are all consistent with original behaviour. If 
>>> nodeid is omitted, the option will be assigned node by node 
>>> from node0.
> What will be assigned?  If I omit both nodeid and size, there's 
> nothing left in the object I'm passing.  Just because HMP can do 
> sane defaults doesn't mean that QMP needs to mark all fields as 
> optional.

Even though this is for the command-line, I agree that both should be
mandatory.  The default (splitting memory equally across nodes) can be
specified by not having "-numa mem" at all, so there is no need to
have short versions of the "-numa mem" command line.

Paolo
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJSFmTSAAoJEBvWZb6bTYbyzUsP/3BhPGBHfzNsFHdwPL6aiBW4
67TJJ/X9GB4wjav6yjtKtBGuDNOGmEO8BkyJZVNUzw051t74uPpYzDIgd7QvrsU/
nMFRFX6q3vRUxX7k9L5RP3OkJbcAgaq8YQ135XNh59bOEd/VOeTrrEtgqyVPo45h
6tt0JSlGDPF9qc+jGoqgQN8522nvV8mcF/XhJdQ7DqttpAP75ECxViKFKezXwrsh
H3dX6v0SbWBMAlihldxEMte8hlKNB/Asb3CDQz5L2ySaPGHcwOI06wSVKGD9slbv
4SSiGg2XMdPx0VKh0ozlKmXE46+hlDJkxi7JLEuscSmZL9gZwFpenz2+29OBk2MM
g8fwxKkm36jJE7cnn/z3TPiTVZ7sJm8LvtRW2183CC5I9LpTIUrCZxxP/06ZOREq
2fH41A3PyxDOvhOwp8B3XDAnOkmklSr86hiZR+s3I+59uPa9KzOY2WFeG/6w90uq
6EmZNbmkLrZYfns7wk24YRhH9DAgTFP9GmceaJu0lEbk41INeZggswugwPvrFNI3
bPsXacwK5Y4T4ZkRs4vyaw4Dn2B732D2CMvmPJ+EpKeVIc+8tKMXNtuFKybiraQi
zrlHk4zGjeUZwW8+cx8xkHe3qyKUwbYFuRvDqSKXYRrQMzzJNMf/rNGb4JcDHiH6
BmVejHjaYKPJKA+LF3hB
=Oqhm
-----END PGP SIGNATURE-----