Re: [Qemu-devel] [PATCH V8 01/11] NUMA: add NumaOptions, NumaNodeOptions and NumaMemOptions

[Eric Blake]

On 08/19/2013 07:07 PM, Wanlong Gao wrote:
> Reviewed-by: Laszlo Ersek <address@hidden>
> Signed-off-by: Wanlong Gao <address@hidden>
> ---
>  qapi-schema.json | 47 +++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 47 insertions(+)
> 

> +##
> +# @NumaNodeOptions
> +#
> +# Create a guest NUMA node.
> +#
> +# @nodeid: #optional NUMA node ID
> +#
> +# @cpus: #optional VCPUs belong to this node
> +#
> +# @mem: #optional memory size of this node (remain as legacy)

What does (remain as legacy) mean, that I shouldn't use this parameter?
Is it something where the command line parsing code should be
translating the legacy option into the correct usage of the QMP command,
so we don't have to expose cruft?

> +#
> +# Since: 1.7
> +##
> +{ 'type': 'NumaNodeOptions',
> +  'data': {
> +   '*nodeid': 'uint16',
> +   '*cpus':   ['uint16'],
> +   '*mem':    'str' }}

Why is size passed as a 'str' instead of an integral type?  If anything,
at the QMP layer, it should be an integer representing size in bytes
(the command line and HMP are already capable of converting shorthand
like 1G into proper byte counts for use in QAPI).

> +
> +##
> +# @NumaMemOptions
> +#
> +# Set memory information of guest NUMA node.
> +#
> +# @nodeid: #optional NUMA node ID
> +#
> +# @size: #optional memory size of this node

If everything is optional, then what defaults are used if I specify
nothing?  Should nodeid be mandatory (here, and in NumaNodeOptions)?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature