Re: [Qemu-devel] [RFC] [PATCHv5 06/16] aio / timers: Untangle include files

[Stefan Hajnoczi]

On Sun, Aug 04, 2013 at 07:09:55PM +0100, Alex Bligh wrote:
> include/qemu/timer.h has no need to include main-loop.h and
> doing so causes an issue for the next patch. Unfortunately
> various files assume including timers.h will pull in main-loop.h.
> Untangle this mess.
> 
> Signed-off-by: Alex Bligh <address@hidden>
> ---
>  dma-helpers.c             |    1 +
>  hw/dma/xilinx_axidma.c    |    1 +
>  hw/timer/arm_timer.c      |    1 +
>  hw/timer/grlib_gptimer.c  |    2 ++
>  hw/timer/imx_epit.c       |    1 +
>  hw/timer/imx_gpt.c        |    1 +
>  hw/timer/lm32_timer.c     |    1 +
>  hw/timer/puv3_ost.c       |    1 +
>  hw/timer/slavio_timer.c   |    1 +
>  hw/timer/xilinx_timer.c   |    1 +
>  hw/usb/hcd-uhci.c         |    1 +
>  include/block/block_int.h |    1 +
>  include/block/coroutine.h |    2 ++
>  include/qemu/timer.h      |    1 -
>  migration-exec.c          |    1 +
>  migration-fd.c            |    1 +
>  migration-tcp.c           |    1 +
>  migration-unix.c          |    1 +
>  migration.c               |    1 +
>  nbd.c                     |    1 +
>  net/net.c                 |    1 +
>  net/socket.c              |    1 +
>  qemu-coroutine-io.c       |    1 +
>  qemu-io-cmds.c            |    1 +
>  qemu-nbd.c                |    1 +
>  slirp/misc.c              |    1 +
>  thread-pool.c             |    1 +
>  ui/vnc-auth-vencrypt.c    |    2 +-
>  ui/vnc-ws.c               |    1 +
>  29 files changed, 30 insertions(+), 2 deletions(-)

Fails to build ui/vnc-auth-sasl.c

Please make sure that your ./configure output shows most optional
dependencies are available (you need to install development packages for
these libraries).  Otherwise you will not see build breakage.

Stefan