Re: [Qemu-devel] [PATCH] monitor: Protect outbuf from concurrent access

[Anthony Liguori]

On 09/02/2011 10:31 AM, Paolo Bonzini wrote:
> On 09/02/2011 05:18 PM, Gerd Hoffmann wrote:
> > > Can you just use a bottom half to defer this work to the I/O thread?
> > > Bottom half scheduling has to be signal safe which means it will also be
> > > thread safe.
> >
> > Not that straight forward as I would have to pass arguments to the
> > bottom half.
>
> Can you add a variant of qemu_bh_new that accepts a sizeof for the new
> bottom half? Then the bottom half itself can be passed as the opaque and
> used for the arguments.

Bottom halves are opaque to the caller.

Passing arguments would require careful consideration of locking too.  I 
think the best way to resolve this is to fix libspice and not try to 
work around the problem in QEMU.

Regards,

Anthony Liguori

> Paolo