[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 16/18] usb: Remove leading underscores from __musb_i
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PATCH 16/18] usb: Remove leading underscores from __musb_irq_max |
Date: |
Fri, 2 Sep 2011 11:56:45 +0200 |
From: Peter Maydell <address@hidden>
Identifiers with double leading underscore are reserved, so rename
__musb_irq_max so we don't encroach on reserved namespace.
Signed-off-by: Peter Maydell <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>
---
hw/tusb6010.c | 6 +++---
hw/usb.h | 3 ++-
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/hw/tusb6010.c b/hw/tusb6010.c
index de6ffc6..78814f1 100644
--- a/hw/tusb6010.c
+++ b/hw/tusb6010.c
@@ -785,9 +785,9 @@ static int tusb6010_init(SysBusDevice *dev)
sysbus_init_mmio_region(dev, &s->iomem[0]);
sysbus_init_mmio_region(dev, &s->iomem[1]);
sysbus_init_irq(dev, &s->irq);
- qdev_init_gpio_in(&dev->qdev, tusb6010_irq, __musb_irq_max + 1);
- musb_irqs = g_new0(qemu_irq, __musb_irq_max);
- for (i = 0; i < __musb_irq_max; i++) {
+ qdev_init_gpio_in(&dev->qdev, tusb6010_irq, musb_irq_max + 1);
+ musb_irqs = g_new0(qemu_irq, musb_irq_max);
+ for (i = 0; i < musb_irq_max; i++) {
musb_irqs[i] = qdev_get_gpio_in(&dev->qdev, i + 1);
}
s->musb = musb_init(musb_irqs);
diff --git a/hw/usb.h b/hw/usb.h
index 73479d6..e251e61 100644
--- a/hw/usb.h
+++ b/hw/usb.h
@@ -338,7 +338,8 @@ enum musb_irq_source_e {
musb_irq_tx,
musb_set_vbus,
musb_set_session,
- __musb_irq_max,
+ /* Add new interrupts here */
+ musb_irq_max, /* total number of interrupts defined */
};
typedef struct MUSBState MUSBState;
--
1.7.1
- [Qemu-devel] [PATCH 11/18] usb: fix use after free, (continued)
- [Qemu-devel] [PATCH 11/18] usb: fix use after free, Gerd Hoffmann, 2011/09/02
- [Qemu-devel] [PATCH 13/18] usb-ccid: remote wakeup support, Gerd Hoffmann, 2011/09/02
- [Qemu-devel] [PATCH 10/18] usb-host: parse port in /proc/bus/usb/devices scan, Gerd Hoffmann, 2011/09/02
- [Qemu-devel] [PATCH 09/18] usb-host: constify port, Gerd Hoffmann, 2011/09/02
- [Qemu-devel] [PATCH 05/18] usb-host: fix configuration tracking., Gerd Hoffmann, 2011/09/02
- [Qemu-devel] [PATCH 06/18] usb-host: claim port, Gerd Hoffmann, 2011/09/02
- [Qemu-devel] [PATCH 08/18] usb-ehci: handle siTDs, Gerd Hoffmann, 2011/09/02
- [Qemu-devel] [PATCH 07/18] usb-host: endpoint table fixup, Gerd Hoffmann, 2011/09/02
- [Qemu-devel] [PATCH 15/18] usb-host: tag as unmigratable, Gerd Hoffmann, 2011/09/02
- [Qemu-devel] [PATCH 17/18] usb-musb: Take a DeviceState* in init function, Gerd Hoffmann, 2011/09/02
- [Qemu-devel] [PATCH 16/18] usb: Remove leading underscores from __musb_irq_max,
Gerd Hoffmann <=
- [Qemu-devel] [PATCH 12/18] usb-ccid: switch to USBDesc*, Gerd Hoffmann, 2011/09/02
- [Qemu-devel] [PATCH 14/18] usb: claim port at device initialization time., Gerd Hoffmann, 2011/09/02
- [Qemu-devel] [PATCH 18/18] usb-musb: Add reset function, Gerd Hoffmann, 2011/09/02
- Re: [Qemu-devel] [PULL] usb patch queue, Gerd Hoffmann, 2011/09/07
- Re: [Qemu-devel] [PULL] usb patch queue, Anthony Liguori, 2011/09/08