[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] rename vlan to vnet and mark vlan as deprecated
From: |
Gildas |
Subject: |
Re: [Qemu-devel] [PATCH] rename vlan to vnet and mark vlan as deprecated |
Date: |
Tue, 9 Dec 2008 17:30:40 +0100 |
>> I think that keeping backward compatibility is a good idea and I'm ok
>> to remove the warning message even though I don't think it does any
>> harm. I will modify the patch to document the fact that vlan= is not
>> IEEE 902.1q and that vnet= is the prefered option.
>>
>
> If we're going to switch to vnet= (and I don't think we should), then it
> should be with a flag day. And all at once conversion that changes internal
> and external references.
I'm not sure I understand what you mean by that
>> I really think that it's a change that should done, both in the code
>> and usage as both will greatly benefit from a move to VNET. Just look
>> at the actual naming mess in e1000.c where real 802.1q handling takes
>> place as well...
>>
>
> I think this may cause minor confusion for a very small number of people,
> but for most people, who probably have no idea what 802.1q is, it never is
> an issue.
>
> This is only the second time I've seen someone get confused by vlan= since
> the syntax was introduced. It's really not a big deal AFAICT.
>
> Regards,
>
> Anthony Liguori
As I see it, people who have no idea what 802.1q vlans are are not
sysadmins and will probably never use the vlan= option...
I'm confused about the reasons why an improvement for end users, be it
minor, should be rejected.
Regards.
Gildas