Re: [Qemu-devel] [PATCH] rename vlan to vnet and mark vlan as deprecated

[Gildas]

2008/12/9 Anthony Liguori <address@hidden>:
> Daniel P. Berrange wrote:
>>
>> On Tue, Dec 09, 2008 at 04:01:53PM +0100, Gildas wrote:
>>
>>>
>>> --
>>> This patch renames occurences of vlan/VLAN that are not related to IEE
>>> 802.1q vlans to vnet/VNET respectively.
>>>
>>> Usage of vlan= in the -net options is still allowed but will produce
>>> an error message on stderr indicating that the option is now
>>> deprecated and will be removed in the future.
>>>
>>
>> This bit will just piss people off. By all means change t to allow
>> the net vnet= option, but printing out a warning for vlan= on every
>> boot is just going to annoy people and they cannot simply change
>> their scripts because they may well need to run with old QEMU and
>> new QEMU
>>
>
> Introducing an alias for something as core as vlan support is not all that
> useful.  We're never going to implement the vlan option.
>
> All of the internal references are for vlan too.
>
> Regards,
>
> Anthony Liguori

I think that keeping backward compatibility is a good idea and I'm ok
to remove the warning message even though I don't think it does any
harm.  I will modify the patch to document the fact that vlan=  is not
IEEE 902.1q and that vnet= is the prefered option.

I really think that it's a change that should done, both in the code
and usage as both will greatly benefit from a move to VNET. Just look
at the actual naming mess in e1000.c where real 802.1q handling takes
place as well...

Regards,
Gildas