[Qemu-commits] [qemu/qemu] c27b05: tests/vm: do not specify -bios option

[Richard Henderson]

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: c27b051151face4a3b36debee250a4c1a0222211
      
https://github.com/qemu/qemu/commit/c27b051151face4a3b36debee250a4c1a0222211
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2022-06-23 (Thu, 23 Jun 2022)

  Changed paths:
    M tests/vm/fedora
    M tests/vm/freebsd
    M tests/vm/netbsd
    M tests/vm/openbsd

  Log Message:
  -----------
  tests/vm: do not specify -bios option

When running from the build tree, the executable is able to find
the BIOS on its own; when running from the source tree, a firmware
blob should already be installed and there is no guarantee that
the one in the source tree works with the QEMU that is being used for
the installation.

Just remove the -bios option, since it is unnecessary and in fact
there are other x86 VM tests that do not bother specifying it.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: 7100286580051b8fcf2f50e56d34ec167fd6383b
      
https://github.com/qemu/qemu/commit/7100286580051b8fcf2f50e56d34ec167fd6383b
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2022-06-23 (Thu, 23 Jun 2022)

  Changed paths:
    M pc-bios/optionrom/Makefile
    R pc-bios/optionrom/code16gcc.h

  Log Message:
  -----------
  pc-bios/optionrom: use -m16 unconditionally

Remove support for .code16gcc, all supported platforms have -m16.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: f904a9e218555c47aa1fce95bcf067285884ac08
      
https://github.com/qemu/qemu/commit/f904a9e218555c47aa1fce95bcf067285884ac08
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2022-06-23 (Thu, 23 Jun 2022)

  Changed paths:
    M configure
    M pc-bios/optionrom/Makefile

  Log Message:
  -----------
  configure, pc-bios/optionrom: pass cross CFLAGS correctly

The optionrom build is disregarding the flags passed to the configure
script via --cross-cflags-i386.  Pass it down and add it to the Makefile.

This will make it possible to get the -m32 flag from $target_cflags to
force a 32-bit build on 64-bit hosts, instead of supplying manually the
arcane -Wa,-32 and linker emulation options.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: 056d7b18bdd8ec96f528c77dead14cdc572fa21e
      
https://github.com/qemu/qemu/commit/056d7b18bdd8ec96f528c77dead14cdc572fa21e
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2022-06-23 (Thu, 23 Jun 2022)

  Changed paths:
    M configure
    M pc-bios/s390-ccw/Makefile
    M pc-bios/s390-ccw/netboot.mak

  Log Message:
  -----------
  configure, pc-bios/s390-ccw: pass cross CFLAGS correctly

QEMU_CFLAGS is not available in pc-bios/s390-ccw/netboot.mak, but the Makefile
needs to access the flags passed to the configure script for the s390x
cross compiler.  Fix everything and rename QEMU_CFLAGS to EXTRA_CFLAGS for
consistency with tests/tcg.

Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: 4bd90add2fc6005bb4e5b8af995e43acebd15341
      
https://github.com/qemu/qemu/commit/4bd90add2fc6005bb4e5b8af995e43acebd15341
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2022-06-23 (Thu, 23 Jun 2022)

  Changed paths:
    M configure
    M pc-bios/vof/Makefile

  Log Message:
  -----------
  configure, pc-bios/vof: pass cross CFLAGS correctly

Use the flags passed to the configure script for the ppc cross compiler,
which in fact default to those that are needed to get the 32-bit ISA.
Add the endianness flag so that it remains possible to use a ppc64le
compiler to compile VOF.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: 500ea101d2b4518f7009a6094b63a187d6b2b6e3
      
https://github.com/qemu/qemu/commit/500ea101d2b4518f7009a6094b63a187d6b2b6e3
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2022-06-23 (Thu, 23 Jun 2022)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: allow more host/target combos to use the host compiler

Add more pairs of bi-arch compilers, so that it is not necessary to have
e.g. both little-endian and big-endian ARM compilers.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: d720fd6ff4ec5140966e1e11ace6c1d0bf4a682d
      
https://github.com/qemu/qemu/commit/d720fd6ff4ec5140966e1e11ace6c1d0bf4a682d
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2022-06-23 (Thu, 23 Jun 2022)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: write EXTRA_CFLAGS for all sub-Makefiles

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: b12451a49e1e80a68720a415ea809bdcf67a8ffc
      
https://github.com/qemu/qemu/commit/b12451a49e1e80a68720a415ea809bdcf67a8ffc
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2022-06-23 (Thu, 23 Jun 2022)

  Changed paths:
    M tests/tcg/Makefile.target
    M tests/tcg/aarch64/system/pauth-3.c
    M tests/tcg/aarch64/system/semiconsole.c
    M tests/tcg/aarch64/system/semiheap.c
    M tests/tcg/multiarch/system/memory.c

  Log Message:
  -----------
  tests/tcg: compile system emulation tests as freestanding

System emulation tests do not run in a hosted environment, since they
do not link with libc.  They should only use freestanding headers
(float.h, limits.h, stdarg.h, stddef.h, stdbool.h, stdint.h,
stdalign.h, stdnoreturn.h) and should be compiled with -ffreestanding
in order to use the compiler implementation of those headers
rather than the one in libc.

Some tests are using inttypes.h instead of stdint.h, so fix that.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: d0c52089f32d5df46d9bf3af5c6cc107a1f6763f
      
https://github.com/qemu/qemu/commit/d0c52089f32d5df46d9bf3af5c6cc107a1f6763f
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2022-06-23 (Thu, 23 Jun 2022)

  Changed paths:
    M configure

  Log Message:
  -----------
  build: try both native and cross compilers for linux-user tests

Configure is trying to fall back on cross compilers for targets that
can have bi-arch or bi-endian toolchains, but there are many corner
cases where just checking the name can go wrong.  For example, the RHEL
ppc64le compiler is bi-arch and bi-endian, but multilibs are disabled.
Therefore it cannot be used to build 32-bit hosted binaries like the
linux-user TCG tests.

Trying the cross compiler first also does not work, and an example for
this is also ppc64le.  The powerpc64-linux-gnu-gcc binary from the
cross-gcc package is theoretically multilib-friendly, but it cannot
find the CRT files on a ppc64le host, because they are not in the .../le
multilib subdirectory.

This can be fixed by testing both the native compiler and the cross
compiler, and proceeding with the first one that works.  To do this,
move the compiler usability check from the tests/tcg snippet to inside
probe_target_compiler and, while at it, restrict it to just the user-mode
emulation tests; if a compiler is not able to build nostdlib freestanding
binaries the installation is broken.

Tested-by: Matheus Kowalczuk Ferst <matheus.ferst@eldorado.org.br>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: eaea7f78f16b4e8115c84b7580d7b65c5c0201d1
      
https://github.com/qemu/qemu/commit/eaea7f78f16b4e8115c84b7580d7b65c5c0201d1
  Author: Alexander Bulekov <alxndr@bu.edu>
  Date:   2022-06-23 (Thu, 23 Jun 2022)

  Changed paths:
    M meson.build

  Log Message:
  -----------
  build: improve -fsanitize-coverage-allowlist check

The sancov filter check still fails when unused arguments are treated as
errors. To work around that, add a SanitizerCoverage flag to the
build-check.

Fixes: aa4f3a3b88 ("build: fix check for -fsanitize-coverage-allowlist")
Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
Message-Id: <20220621204507.698711-1-alxndr@bu.edu>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: 102d599afeeae445f1010c74345415a848a73a94
      
https://github.com/qemu/qemu/commit/102d599afeeae445f1010c74345415a848a73a94
  Author: Alexander Bulekov <alxndr@bu.edu>
  Date:   2022-06-24 (Fri, 24 Jun 2022)

  Changed paths:
    M scripts/oss-fuzz/build.sh

  Log Message:
  -----------
  fuzz: only use generic-fuzz targets on oss-fuzz

The non-generic-fuzz targets often time-out, or run out of memory.
Additionally, they create unreproducible bug-reports. It is possible
that this is resulting in failing coverage-reports on OSS-Fuzz. In the
future, these test-cases should be fixed, or removed.

Reviewed-by: Darren Kenny <darren.kenny@oracle.com>
Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
Message-Id: <20220623125505.2137534-1-alxndr@bu.edu>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: 42e473386c11b0d3d5640817e00a11b75c5b7027
      
https://github.com/qemu/qemu/commit/42e473386c11b0d3d5640817e00a11b75c5b7027
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2022-06-24 (Fri, 24 Jun 2022)

  Changed paths:
    M audio/meson.build
    M meson.build

  Log Message:
  -----------
  audio/dbus: fix building

Commit c9c847481 broken dbus audio module compilation with bad
'CONFIG_GIO' usage. Furthermore, it implied extra dependency on audio
module which aren't necessary.

The problem was that 'dbus_display' is not correctly automatically set
on MacOS, because opengl dependency wasn't taken into account.

Fixes: c9c847481 ("audio/dbus: Fix building with modules on macOS")
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20220622154918.560870-1-marcandre.lureau@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: 642051ebe883fc2be1dafe1a764a52cac638d4cd
      
https://github.com/qemu/qemu/commit/642051ebe883fc2be1dafe1a764a52cac638d4cd
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2022-06-24 (Fri, 24 Jun 2022)

  Changed paths:
    M meson.build

  Log Message:
  -----------
  meson.build: Require a recent version of libpng

According to https://gitlab.com/qemu-project/qemu/-/issues/1080#note_998088246
QEMU does not compile with older versions of libpng, so we should check
for a good version in meson.build. According to repology.org, our supported
host target operating systems ship these versions:

             Fedora 35: 1.6.37
     CentOS 8 (RHEL-8): 1.6.34
             Debian 11: 1.6.37
    OpenSUSE Leap 15.3: 1.6.34
      Ubuntu LTS 20.04: 1.6.37
         FreeBSD Ports: 1.6.37
         NetBSD pkgsrc: 1.6.37
         OpenBSD Ports: 1.6.37
              Homebrew: 1.6.37
           MSYS2 mingw: 1.6.37

So it seem reasonable to require at least libpng version 1.6.34 for
our builds.

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1080
Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20220623174941.531196-1-thuth@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: 72da35fec9a9ba91a5b2cb9ee00843a94fa9413d
      
https://github.com/qemu/qemu/commit/72da35fec9a9ba91a5b2cb9ee00843a94fa9413d
  Author: Miaoqian Lin <linmq006@gmail.com>
  Date:   2022-06-24 (Fri, 24 Jun 2022)

  Changed paths:
    M accel/kvm/kvm-all.c

  Log Message:
  -----------
  accel: kvm: Fix memory leak in find_stats_descriptors

This function doesn't release descriptors in one error path,
result in memory leak. Call g_free() to release it.

Fixes: cc01a3f4cadd ("kvm: Support for querying fd-based stats")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Message-Id: <20220624063159.57411-1-linmq006@gmail.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: db16f7d2f9b78276eb375c33d82e69a73b805450
      
https://github.com/qemu/qemu/commit/db16f7d2f9b78276eb375c33d82e69a73b805450
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2022-06-24 (Fri, 24 Jun 2022)

  Changed paths:
    M accel/kvm/kvm-all.c
    M audio/meson.build
    M configure
    M meson.build
    M pc-bios/optionrom/Makefile
    R pc-bios/optionrom/code16gcc.h
    M pc-bios/s390-ccw/Makefile
    M pc-bios/s390-ccw/netboot.mak
    M pc-bios/vof/Makefile
    M scripts/oss-fuzz/build.sh
    M tests/tcg/Makefile.target
    M tests/tcg/aarch64/system/pauth-3.c
    M tests/tcg/aarch64/system/semiconsole.c
    M tests/tcg/aarch64/system/semiheap.c
    M tests/tcg/multiarch/system/memory.c
    M tests/vm/fedora
    M tests/vm/freebsd
    M tests/vm/netbsd
    M tests/vm/openbsd

  Log Message:
  -----------
  Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging

* fuzzing fixes
* fix cross compilation CFLAGS and compiler choice
* do not specify -bios option for tests/vm
* miscellaneous fixes

# -----BEGIN PGP SIGNATURE-----
#
# iQFIBAABCAAyFiEE8TM4V0tmI4mGbHaCv/vSX3jHroMFAmK1c9UUHHBib256aW5p
# QHJlZGhhdC5jb20ACgkQv/vSX3jHroN5CwgArHkYVVGt2G5HKSazUZ8LGn3Qwy0q
# pN1HraKR9wRnlXc3hQVXQ40XcejoLBm/XznmJSU3QnyLeWeHg/gaAdTEBZiXTjz8
# ixRVH6QBWaEqgyZ/+7ULQfHSG+0ig+u+R0cY0vmFf9wgOe4+Of/Z5s7p4SiqvsxM
# nrTX3Fri8AblgGdxZxfuIAOiJDPBS0JBlVOUMhS5ASPp6751xhx0c2HAmCPeoJS8
# qOnsYKR1FoJ21nuWG/EGe1kYQyIg4fOF5UBvW1jNocesyb6PxR0kR1zVmPZ5B3fN
# Rw+sAZv6k1gSV+fFK8m3RhO/TDLnJhJa0r01yWqZXaT3Mm9XvJT5QFLWYQ==
# =4uJY
# -----END PGP SIGNATURE-----
# gpg: Signature made Fri 24 Jun 2022 01:20:37 AM PDT
# gpg:                using RSA key F13338574B662389866C7682BFFBD25F78C7AE83
# gpg:                issuer "pbonzini@redhat.com"
# gpg: Good signature from "Paolo Bonzini <bonzini@gnu.org>" [undefined]
# gpg:                 aka "Paolo Bonzini <pbonzini@redhat.com>" [undefined]
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg:          There is no indication that the signature belongs to the owner.
# Primary key fingerprint: 46F5 9FBD 57D6 12E7 BFD4  E2F7 7E15 100C CD36 69B1
#      Subkey fingerprint: F133 3857 4B66 2389 866C  7682 BFFB D25F 78C7 AE83

* tag 'for-upstream' of https://gitlab.com/bonzini/qemu:
  accel: kvm: Fix memory leak in find_stats_descriptors
  meson.build: Require a recent version of libpng
  audio/dbus: fix building
  fuzz: only use generic-fuzz targets on oss-fuzz
  build: improve -fsanitize-coverage-allowlist check
  build: try both native and cross compilers for linux-user tests
  tests/tcg: compile system emulation tests as freestanding
  configure: write EXTRA_CFLAGS for all sub-Makefiles
  configure: allow more host/target combos to use the host compiler
  configure, pc-bios/vof: pass cross CFLAGS correctly
  configure, pc-bios/s390-ccw: pass cross CFLAGS correctly
  configure, pc-bios/optionrom: pass cross CFLAGS correctly
  pc-bios/optionrom: use -m16 unconditionally
  tests/vm: do not specify -bios option

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


Compare: https://github.com/qemu/qemu/compare/3a821c52e1a3...db16f7d2f9b7