qemu-commits
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 6f8ddc: target/i386: tracing: format length v

From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] 6f8ddc: target/i386: tracing: format length values as hex
Date: Mon, 14 Dec 2020 12:54:54 -0800 
  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: 6f8ddc2a89ba3b4add7aa2b351c04d810795c3df
      
https://github.com/qemu/qemu/commit/6f8ddc2a89ba3b4add7aa2b351c04d810795c3df
  Author: Dov Murik <dovmurik@linux.vnet.ibm.com>
  Date:   2020-12-13 (Sun, 13 Dec 2020)

  Changed paths:
    M target/i386/trace-events

  Log Message:
  -----------
  target/i386: tracing: format length values as hex

Three trace events had a literal "0x" prefix but the 'len' values were
formatted in decimal base.  Keep the prefix and format the numbers as
hex, as is usually the case for length of memory regions.

Signed-off-by: Dov Murik <dovmurik@linux.vnet.ibm.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20201103100745.160409-1-dovmurik@linux.vnet.ibm.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: fa647905e6baae9510e7ddcd640961bad60ba14c
      
https://github.com/qemu/qemu/commit/fa647905e6baae9510e7ddcd640961bad60ba14c
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2020-12-13 (Sun, 13 Dec 2020)

  Changed paths:
    M qemu-options.hx

  Log Message:
  -----------
  qemu-options.hx: Fix minor issues in icount documentation

The documentation for the icount documentation has some minor issues:
 * in a couple of places it says "sleep=on|off" when in the context of the
   sentence it means specifically "sleep=on"
 * the synopsis line for the documentation has drifted out of sync
   with the synopsis line in the DEF() macro (used for "-help" output)
 * the synopsis line in the DEF() macro is missing a "][" between
   the sleep= part and the rr= part
 * the synopsis line doesn't indicate that rrsnapshot is an optional
   part of the rr=mode,rrfile=filename subgrouping
 * we don't document that sleep=on can't be used with shift=auto
   or align=on
 * the rr option description had some minor grammar and formatting
   errors and was a bit terse
 * in commit f1f4b57e88ff in 2015 the documentation of the sleep=
   suboption got added between the two paragraphs defining general
   behaviour of the icount option. This meant that the second
   paragraph talking about the behaviour of "this option" reads as
   if it's talking about sleep=on, when it's really describing -icount
   as a whole. The paragraph is better moved back up to above the
   sleep= section.
 * the summary text displayed in "-help" output didn't mention
   the record-and-replay part

Fix these errors.

Fixes: https://bugs.launchpad.net/qemu/+bug/1774412
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20201121213506.15599-1-peter.maydell@linaro.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: 2f5f9bc88d54a3c702c854560331951a2820529c
      
https://github.com/qemu/qemu/commit/2f5f9bc88d54a3c702c854560331951a2820529c
  Author: Michael Roth <michael.roth@amd.com>
  Date:   2020-12-13 (Sun, 13 Dec 2020)

  Changed paths:
    M MAINTAINERS

  Log Message:
  -----------
  MAINTAINERS: update my email address

I've recently switched employers and the current email address is out
of date.

Signed-off-by: Michael Roth <michael.roth@amd.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20201027060253.353054-1-michael.roth@amd.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: 01d152c0bfabadc6c93a39e465eb2f66f3f11527
      
https://github.com/qemu/qemu/commit/01d152c0bfabadc6c93a39e465eb2f66f3f11527
  Author: Xinhao Zhang <zhangxinhao1@huawei.com>
  Date:   2020-12-13 (Sun, 13 Dec 2020)

  Changed paths:
    M hw/xen/xen_pt.c
    M hw/xen/xen_pt_config_init.c
    M hw/xen/xen_pt_msi.c

  Log Message:
  -----------
  hw/xen: Don't use '#' flag of printf format

Fix code style. Don't use '#' flag of printf format ('%#') in
format strings, use '0x' prefix instead

Signed-off-by: Xinhao Zhang <zhangxinhao1@huawei.com>
Signed-off-by: Kai Deng <dengkai1@huawei.com>
Message-Id: <20201104133709.3326630-1-zhangxinhao1@huawei.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: f6a3c86ebd39aaedf1ebf89629ec91b5d44b670d
      
https://github.com/qemu/qemu/commit/f6a3c86ebd39aaedf1ebf89629ec91b5d44b670d
  Author: Philippe Mathieu-Daudé <philmd@redhat.com>
  Date:   2020-12-13 (Sun, 13 Dec 2020)

  Changed paths:
    M hw/pci-host/pam.c
    M hw/pci-host/q35.c
    M include/hw/pci-host/i440fx.h
    M include/hw/pci-host/pam.h
    M include/hw/pci-host/q35.h

  Log Message:
  -----------
  hw/pci-host/pam: Replace magic number by PAM_REGIONS_COUNT definition

While this change helps triskaidekaphobic developers, it
is a good practice to avoid magic values and using constant
definitions instead.

Introduce the PAM_REGIONS_COUNT and use it. No logical change.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Julia Suvorova <jusual@redhat.com>
Message-Id: <20201202132038.1276404-1-philmd@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: 87b804ec4c05d793f9c6374b0e90ef2614bb5b25
      
https://github.com/qemu/qemu/commit/87b804ec4c05d793f9c6374b0e90ef2614bb5b25
  Author: zhouyang <zhouyang789@huawei.com>
  Date:   2020-12-13 (Sun, 13 Dec 2020)

  Changed paths:
    M fsdev/9p-marshal.h
    M fsdev/file-op-9p.h

  Log Message:
  -----------
  fsdev: open brace '{' following struct go on the same line

I found some style problems while check the code using checkpatch.pl.
This commit fixs the issue below:
ERROR: open brace '{' following struct go on the same line

Signed-off-by: zhouyang <zhouyang789@huawei.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20201209060735.2760943-1-zhouyang789@huawei.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: a998de0dcd4dd62bd8aa4f7aad381ac36220b012
      
https://github.com/qemu/qemu/commit/a998de0dcd4dd62bd8aa4f7aad381ac36220b012
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2020-12-13 (Sun, 13 Dec 2020)

  Changed paths:
    M CODING_STYLE.rst

  Log Message:
  -----------
  CODING_STYLE.rst: Be less strict about 80 character limit

Relax the wording about line lengths a little bit; this goes with the
checkpatch changes to warn at 100 characters rather than 80.

(Compare the Linux kernel commit bdc48fa11e46f8; our coding style is
not theirs, but the rationale is good and applies to us too.)

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Message-Id: <20201106112940.31300-1-peter.maydell@linaro.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: f12985f14a05181b34b3cfb935b4136a05726423
      
https://github.com/qemu/qemu/commit/f12985f14a05181b34b3cfb935b4136a05726423
  Author: Gan Qixin <ganqixin@huawei.com>
  Date:   2020-12-13 (Sun, 13 Dec 2020)

  Changed paths:
    M hw/arm/Kconfig
    M hw/display/Kconfig
    R hw/display/ads7846.c
    M hw/display/meson.build
    M hw/input/Kconfig
    A hw/input/ads7846.c
    M hw/input/meson.build

  Log Message:
  -----------
  ads7846: moves from the hw/display folder to the hw/input folder.

ads7846 is a touch-screen controller that is an input device rather
than a display device, so move it to the hw/input folder.

Signed-off-by: Gan Qixin <ganqixin@huawei.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20201115123503.1110665-1-ganqixin@huawei.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: 8e2c76bd3ff2e81738195bdcc6bfdb8b2ddc7649
      
https://github.com/qemu/qemu/commit/8e2c76bd3ff2e81738195bdcc6bfdb8b2ddc7649
  Author: Roman Bolshakov <r.bolshakov@yadro.com>
  Date:   2020-12-13 (Sun, 13 Dec 2020)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: Test if $make actually exists

configure doesn't detect if $make is installed on the build host.
This is also helpful for hosts where an alias for make is used, i.e.
configure would fail if gmake is not present on macOS.

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20200825202755.50626-5-r.bolshakov@yadro.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: 514284d73d09910451bf00640ee52088e71dbc4b
      
https://github.com/qemu/qemu/commit/514284d73d09910451bf00640ee52088e71dbc4b
  Author: Pan Nengyuan <pannengyuan@huawei.com>
  Date:   2020-12-13 (Sun, 13 Dec 2020)

  Changed paths:
    M contrib/elf2dmp/qemu_elf.c

  Log Message:
  -----------
  elf2dmp/qemu_elf: Plug memleak in QEMU_Elf_init

Missing g_error_free in QEMU_Elf_init() error path. Fix that.

Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com>
Reviewed-by: Viktor Prutyanov <viktor.prutyanov@phystech.edu>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20201023061218.2080844-4-kuhn.chenqun@huawei.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: 0c4c8671d79023a05d916e73d9b4399abff9c0a0
      
https://github.com/qemu/qemu/commit/0c4c8671d79023a05d916e73d9b4399abff9c0a0
  Author: Pan Nengyuan <pannengyuan@huawei.com>
  Date:   2020-12-13 (Sun, 13 Dec 2020)

  Changed paths:
    M contrib/elf2dmp/pdb.c

  Log Message:
  -----------
  elf2dmp/pdb: Plug memleak in pdb_init_from_file

Missing g_error_free in pdb_init_from_file() error path. Fix that.

Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com>
Reviewed-by: Viktor Prutyanov <viktor.prutyanov@phystech.edu>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20201023061218.2080844-5-kuhn.chenqun@huawei.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: cb8d0851f1c00daafd736757a22f4820ec081b68
      
https://github.com/qemu/qemu/commit/cb8d0851f1c00daafd736757a22f4820ec081b68
  Author: Pan Nengyuan <pannengyuan@huawei.com>
  Date:   2020-12-13 (Sun, 13 Dec 2020)

  Changed paths:
    M block/file-posix.c

  Log Message:
  -----------
  block/file-posix: fix a possible undefined behavior

local_err is not initialized to NULL, it will cause a assert error as below:
qemu/util/error.c:59: error_setv: Assertion `*errp == NULL' failed.

Fixes: c6447510690
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
Message-Id: <20201023061218.2080844-8-kuhn.chenqun@huawei.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: 94237657af9ac7af6bc9fa0c5d9f0af1a39adb45
      
https://github.com/qemu/qemu/commit/94237657af9ac7af6bc9fa0c5d9f0af1a39adb45
  Author: Pan Nengyuan <pannengyuan@huawei.com>
  Date:   2020-12-13 (Sun, 13 Dec 2020)

  Changed paths:
    M blockdev.c

  Log Message:
  -----------
  blockdev: Fix a memleak in drive_backup_prepare()

'local_err' seems forgot to propagate in error path, it'll cause
a memleak. Fix it.

Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
Message-Id: <20201023061218.2080844-7-kuhn.chenqun@huawei.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: 5a42999b1f982873f32c02e7f712a2bd89135cc6
      
https://github.com/qemu/qemu/commit/5a42999b1f982873f32c02e7f712a2bd89135cc6
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2020-12-13 (Sun, 13 Dec 2020)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: Remove the obsolete check for ifaddrs.h

The code that used HAVE_IFADDRS_H has been removed in commit
0a27af918b ("io: use bind() to check for IPv4/6 availability"),
so we don't need this check in the configure script anymore.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20201118171052.308191-2-thuth@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: 2802d91d515f3e51a8b3515a35e79c2c676da9e5
      
https://github.com/qemu/qemu/commit/2802d91d515f3e51a8b3515a35e79c2c676da9e5
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2020-12-13 (Sun, 13 Dec 2020)

  Changed paths:
    M configure
    M meson.build

  Log Message:
  -----------
  configure / meson: Move check for pty.h to meson.build

This check can be done in a much shorter way in meson.build

Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20201118171052.308191-3-thuth@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: 2964be527aecc10c89d7d99d186a2c36333d5e87
      
https://github.com/qemu/qemu/commit/2964be527aecc10c89d7d99d186a2c36333d5e87
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2020-12-13 (Sun, 13 Dec 2020)

  Changed paths:
    M configure
    M meson.build

  Log Message:
  -----------
  configure / meson: Move check for drm.h to meson.build

This check can be done in a much shorter way in meson.build

Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20201118171052.308191-4-thuth@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: 88c78f162a564ae17b3369b88c85e567d98ff9c7
      
https://github.com/qemu/qemu/commit/88c78f162a564ae17b3369b88c85e567d98ff9c7
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2020-12-13 (Sun, 13 Dec 2020)

  Changed paths:
    M configure
    M meson.build

  Log Message:
  -----------
  configure / meson: Move check for sys/signal.h to meson.build

This check can be done in a much shorter way in meson.build

Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20201118171052.308191-5-thuth@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: 4a9d5f895adc25f043a382a3d5bf7237905d8991
      
https://github.com/qemu/qemu/commit/4a9d5f895adc25f043a382a3d5bf7237905d8991
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2020-12-13 (Sun, 13 Dec 2020)

  Changed paths:
    M configure
    M linux-user/ioctls.h
    M linux-user/syscall.c
    M meson.build

  Log Message:
  -----------
  configure / meson: Move check for sys/kcov.h to meson.build

This check can be done in a much shorter way in meson.build. And while
we're at it, rename the #define to HAVE_SYS_KCOV_H to match the other
HAVE_someheader_H symbols that we already have.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20201118171052.308191-6-thuth@redhat.com>
[lv: s/signal/kcov/]
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: 48f670ecfcbe92f63475c516aefb6e217f469bbf
      
https://github.com/qemu/qemu/commit/48f670ecfcbe92f63475c516aefb6e217f469bbf
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2020-12-13 (Sun, 13 Dec 2020)

  Changed paths:
    M configure
    M linux-user/syscall.c
    M linux-user/syscall_defs.h
    M meson.build

  Log Message:
  -----------
  configure / meson: Move check for linux/btrfs.h to meson.build

This check can be done in a much shorter way in meson.build. And while
we're at it, rename the #define to HAVE_BTRFS_H to match the other
HAVE_someheader_H symbols that we already have.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20201118171052.308191-7-thuth@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: 5bfbd8170ce7acb98a1834ff49ed7340b0837144
      
https://github.com/qemu/qemu/commit/5bfbd8170ce7acb98a1834ff49ed7340b0837144
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2020-12-14 (Mon, 14 Dec 2020)

  Changed paths:
    M CODING_STYLE.rst
    M MAINTAINERS
    M block/file-posix.c
    M blockdev.c
    M configure
    M contrib/elf2dmp/pdb.c
    M contrib/elf2dmp/qemu_elf.c
    M fsdev/9p-marshal.h
    M fsdev/file-op-9p.h
    M hw/arm/Kconfig
    M hw/display/Kconfig
    R hw/display/ads7846.c
    M hw/display/meson.build
    M hw/input/Kconfig
    A hw/input/ads7846.c
    M hw/input/meson.build
    M hw/pci-host/pam.c
    M hw/pci-host/q35.c
    M hw/xen/xen_pt.c
    M hw/xen/xen_pt_config_init.c
    M hw/xen/xen_pt_msi.c
    M include/hw/pci-host/i440fx.h
    M include/hw/pci-host/pam.h
    M include/hw/pci-host/q35.h
    M linux-user/ioctls.h
    M linux-user/syscall.c
    M linux-user/syscall_defs.h
    M meson.build
    M qemu-options.hx
    M target/i386/trace-events

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/vivier2/tags/trivial-branch-for-6.0-pull-request' into staging

Pull request trivial-patches 20201214

# gpg: Signature made Mon 14 Dec 2020 15:52:07 GMT
# gpg:                using RSA key CD2F75DDC8E3A4DC2E4F5173F30C38BD3F2FBE3C
# gpg:                issuer "laurent@vivier.eu"
# gpg: Good signature from "Laurent Vivier <lvivier@redhat.com>" [full]
# gpg:                 aka "Laurent Vivier <laurent@vivier.eu>" [full]
# gpg:                 aka "Laurent Vivier (Red Hat) <lvivier@redhat.com>" 
[full]
# Primary key fingerprint: CD2F 75DD C8E3 A4DC 2E4F  5173 F30C 38BD 3F2F BE3C

* remotes/vivier2/tags/trivial-branch-for-6.0-pull-request:
  configure / meson: Move check for linux/btrfs.h to meson.build
  configure / meson: Move check for sys/kcov.h to meson.build
  configure / meson: Move check for sys/signal.h to meson.build
  configure / meson: Move check for drm.h to meson.build
  configure / meson: Move check for pty.h to meson.build
  configure: Remove the obsolete check for ifaddrs.h
  blockdev: Fix a memleak in drive_backup_prepare()
  block/file-posix: fix a possible undefined behavior
  elf2dmp/pdb: Plug memleak in pdb_init_from_file
  elf2dmp/qemu_elf: Plug memleak in QEMU_Elf_init
  configure: Test if $make actually exists
  ads7846: moves from the hw/display folder to the hw/input folder.
  CODING_STYLE.rst: Be less strict about 80 character limit
  fsdev: open brace '{' following struct go on the same line
  hw/pci-host/pam: Replace magic number by PAM_REGIONS_COUNT definition
  hw/xen: Don't use '#' flag of printf format
  MAINTAINERS: update my email address
  qemu-options.hx: Fix minor issues in icount documentation
  target/i386: tracing: format length values as hex

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/aa14de086675...5bfbd8170ce7
reply via email to
[Prev in Thread] Current Thread [Next in Thread]