[Qemu-commits] [qemu/qemu] bc3bde: CODING_STYLE.rst: flesh out our naming conventions.

[Peter Maydell]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: bc3bde84484e39cd922486ac7e755d3e29e8a22f
      
https://github.com/qemu/qemu/commit/bc3bde84484e39cd922486ac7e755d3e29e8a22f
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2020-09-10 (Thu, 10 Sep 2020)

  Changed paths:
    M CODING_STYLE.rst

  Log Message:
  -----------
  CODING_STYLE.rst: flesh out our naming conventions.

Mention a few of the more common naming conventions we follow in the
code base including common variable names and function prefix and
suffix examples.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20200909112742.25730-2-alex.bennee@linaro.org>


  Commit: 4969e697c15ac536d5c0700381d5d026ef7f0588
      
https://github.com/qemu/qemu/commit/4969e697c15ac536d5c0700381d5d026ef7f0588
  Author: Gerd Hoffmann <kraxel@redhat.com>
  Date:   2020-09-10 (Thu, 10 Sep 2020)

  Changed paths:
    M hw/usb/host-libusb.c

  Log Message:
  -----------
  usb-host: restrict workaround to new libusb versions

Fixes build failures with old kernels (USBDEVFS_GET_SPEED missing),
on the assumtion that distros with old kernels also have old libusb.

Reported-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20200902081445.3291-1-kraxel@redhat.com>
Message-Id: <20200909112742.25730-3-alex.bennee@linaro.org>


  Commit: 7f808687448d767e5f336c1e28e58fe112d72a8c
      
https://github.com/qemu/qemu/commit/7f808687448d767e5f336c1e28e58fe112d72a8c
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2020-09-10 (Thu, 10 Sep 2020)

  Changed paths:
    M .travis.yml
    M tests/meson.build

  Log Message:
  -----------
  tests/meson.build: fp tests don't need CONFIG_TCG

As the tests build only softfloat.c no actual TCG machinary is needed
to test them (as is evidenced by GCC check-softfloat). Might as well
fix the wording on Travis while at it.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20200909112742.25730-4-alex.bennee@linaro.org>


  Commit: 102661430cae403ce8cc5768f1a55512c92234be
      
https://github.com/qemu/qemu/commit/102661430cae403ce8cc5768f1a55512c92234be
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2020-09-10 (Thu, 10 Sep 2020)

  Changed paths:
    M target/mips/translate.c

  Log Message:
  -----------
  target/mips: simplify gen_compute_imm_branch logic

One of the Travis builds was complaining about:

  qemu/include/tcg/tcg.h:437:12: error: ‘cond’ may be used uninitialized in 
this function [-Werror=maybe-uninitialized]
       return (TCGCond)(c ^ 1);
  ../target/mips/translate.c:20031:13: note: ‘cond’ was declared here
       TCGCond cond;

Rather than figure out exactly which one was causing the complaint I
just defaulted to TCG_COND_ALWAYS and allowed that state to double up
for the now defunct bcond_compute variable.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20200909112742.25730-5-alex.bennee@linaro.org>


  Commit: c609274b8531768f3341091cce50aa1224194285
      
https://github.com/qemu/qemu/commit/c609274b8531768f3341091cce50aa1224194285
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2020-09-10 (Thu, 10 Sep 2020)

  Changed paths:
    M docs/system/deprecated.rst

  Log Message:
  -----------
  docs/system/deprecated: mark ppc64abi32-linux-user for deprecation

It's buggy and we are not sure anyone uses it.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Acked-by: David Gibson <david@gibson.dropbear.id.au>
Message-Id: <20200909112742.25730-6-alex.bennee@linaro.org>


  Commit: 2d838d9bae05b76af574330cf6707527568abe03
      
https://github.com/qemu/qemu/commit/2d838d9bae05b76af574330cf6707527568abe03
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2020-09-10 (Thu, 10 Sep 2020)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: don't enable ppc64abi32-linux-user by default

The user can still enable this explicitly but they will get a warning
at the end of configure for their troubles. This also drops any builds
of ppc64abi32 from our CI tests.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20200909112742.25730-7-alex.bennee@linaro.org>


  Commit: c768eef18c18087d39eaf0e090629dbbca0f51dc
      
https://github.com/qemu/qemu/commit/c768eef18c18087d39eaf0e090629dbbca0f51dc
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2020-09-10 (Thu, 10 Sep 2020)

  Changed paths:
    M hw/i386/pc_piix.c

  Log Message:
  -----------
  hw/i386: make explicit clearing of pch_rev_id

Some compilers (notably the Xenial gcc in Travis) fail to spot that
this will always be set if pch_dev_id != 0xffff. Given this is setup
code and using _Pragma to override is equally as ugly lets just remove
the doubt from the compilers mind.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20200909112742.25730-8-alex.bennee@linaro.org>


  Commit: 94b4ec24b9752b0f3bc47c100ebf731b5369b48c
      
https://github.com/qemu/qemu/commit/94b4ec24b9752b0f3bc47c100ebf731b5369b48c
  Author: Pavel Dovgalyuk <Pavel.Dovgaluk@gmail.com>
  Date:   2020-09-10 (Thu, 10 Sep 2020)

  Changed paths:
    M tests/Makefile.include
    M tests/requirements.txt

  Log Message:
  -----------
  tests: bump avocado version

Reverse debugging test uses gdb remote client of avocado framework.
This client was fixed since the currently used version 76.
Therefore this patch bumps the version to 81 and fixes command
line version compatibility issue.

Signed-off-by: Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Tested-by: Cleber Rosa <crosa@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
Reviewed-by: Cleber Rosa <crosa@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <159903462803.28509.16851113546106095750.stgit@pasha-ThinkPad-X280>
Message-Id: <20200908202352.298506-2-philmd@redhat.com>
Message-Id: <20200909112742.25730-9-alex.bennee@linaro.org>


  Commit: 89e076f37d0020bfadb127059083baeb57594f70
      
https://github.com/qemu/qemu/commit/89e076f37d0020bfadb127059083baeb57594f70
  Author: Philippe Mathieu-Daudé <philmd@redhat.com>
  Date:   2020-09-10 (Thu, 10 Sep 2020)

  Changed paths:
    M tests/acceptance/avocado_qemu/__init__.py

  Log Message:
  -----------
  tests/acceptance: Add Test.fetch_asset(cancel_on_missing=True)

Invert the default of avocado.Test.fetch_asset 'cancel_on_missing'
keyword: accept missing artefacts by default. If a test is certain
an artifact can't be missing, it will set cancel_on_missing=False.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20200908202352.298506-3-philmd@redhat.com>
Message-Id: <20200909112742.25730-10-alex.bennee@linaro.org>


  Commit: c17a386b6afe608086aa4d260e29662865680b7f
      
https://github.com/qemu/qemu/commit/c17a386b6afe608086aa4d260e29662865680b7f
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2020-09-10 (Thu, 10 Sep 2020)

  Changed paths:
    M MAINTAINERS
    M Makefile
    M configure
    A contrib/plugins/Makefile
    A contrib/plugins/hotblocks.c
    A contrib/plugins/hotpages.c
    A contrib/plugins/howvec.c
    A contrib/plugins/lockstep.c
    M docs/devel/tcg-plugins.rst
    M tests/Makefile.include
    R tests/plugin/hotblocks.c
    R tests/plugin/hotpages.c
    R tests/plugin/howvec.c
    R tests/plugin/lockstep.c
    M tests/plugin/meson.build
    M tests/tcg/Makefile.target

  Log Message:
  -----------
  plugins: move the more involved plugins to contrib

We have an exploding complexity problem in the testing so lets just
move the more involved plugins into contrib. tests/plugins still exist
for the basic plugins that exercise the API. We restore the old
pre-meson style Makefile for contrib as it also doubles as a guide for
out-of-tree plugin builds.

While we are at it add some examples to the documentation and a
specific plugins build target.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20200909112742.25730-11-alex.bennee@linaro.org>


  Commit: 3d9f371b01067d9cec4d592920013012119397c8
      
https://github.com/qemu/qemu/commit/3d9f371b01067d9cec4d592920013012119397c8
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2020-09-12 (Sat, 12 Sep 2020)

  Changed paths:
    M .travis.yml
    M CODING_STYLE.rst
    M MAINTAINERS
    M Makefile
    M configure
    A contrib/plugins/Makefile
    A contrib/plugins/hotblocks.c
    A contrib/plugins/hotpages.c
    A contrib/plugins/howvec.c
    A contrib/plugins/lockstep.c
    M docs/devel/tcg-plugins.rst
    M docs/system/deprecated.rst
    M hw/i386/pc_piix.c
    M hw/usb/host-libusb.c
    M target/mips/translate.c
    M tests/Makefile.include
    M tests/acceptance/avocado_qemu/__init__.py
    M tests/meson.build
    R tests/plugin/hotblocks.c
    R tests/plugin/hotpages.c
    R tests/plugin/howvec.c
    R tests/plugin/lockstep.c
    M tests/plugin/meson.build
    M tests/requirements.txt
    M tests/tcg/Makefile.target

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/stsquad/tags/pull-testing-fixes-100920-1' into staging

Various misc and testing fixes:

  - Expand CODING_STYLE.rst a little more
  - usb-host build fix
  - allow check-softfloat unit tests without TCG
  - simplify mips imm_branch so compiler isn't confused
  - mark ppc64abi32 for deprecation
  - more compiler soothing in pch_rev_id
  - allow acceptance to skip missing binaries
  - more a bunch of plugins to contrib

# gpg: Signature made Thu 10 Sep 2020 10:51:05 BST
# gpg:                using RSA key 6685AE99E75167BCAFC8DF35FBD0DB095A9E2A44
# gpg: Good signature from "Alex Bennée (Master Work Key) 
<alex.bennee@linaro.org>" [full]
# Primary key fingerprint: 6685 AE99 E751 67BC AFC8  DF35 FBD0 DB09 5A9E 2A44

* remotes/stsquad/tags/pull-testing-fixes-100920-1:
  plugins: move the more involved plugins to contrib
  tests/acceptance: Add Test.fetch_asset(cancel_on_missing=True)
  tests: bump avocado version
  hw/i386: make explicit clearing of pch_rev_id
  configure: don't enable ppc64abi32-linux-user by default
  docs/system/deprecated: mark ppc64abi32-linux-user for deprecation
  target/mips: simplify gen_compute_imm_branch logic
  tests/meson.build: fp tests don't need CONFIG_TCG
  usb-host: restrict workaround to new libusb versions
  CODING_STYLE.rst: flesh out our naming conventions.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/c47edb8dda06...3d9f371b0106