[Qemu-commits] [qemu/qemu] 566054: python/qemu/qmp.py: QMP debug with VM label

[Peter Maydell]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 566054a0bc0cdc6f4ef999f5859a939fc7bf563b
      
https://github.com/qemu/qemu/commit/566054a0bc0cdc6f4ef999f5859a939fc7bf563b
  Author: Oksana Vohchana <address@hidden>
  Date:   2020-03-17 (Tue, 17 Mar 2020)

  Changed paths:
    M python/qemu/machine.py
    M python/qemu/qmp.py

  Log Message:
  -----------
  python/qemu/qmp.py: QMP debug with VM label

QEMUMachine writes some messages to the default logger.
But it sometimes hard to read the output if we have requests to
more than one VM.
This patch adds a label to the logger in the debug mode.

Signed-off-by: Oksana Vohchana <address@hidden>
Reviewed-by: John Snow <address@hidden>
Reviewed-by: Wainer dos Santos Moschetta <address@hidden>
Reviewed-by: Cleber Rosa <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Cleber Rosa <address@hidden>


  Commit: b44513b13d2b0e474aac40206b03e6ee80d14e87
      
https://github.com/qemu/qemu/commit/b44513b13d2b0e474aac40206b03e6ee80d14e87
  Author: Cleber Rosa <address@hidden>
  Date:   2020-03-17 (Tue, 17 Mar 2020)

  Changed paths:
    M tests/acceptance/avocado_qemu/__init__.py

  Log Message:
  -----------
  Acceptance tests: introduce BUILD_DIR and SOURCE_DIR

Some tests may benefit from using resources from a build directory.
This introduces three variables that can help tests find resources in
those directories.

First, a BUILD_DIR is assumed to exist, given that the primary form of
running the acceptance tests is from a build directory (which may or
may not be the same as the source tree, that is, the SOURCE_DIR).

If the directory containing the acceptance tests happens to be a link
to a directory, it's assumed to it points to the source tree
(SOURCE_DIR), which is the behavior defined on the QEMU Makefiles.  If
the directory containing the acceptance tests is not a link, then a
in-tree build is assumed, and the BUILD_DIR and SOURCE_DIR have the
same value.

Signed-off-by: Cleber Rosa <address@hidden>
Reviewed-by: Wainer dos Santos Moschetta <address@hidden>
Tested-by: Wainer dos Santos Moschetta <address@hidden>
Reviewed-by: Willian Rampazzo <address@hidden>
Tested-by: Willian Rampazzo <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Cleber Rosa <address@hidden>


  Commit: 6fd52d671d2200226a4d6af017e0a1462c64cfbc
      
https://github.com/qemu/qemu/commit/6fd52d671d2200226a4d6af017e0a1462c64cfbc
  Author: Cleber Rosa <address@hidden>
  Date:   2020-03-17 (Tue, 17 Mar 2020)

  Changed paths:
    M .travis.yml
    A tests/acceptance/boot_linux.py
    M tests/requirements.txt

  Log Message:
  -----------
  Acceptance test: add "boot_linux" tests

This acceptance test, validates that a full blown Linux guest can
successfully boot in QEMU.  In this specific case, the guest chosen is
Fedora version 31.

 * x86_64, pc-i440fx and pc-q35 machine types, with TCG and KVM as
   accelerators

 * aarch64 and virt machine type, with TCG and KVM as accelerators

 * ppc64 and pseries machine type with TCG as accelerator

 * s390x and s390-ccw-virtio machine type with TCG as accelerator

The Avocado vmimage utils library is used to download and cache the
Linux guest images, and from those images a snapshot image is created
and given to QEMU.  If a qemu-img binary is available in the build
directory, it's used to create the snapshot image, so that matching
qemu-system-* and qemu-img are used in the same test run.  If qemu-img
is not available in the build tree, one is attempted to be found
installed system-wide (in the $PATH).  If qemu-img is not found in the
build dir or in the $PATH, the test is canceled.

The method for checking the successful boot is based on "cloudinit"
and its "phone home" feature.  The guest is given an ISO image with
the location of the phone home server, and the information to post
(the instance ID).  Upon receiving the correct information, from the
guest, the test is considered to have PASSed.

This test is currently limited to user mode networking only, and
instructs the guest to connect to the "router" address that is hard
coded in QEMU.

To create the cloudinit ISO image that will be used to configure the
guest, the pycdlib library is also required and has been added as
requirement to the virtual environment created by "check-venv".

The console output is read by a separate thread, by means of the
Avocado datadrainer utility module.

Signed-off-by: Cleber Rosa <address@hidden>
Reviewed-by: Wainer dos Santos Moschetta <address@hidden>
Reviewed-by: Willian Rampazzo <address@hidden>
Tested-by: Willian Rampazzo <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Cleber Rosa <address@hidden>


  Commit: 4ec49f0fcd6eeaf93885f7c1a4e1ac48362ecf23
      
https://github.com/qemu/qemu/commit/4ec49f0fcd6eeaf93885f7c1a4e1ac48362ecf23
  Author: Cleber Rosa <address@hidden>
  Date:   2020-03-17 (Tue, 17 Mar 2020)

  Changed paths:
    M tests/Makefile.include

  Log Message:
  -----------
  Acceptance tests: add make targets to download images

The newly introduced "boot linux" tests make use of Linux images that
are larger than usual, and fall into what Avocado calls "vmimages",
and can be referred to by name, version and architecture.

The images can be downloaded automatically during the test. But, to
make for more reliable test results, this introduces a target that
will download the vmimages for the architectures that have been
configured and are available for the currently used distro (Fedora
31).

Signed-off-by: Cleber Rosa <address@hidden>
Reviewed-by: Willian Rampazzo <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
[Cleber: implemented suggestions by Alex, download message, check-venv target]
Message-Id: <address@hidden>
Signed-off-by: Cleber Rosa <address@hidden>


  Commit: e631eb2e8b8c19d08c538eb29c01d53edbcc431b
      
https://github.com/qemu/qemu/commit/e631eb2e8b8c19d08c538eb29c01d53edbcc431b
  Author: Cleber Rosa <address@hidden>
  Date:   2020-03-17 (Tue, 17 Mar 2020)

  Changed paths:
    A tests/docker/dockerfiles/centos8.docker

  Log Message:
  -----------
  tests/docker: add CentOS 8 Dockerfile

Which is currenly missing, and will be referenced later in the
contributed CI playbooks.

Signed-off-by: Cleber Rosa <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Cleber Rosa <address@hidden>


  Commit: a51d6a549361fd1a20dd2ac1d6a42ac0a4c708c7
      
https://github.com/qemu/qemu/commit/a51d6a549361fd1a20dd2ac1d6a42ac0a4c708c7
  Author: Cleber Rosa <address@hidden>
  Date:   2020-03-17 (Tue, 17 Mar 2020)

  Changed paths:
    M tests/docker/dockerfiles/debian-win32-cross.docker

  Log Message:
  -----------
  tests/docker: make "buildah bud" output similar to "docker build"

Podman users will most often be using buildah to build containers.
Among the differences between "buildah bud|build-using-dockerfile" and
a traditional "docker build" is that buildah does not run a container
during build.

To the best of my knowledge and experiments, this means that runtime
variables, such as ENV from one base image will not propagate into
another.  The end result is that the location for the cross compiler
binaries, defined in the base "qemu/debian9-mxe" image, are not passed
through this image.  Consequently, the cross compilers are not on PATH
and the build fails.

Signed-off-by: Cleber Rosa <address@hidden>
Acked-by: Alex Bennée <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Cleber Rosa <address@hidden>


  Commit: a1ba62a0f304291c96939cbf7c38e2ab68770326
      
https://github.com/qemu/qemu/commit/a1ba62a0f304291c96939cbf7c38e2ab68770326
  Author: Peter Maydell <address@hidden>
  Date:   2020-03-19 (Thu, 19 Mar 2020)

  Changed paths:
    M .travis.yml
    M python/qemu/machine.py
    M python/qemu/qmp.py
    M tests/Makefile.include
    M tests/acceptance/avocado_qemu/__init__.py
    A tests/acceptance/boot_linux.py
    A tests/docker/dockerfiles/centos8.docker
    M tests/docker/dockerfiles/debian-win32-cross.docker
    M tests/requirements.txt

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/cleber/tags/python-next-pull-request' 
into staging

Python and tests (mostly acceptance) patches 2020-03-17

# gpg: Signature made Wed 18 Mar 2020 00:16:03 GMT
# gpg:                using RSA key 7ABB96EB8B46B94D5E0FE9BB657E8D33A5F209F3
# gpg: Good signature from "Cleber Rosa <address@hidden>" [marginal]
# gpg: WARNING: This key is not certified with sufficiently trusted signatures!
# gpg:          It is not certain that the signature belongs to the owner.
# Primary key fingerprint: 7ABB 96EB 8B46 B94D 5E0F  E9BB 657E 8D33 A5F2 09F3

* remotes/cleber/tags/python-next-pull-request:
  tests/docker: make "buildah bud" output similar to "docker build"
  tests/docker: add CentOS 8 Dockerfile
  Acceptance tests: add make targets to download images
  Acceptance test: add "boot_linux" tests
  Acceptance tests: introduce BUILD_DIR and SOURCE_DIR
  python/qemu/qmp.py: QMP debug with VM label

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/ce73691e2588...a1ba62a0f304