qemu-commits
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] f7e81a: fpu: replace LIT64 usage with UINT64_

From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] f7e81a: fpu: replace LIT64 usage with UINT64_C for special...
Date: Mon, 19 Aug 2019 08:55:10 -0700 
  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: f7e81a945737631c19405a39d510d2284257c3ff
      
https://github.com/qemu/qemu/commit/f7e81a945737631c19405a39d510d2284257c3ff
  Author: Alex Bennée <address@hidden>
  Date:   2019-08-19 (Mon, 19 Aug 2019)

  Changed paths:
    M fpu/softfloat-specialize.h

  Log Message:
  -----------
  fpu: replace LIT64 usage with UINT64_C for specialize constants

We have a wrapper that does the right thing from stdint.h so lets use
it for our constants in softfloat-specialize.h

Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>


  Commit: e6b405fe00d8e6424a58492b37a1656d1ef0929b
      
https://github.com/qemu/qemu/commit/e6b405fe00d8e6424a58492b37a1656d1ef0929b
  Author: Alex Bennée <address@hidden>
  Date:   2019-08-19 (Mon, 19 Aug 2019)

  Changed paths:
    M fpu/softfloat.c

  Log Message:
  -----------
  fpu: convert float[16/32/64]_squash_denormal to new modern style

This also allows us to remove the extractFloat16exp/frac helpers. We
avoid using the floatXX_pack_raw functions as they are slight overkill
for masking out all but the top bit of the number. The generated code
is almost exactly the same as makes no difference to the
pre-conversion code.

Signed-off-by: Alex Bennée <address@hidden>


  Commit: 2c217da0fc9f1127bda804e2a500b8138b02c581
      
https://github.com/qemu/qemu/commit/2c217da0fc9f1127bda804e2a500b8138b02c581
  Author: Alex Bennée <address@hidden>
  Date:   2019-08-19 (Mon, 19 Aug 2019)

  Changed paths:
    M fpu/softfloat.c

  Log Message:
  -----------
  fpu: use min/max values from stdint.h for integral overflow

Remove some more use of LIT64 while making the meaning more clear. We
also avoid the need of casts as the results by definition fit into the
return type.

Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>


  Commit: e932112420f063776f2b9d9e5512830cd6890a7a
      
https://github.com/qemu/qemu/commit/e932112420f063776f2b9d9e5512830cd6890a7a
  Author: Alex Bennée <address@hidden>
  Date:   2019-08-19 (Mon, 19 Aug 2019)

  Changed paths:
    M fpu/softfloat.c
    M include/fpu/softfloat-macros.h

  Log Message:
  -----------
  fpu: replace LIT64 with UINT64_C macros

In our quest to eliminate the home rolled LIT64 macro we fixup usage
inside the softfloat code. While we are at it we remove some of the
extraneous spaces to closer fit the house style.

Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>


  Commit: e23263004d5fea809ad0f78c523f498e04ba788f
      
https://github.com/qemu/qemu/commit/e23263004d5fea809ad0f78c523f498e04ba788f
  Author: Alex Bennée <address@hidden>
  Date:   2019-08-19 (Mon, 19 Aug 2019)

  Changed paths:
    M target/m68k/softfloat.c

  Log Message:
  -----------
  target/m68k: replace LIT64 with UINT64_C macros

In our quest to eliminate the home rolled LIT64 macro we fixup usage
inside for m68k's many constants.

Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>


  Commit: 472038ccf5d69ebcad44d835488a36ee640c219f
      
https://github.com/qemu/qemu/commit/472038ccf5d69ebcad44d835488a36ee640c219f
  Author: Alex Bennée <address@hidden>
  Date:   2019-08-19 (Mon, 19 Aug 2019)

  Changed paths:
    M include/fpu/softfloat.h

  Log Message:
  -----------
  fpu: remove the LIT64 macro

Now the rest of the code has been cleaned up we can remove this.

Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>


  Commit: e34c47ea3fb5f324b58db117b3c010a494c8d6ca
      
https://github.com/qemu/qemu/commit/e34c47ea3fb5f324b58db117b3c010a494c8d6ca
  Author: Alex Bennée <address@hidden>
  Date:   2019-08-19 (Mon, 19 Aug 2019)

  Changed paths:
    A include/fpu/softfloat-helpers.h
    M include/fpu/softfloat.h

  Log Message:
  -----------
  fpu: move inline helpers into a separate header

There are a bunch of users of the inline helpers who do not need
access to the entire softfloat API. Move those inline helpers into a
new header file which can be included without bringing in the rest of
the world.

Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>


  Commit: 5937fb63a92d54cc4e5270256e4387c4d3a70091
      
https://github.com/qemu/qemu/commit/5937fb63a92d54cc4e5270256e4387c4d3a70091
  Author: Alex Bennée <address@hidden>
  Date:   2019-08-19 (Mon, 19 Aug 2019)

  Changed paths:
    M include/fpu/softfloat-macros.h

  Log Message:
  -----------
  fpu: make softfloat-macros "self-contained"

The macros use the "flags" type and to be consistent if anyone just
needs the macros we should bring in the header we need. There is an
outstanding TODO to audit the use of "flags" and replace with bool at
which point this include could be dropped.

Signed-off-by: Alex Bennée <address@hidden>
Acked-by: Richard Henderson <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>


  Commit: 00f43279a3e5e7ea3a0fa853157863663e838e2e
      
https://github.com/qemu/qemu/commit/00f43279a3e5e7ea3a0fa853157863663e838e2e
  Author: Alex Bennée <address@hidden>
  Date:   2019-08-19 (Mon, 19 Aug 2019)

  Changed paths:
    R fpu/softfloat-specialize.h
    A fpu/softfloat-specialize.inc.c
    M fpu/softfloat.c

  Log Message:
  -----------
  fpu: rename softfloat-specialize.h -> .inc.c

This is not a normal header and should only be included in the main
softfloat.c file to bring in the various target specific
specialisations. Indeed as it contains non-inlined C functions it is
not even a legal header. Rename it to match our included C convention.

Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>


  Commit: 502700d0674919309a19bfd016ea0680c6b7747d
      
https://github.com/qemu/qemu/commit/502700d0674919309a19bfd016ea0680c6b7747d
  Author: Alex Bennée <address@hidden>
  Date:   2019-08-19 (Mon, 19 Aug 2019)

  Changed paths:
    M linux-user/mips/cpu_loop.c
    M target/mips/cpu.h
    M target/mips/internal.h
    M target/mips/msa_helper.c
    M target/mips/op_helper.c

  Log Message:
  -----------
  target/mips: rationalise softfloat includes

We should avoid including the whole of softfloat headers in cpu.h and
explicitly include it only where we will be calling softfloat
functions. We can use the -types.h in cpu.h for the few bits that are
global. We also move the restore_snan_bit_mode into internal.h and
include -helpers.h there.

Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Aleksandar Markovic <address@hidden>


  Commit: 135b03cb9defbd080b8834b30e3d45bed00c6137
      
https://github.com/qemu/qemu/commit/135b03cb9defbd080b8834b30e3d45bed00c6137
  Author: Alex Bennée <address@hidden>
  Date:   2019-08-19 (Mon, 19 Aug 2019)

  Changed paths:
    M target/riscv/cpu.c
    M target/riscv/cpu.h
    M target/riscv/fpu_helper.c

  Log Message:
  -----------
  target/riscv: rationalise softfloat includes

We should avoid including the whole of softfloat headers in cpu.h and
explicitly include it only where we will be calling softfloat
functions. We can use the -types.h and -helpers.h in cpu.h for the few
bits that are global.

Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Reviewed-by: Alistair Francis <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Acked-by: Palmer Dabbelt <address@hidden>


  Commit: 5f8ab0004e878a6cd0f50fa8659df4a4f853eea8
      
https://github.com/qemu/qemu/commit/5f8ab0004e878a6cd0f50fa8659df4a4f853eea8
  Author: Alex Bennée <address@hidden>
  Date:   2019-08-19 (Mon, 19 Aug 2019)

  Changed paths:
    M target/alpha/helper.c
    M target/microblaze/cpu.c
    M target/s390x/cpu.c
    M target/sh4/cpu.c
    M target/tricore/helper.c
    M target/unicore32/cpu.c

  Log Message:
  -----------
  targets (various): use softfloat-helpers.h where we can

Generally the cpu and non-FP helper files just want to manipulate the
softfloat flags. For this they can just use the -helpers.h include
which brings in a minimal number of inline helpers.

Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Reviewed-by: David Hildenbrand <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>


  Commit: 50d69ee0d82378c7c21f482492dacfe0916b4863
      
https://github.com/qemu/qemu/commit/50d69ee0d82378c7c21f482492dacfe0916b4863
  Author: Peter Maydell <address@hidden>
  Date:   2019-08-19 (Mon, 19 Aug 2019)

  Changed paths:
    R fpu/softfloat-specialize.h
    A fpu/softfloat-specialize.inc.c
    M fpu/softfloat.c
    A include/fpu/softfloat-helpers.h
    M include/fpu/softfloat-macros.h
    M include/fpu/softfloat.h
    M linux-user/mips/cpu_loop.c
    M target/alpha/helper.c
    M target/m68k/softfloat.c
    M target/microblaze/cpu.c
    M target/mips/cpu.h
    M target/mips/internal.h
    M target/mips/msa_helper.c
    M target/mips/op_helper.c
    M target/riscv/cpu.c
    M target/riscv/cpu.h
    M target/riscv/fpu_helper.c
    M target/s390x/cpu.c
    M target/sh4/cpu.c
    M target/tricore/helper.c
    M target/unicore32/cpu.c

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/stsquad/tags/pull-softfloat-headers-190819-1' into staging

Softfloat updates

  - minor refactoring of constants
  - drop LIT64 macro
  - re-organise header inclusion

# gpg: Signature made Mon 19 Aug 2019 12:08:37 BST
# gpg:                using RSA key 6685AE99E75167BCAFC8DF35FBD0DB095A9E2A44
# gpg: Good signature from "Alex Bennée (Master Work Key) <address@hidden>" 
[full]
# Primary key fingerprint: 6685 AE99 E751 67BC AFC8  DF35 FBD0 DB09 5A9E 2A44

* remotes/stsquad/tags/pull-softfloat-headers-190819-1:
  targets (various): use softfloat-helpers.h where we can
  target/riscv: rationalise softfloat includes
  target/mips: rationalise softfloat includes
  fpu: rename softfloat-specialize.h -> .inc.c
  fpu: make softfloat-macros "self-contained"
  fpu: move inline helpers into a separate header
  fpu: remove the LIT64 macro
  target/m68k: replace LIT64 with UINT64_C macros
  fpu: replace LIT64 with UINT64_C macros
  fpu: use min/max values from stdint.h for integral overflow
  fpu: convert float[16/32/64]_squash_denormal to new modern style
  fpu: replace LIT64 usage with UINT64_C for specialize constants

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/3fbd3405d2b0...50d69ee0d823
reply via email to
[Prev in Thread] Current Thread [Next in Thread]