[Qemu-commits] [qemu/qemu] f6fc1e: block: fix NetBSD qemu-iotests failure

[Peter Maydell]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: f6fc1e30cf5e30289c70f1b1ca7f26c56f85d32f
      
https://github.com/qemu/qemu/commit/f6fc1e30cf5e30289c70f1b1ca7f26c56f85d32f
  Author: Paolo Bonzini <address@hidden>
  Date:   2019-08-17 (Sat, 17 Aug 2019)

  Changed paths:
    M block/file-posix.c

  Log Message:
  -----------
  block: fix NetBSD qemu-iotests failure

Opening a block device on NetBSD has an additional step compared to other OSes,
corresponding to raw_normalize_devicepath.  The error message in that function
is slightly different from that in raw_open_common and this was causing spurious
failures in qemu-iotests.  However, in general it is not important to know what
exact step was failing, for example in the qemu-iotests case the error message
contains the fairly unequivocal "No such file or directory" text from strerror.
We can thus fix the failures by standardizing on a single error message for
both raw_open_common and raw_normalize_devicepath; in fact, we can even
use error_setg_file_open to make sure the error message is the same as in
the rest of QEMU.

Message-Id: <address@hidden>
Tested-by: Thomas Huth <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: bdd95e47844f2d8b1050fb82fc2114fc19613beb
      
https://github.com/qemu/qemu/commit/bdd95e47844f2d8b1050fb82fc2114fc19613beb
  Author: Thomas Huth <address@hidden>
  Date:   2019-08-17 (Sat, 17 Aug 2019)

  Changed paths:
    M tests/Makefile.include
    M tests/check-block.sh
    R tests/qemu-iotests-quick.sh

  Log Message:
  -----------
  tests: Run the iotests during "make check" again

People often forget to run the iotests before submitting patches or pull
requests - this is likely due to the fact that we do not run the tests
during our mandatory "make check" tests yet. Now that we've got a proper
"auto" group of iotests that should be fine to run in every environment,
we can enable the iotests during "make check" again by running the "auto"
tests by default from the check-block.sh script.

Some cases still need to be checked first, though: iotests need bash and
GNU sed (otherwise they fail), and if gprof is enabled, it spoils the
output of some test cases causing them to fail. So if we detect that one
of the required programs is missing or that gprof is enabled, we still
have to skip the iotests to avoid failures.

And finally, since we are using check-block.sh now again, this patch also
removes the qemu-iotests-quick.sh script since we do not need that anymore
(and having two shell wrapper scripts around the block tests seems rather
confusing than helpful).

Message-Id: <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>
[AJB: -makecheck to check-block.sh, move check-block to start and gate it]
Signed-off-by: Alex Bennée <address@hidden>


  Commit: 72e031f3b80a421b309ce0d1759b26e428f944db
      
https://github.com/qemu/qemu/commit/72e031f3b80a421b309ce0d1759b26e428f944db
  Author: Thomas Huth <address@hidden>
  Date:   2019-08-17 (Sat, 17 Aug 2019)

  Changed paths:
    M .gitlab-ci.yml

  Log Message:
  -----------
  gitlab-ci: Remove qcow2 tests that are handled by "make check" already

Since most iotests are now run during "make check" already, we do not
need to test them explicitly from the gitlab-ci.yml script anymore.
And while we're at it, add some of the new non-auto tests >= 246 instead.

Message-Id: <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: 3fbd3405d2b0604ea530fc7a1828f19da1e95ff9
      
https://github.com/qemu/qemu/commit/3fbd3405d2b0604ea530fc7a1828f19da1e95ff9
  Author: Peter Maydell <address@hidden>
  Date:   2019-08-19 (Mon, 19 Aug 2019)

  Changed paths:
    M .gitlab-ci.yml
    M block/file-posix.c
    M tests/Makefile.include
    M tests/check-block.sh
    R tests/qemu-iotests-quick.sh

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/huth-gitlab/tags/pull-request-2019-08-17' into staging

- Run the iotest during "make check"

# gpg: Signature made Sat 17 Aug 2019 09:46:13 BST
# gpg:                using RSA key 27B88847EEE0250118F3EAB92ED9D774FE702DB5
# gpg:                issuer "address@hidden"
# gpg: Good signature from "Thomas Huth <address@hidden>" [full]
# gpg:                 aka "Thomas Huth <address@hidden>" [full]
# gpg:                 aka "Thomas Huth <address@hidden>" [full]
# gpg:                 aka "Thomas Huth <address@hidden>" [unknown]
# Primary key fingerprint: 27B8 8847 EEE0 2501 18F3  EAB9 2ED9 D774 FE70 2DB5

* remotes/huth-gitlab/tags/pull-request-2019-08-17:
  gitlab-ci: Remove qcow2 tests that are handled by "make check" already
  tests: Run the iotests during "make check" again
  block: fix NetBSD qemu-iotests failure

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/9f3a972e2256...3fbd3405d2b0