qemu-commits
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 18e845: vnc: fix unalignment access in tight_

From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] 18e845: vnc: fix unalignment access in tight_pack24
Date: Mon, 18 Mar 2019 05:00:03 -0700 
  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 18e845f7dfe089bc0c6a89c10c496054d30a681e
      
https://github.com/qemu/qemu/commit/18e845f7dfe089bc0c6a89c10c496054d30a681e
  Author: Li Qiang <address@hidden>
  Date:   2019-03-18 (Mon, 18 Mar 2019)

  Changed paths:
    M ui/vnc-enc-tight.c

  Log Message:
  -----------
  vnc: fix unalignment access in tight_pack24

When adding '-fsanitize=undefined' in compiling configuration
and connect VM with vnc, it reports following error:

ui/vnc-enc-tight.c:910:13: runtime error: load of
misaligned address 0x621000466513 for type 'uint32_t',
which requires 4 byte alignment

This patch fix this issue.

Signed-off-by: Li Qiang <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: a5489ae5bbd270f2a72b2179a9adf4089e3fb7b8
      
https://github.com/qemu/qemu/commit/a5489ae5bbd270f2a72b2179a9adf4089e3fb7b8
  Author: Samuel Thibault <address@hidden>
  Date:   2019-03-18 (Mon, 18 Mar 2019)

  Changed paths:
    M ui/curses.c

  Log Message:
  -----------
  curses ui: always initialize all curses_line fields

cchar_t can contain not only attr and chars fields, but also ext_color.
Initialize the whole structure to zero instead of enumerating fields.

Spotted by Coverity: CID 1399711

Signed-off-by: Samuel Thibault <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: a9fda24747321ab8bbd9f91d2ee6f2716c6d8d6b
      
https://github.com/qemu/qemu/commit/a9fda24747321ab8bbd9f91d2ee6f2716c6d8d6b
  Author: Samuel Thibault <address@hidden>
  Date:   2019-03-18 (Mon, 18 Mar 2019)

  Changed paths:
    M ui/curses.c

  Log Message:
  -----------
  curses ui: add missing iconv_close calls

The iconv_t are opened but never closed.

Spotted by Coverity: CID 1399708
Spotted by Coverity: CID 1399709
Spotted by Coverity: CID 1399713

Signed-off-by: Samuel Thibault <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 50963118a10773b9e17c25274f78563ca1fd7b1d
      
https://github.com/qemu/qemu/commit/50963118a10773b9e17c25274f78563ca1fd7b1d
  Author: Gerd Hoffmann <address@hidden>
  Date:   2019-03-18 (Mon, 18 Mar 2019)

  Changed paths:
    M pc-bios/keymaps/Makefile

  Log Message:
  -----------
  keymaps: use nodeadkeys variant for de and fr

The reverse keymap code can't handle dead keys.  So use the nodeadkeys
variant of the keyboard layout for the german and french maps.

Signed-off-by: Gerd Hoffmann <address@hidden>
Message-id: address@hidden


  Commit: 0a87602268884f977ba67df8b51735bf5ac141ec
      
https://github.com/qemu/qemu/commit/0a87602268884f977ba67df8b51735bf5ac141ec
  Author: Gerd Hoffmann <address@hidden>
  Date:   2019-03-18 (Mon, 18 Mar 2019)

  Changed paths:
    M pc-bios/keymaps/ar
    M pc-bios/keymaps/bepo
    M pc-bios/keymaps/cz
    M pc-bios/keymaps/da
    M pc-bios/keymaps/de
    M pc-bios/keymaps/de-ch
    M pc-bios/keymaps/en-gb
    M pc-bios/keymaps/en-us
    M pc-bios/keymaps/es
    M pc-bios/keymaps/et
    M pc-bios/keymaps/fi
    M pc-bios/keymaps/fo
    M pc-bios/keymaps/fr
    M pc-bios/keymaps/fr-be
    M pc-bios/keymaps/fr-ca
    M pc-bios/keymaps/fr-ch
    M pc-bios/keymaps/hr
    M pc-bios/keymaps/hu
    M pc-bios/keymaps/is
    M pc-bios/keymaps/it
    M pc-bios/keymaps/ja
    M pc-bios/keymaps/lt
    M pc-bios/keymaps/lv
    M pc-bios/keymaps/mk
    M pc-bios/keymaps/nl
    M pc-bios/keymaps/no
    M pc-bios/keymaps/pl
    M pc-bios/keymaps/pt
    M pc-bios/keymaps/pt-br
    M pc-bios/keymaps/ru
    M pc-bios/keymaps/th
    M pc-bios/keymaps/tr

  Log Message:
  -----------
  keymaps: regenerate keymaps

Pick up the config updates.  Also add a few keys to the maps which
got a QKeyCode assigned since the last time we generated the maps
(Hiragana_Katakana, Muhenkan).  Sync with xkbcommon updates.

Signed-off-by: Gerd Hoffmann <address@hidden>
Message-id: address@hidden


  Commit: 185521102b67c0dc91cb95c2e3e8fce36b963893
      
https://github.com/qemu/qemu/commit/185521102b67c0dc91cb95c2e3e8fce36b963893
  Author: Peter Maydell <address@hidden>
  Date:   2019-03-18 (Mon, 18 Mar 2019)

  Changed paths:
    M pc-bios/keymaps/Makefile
    M pc-bios/keymaps/ar
    M pc-bios/keymaps/bepo
    M pc-bios/keymaps/cz
    M pc-bios/keymaps/da
    M pc-bios/keymaps/de
    M pc-bios/keymaps/de-ch
    M pc-bios/keymaps/en-gb
    M pc-bios/keymaps/en-us
    M pc-bios/keymaps/es
    M pc-bios/keymaps/et
    M pc-bios/keymaps/fi
    M pc-bios/keymaps/fo
    M pc-bios/keymaps/fr
    M pc-bios/keymaps/fr-be
    M pc-bios/keymaps/fr-ca
    M pc-bios/keymaps/fr-ch
    M pc-bios/keymaps/hr
    M pc-bios/keymaps/hu
    M pc-bios/keymaps/is
    M pc-bios/keymaps/it
    M pc-bios/keymaps/ja
    M pc-bios/keymaps/lt
    M pc-bios/keymaps/lv
    M pc-bios/keymaps/mk
    M pc-bios/keymaps/nl
    M pc-bios/keymaps/no
    M pc-bios/keymaps/pl
    M pc-bios/keymaps/pt
    M pc-bios/keymaps/pt-br
    M pc-bios/keymaps/ru
    M pc-bios/keymaps/th
    M pc-bios/keymaps/tr
    M ui/curses.c
    M ui/vnc-enc-tight.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/kraxel/tags/ui-20190318-pull-request' 
into staging

ui: fixes for 4.0 (vnc, curses, keymaps).

# gpg: Signature made Mon 18 Mar 2019 11:20:19 GMT
# gpg:                using RSA key 4CB6D8EED3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <address@hidden>" [full]
# gpg:                 aka "Gerd Hoffmann <address@hidden>" [full]
# gpg:                 aka "Gerd Hoffmann (private) <address@hidden>" [full]
# Primary key fingerprint: A032 8CFF B93A 17A7 9901  FE7D 4CB6 D8EE D3E8 7138

* remotes/kraxel/tags/ui-20190318-pull-request:
  keymaps: regenerate keymaps
  keymaps: use nodeadkeys variant for de and fr
  curses ui: add missing iconv_close calls
  curses ui: always initialize all curses_line fields
  vnc: fix unalignment access in tight_pack24

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/1d023a5296dc...185521102b67
reply via email to
[Prev in Thread] Current Thread [Next in Thread]