[Qemu-commits] [qemu/qemu] baea03: audio/paaudio: fix ignored buffer_length setting

[Peter Maydell]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: baea032ec751306805214190b1ac23f409e9739a
      
https://github.com/qemu/qemu/commit/baea032ec751306805214190b1ac23f409e9739a
  Author: Martin Schrodt <address@hidden>
  Date:   2019-03-18 (Mon, 18 Mar 2019)

  Changed paths:
    M audio/paaudio.c

  Log Message:
  -----------
  audio/paaudio: fix ignored buffer_length setting

Audiodev configuration allows to set the length of the buffered data.
The setting was ignored and a constant value used instead.
This patch makes the code apply the setting properly, and uses the
previous default if nothing is supplied.

Signed-off-by: Martin Schrodt <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: f6142777659f2e7ad143f2850f1f036f899f475f
      
https://github.com/qemu/qemu/commit/f6142777659f2e7ad143f2850f1f036f899f475f
  Author: Martin Schrodt <address@hidden>
  Date:   2019-03-18 (Mon, 18 Mar 2019)

  Changed paths:
    M audio/paaudio.c
    M qapi/audio.json

  Log Message:
  -----------
  audio/paaudio: prolong and make latency configurable

The latency of a connection to the PulseAudio server is determined by
the tlength parameter. This was hardcoded to 10ms, which is a bit too
tight on my machine, causing audio on host and guest to malfunction.
A setting of 15ms works fine here. To allow tweaking, I also made the
setting configurable via the new -audiodev config. This allows to squeeze out 
better timings in scenarios where the emulation allows it.

I also removed setting of the minreq parameter to (seemingly arbitrary) half 
the latency, since it showed worse audio quality during my tests. Allowing 
PulseAudio to request smaller chunks helped.

Signed-off-by: Martin Schrodt <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: ade103011c6476353fbc2a707aa6ef1f1aa9e2fb
      
https://github.com/qemu/qemu/commit/ade103011c6476353fbc2a707aa6ef1f1aa9e2fb
  Author: Martin Schrodt <address@hidden>
  Date:   2019-03-18 (Mon, 18 Mar 2019)

  Changed paths:
    M audio/paaudio.c

  Log Message:
  -----------
  audio/paaudio: fix microphone input being unusable

The current code does not specify the metrics of the buffers for the
input device. This makes PulseAudio choose very bad defaults, which
causes input to be unusable: Audio put in gets out 30 seconds later.
This patch fixes that and makes the latency configurable as well.

Signed-off-by: Martin Schrodt <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: a9d1cc9f56f889b2a7968ba9177799525e234006
      
https://github.com/qemu/qemu/commit/a9d1cc9f56f889b2a7968ba9177799525e234006
  Author: Peter Maydell <address@hidden>
  Date:   2019-03-18 (Mon, 18 Mar 2019)

  Changed paths:
    M audio/paaudio.c
    M qapi/audio.json

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/kraxel/tags/audio-20190318-pull-request' into staging

audio: pulseaudio fixes for 4.0

# gpg: Signature made Mon 18 Mar 2019 12:08:50 GMT
# gpg:                using RSA key 4CB6D8EED3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <address@hidden>" [full]
# gpg:                 aka "Gerd Hoffmann <address@hidden>" [full]
# gpg:                 aka "Gerd Hoffmann (private) <address@hidden>" [full]
# Primary key fingerprint: A032 8CFF B93A 17A7 9901  FE7D 4CB6 D8EE D3E8 7138

* remotes/kraxel/tags/audio-20190318-pull-request:
  audio/paaudio: fix microphone input being unusable
  audio/paaudio: prolong and make latency configurable
  audio/paaudio: fix ignored buffer_length setting

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/185521102b67...a9d1cc9f56f8