[Qemu-commits] [qemu/qemu] 2b1f35: Revert "Makefile: Rename TARGET

qemu-commits
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] 2b1f35: Revert "Makefile: Rename TARGET_DIRS

From:	GitHub
Subject:	[Qemu-commits] [qemu/qemu] 2b1f35: Revert "Makefile: Rename TARGET_DIRS to TARGET_LIS...
Date:	Thu, 05 Jul 2018 11:10:33 -0700
  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 2b1f35b9a85cf0232615a67e7ff523137a58795e
      
https://github.com/qemu/qemu/commit/2b1f35b9a85cf0232615a67e7ff523137a58795e
  Author: Alex Bennée <address@hidden>
  Date:   2018-07-05 (Thu, 05 Jul 2018)

  Changed paths:
    M Makefile
    M configure
    M scripts/create_config
    M tests/Makefile.include

  Log Message:
  -----------
  Revert "Makefile: Rename TARGET_DIRS to TARGET_LIST"

This reverts commit 208ecb3e1acc8d55dab49fdf721a86d513691688. This was
causing problems by making DEF_TARGET_LIST pointless and having to
jump through hoops to build on mingw with a dully enabled config.
This includes a change to fix the per-guest TCG test probe which was
added after 208ecb3 and used TARGET_LIST.

Signed-off-by: Alex Bennée <address@hidden>
Cc: Paolo Bonzini <address@hidden>


  Commit: ebdfb6101dac71b1db2e9cd66111e865cc1f22e8
      
https://github.com/qemu/qemu/commit/ebdfb6101dac71b1db2e9cd66111e865cc1f22e8
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2018-07-05 (Thu, 05 Jul 2018)

  Changed paths:
    M .travis.yml

  Log Message:
  -----------
  travis: do not waste time cloning unused submodules

Builds only require:
- dtc
- keycodemapdb
- capstone

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
[AJB: drop wget cache]
Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Daniel P. Berrangé <address@hidden>


  Commit: ebf2ff659baac238b5d7522b75453da3f4901935
      
https://github.com/qemu/qemu/commit/ebf2ff659baac238b5d7522b75453da3f4901935
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2018-07-05 (Thu, 05 Jul 2018)

  Changed paths:
    M .travis.yml

  Log Message:
  -----------
  travis: test out-of-tree builds

Force one config to build 'out-of-tree' (object files and executables
are created in a tree outside the project source code).

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Daniel P. Berrangé <address@hidden>


  Commit: 31d2dda3c4091c6d823c5103a982b4c08a2f4b1d
      
https://github.com/qemu/qemu/commit/31d2dda3c4091c6d823c5103a982b4c08a2f4b1d
  Author: Alex Bennée <address@hidden>
  Date:   2018-07-05 (Thu, 05 Jul 2018)

  Changed paths:
    M docs/devel/testing.rst
    M tests/Makefile.include

  Log Message:
  -----------
  build-system: remove per-test GCOV reporting

I'm not entirely sure who's using this information and certainly in a
CI environment it just washes over as additional noise. Later patches
will provide new reporting options so a user who wants to analyse
individual tests will be able to use that to get the information.

Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Daniel P. Berrangé <address@hidden>


  Commit: 6786dc3442f2f691d208d15218576136727d0890
      
https://github.com/qemu/qemu/commit/6786dc3442f2f691d208d15218576136727d0890
  Author: Alex Bennée <address@hidden>
  Date:   2018-07-05 (Thu, 05 Jul 2018)

  Changed paths:
    M .gitignore

  Log Message:
  -----------
  .gitignore: add .gcov files

These are temporary files generated on gcov runs and shouldn't be
included in the source tree.

Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Daniel P. Berrangé <address@hidden>


  Commit: 95f7aabf49a1223f23b0b1f66201ce22ff3695ac
      
https://github.com/qemu/qemu/commit/95f7aabf49a1223f23b0b1f66201ce22ff3695ac
  Author: Alex Bennée <address@hidden>
  Date:   2018-07-05 (Thu, 05 Jul 2018)

  Changed paths:
    M tests/docker/dockerfiles/travis.docker

  Log Message:
  -----------
  docker: add gcovr to travis image

Useful for debugging if nothing else as the gcovr on the Travis images
are a little old.

Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Daniel P. Berrangé <address@hidden>


  Commit: 0708e6476fad27c4d98c5c302a7d7ca475a41369
      
https://github.com/qemu/qemu/commit/0708e6476fad27c4d98c5c302a7d7ca475a41369
  Author: Alex Bennée <address@hidden>
  Date:   2018-07-05 (Thu, 05 Jul 2018)

  Changed paths:
    M .travis.yml
    M MAINTAINERS
    A scripts/travis/coverage-summary.sh

  Log Message:
  -----------
  travis: add gcovr summary for GCOV build

This gives a more useful summary, sorted by descending % coverage,
after the tests have run. The final numbers will give an idea if our
coverage is getting better or worse.

To keep the width sane we need to post process the file that the old
gcovr tool generates. This is done with a mix of sed, awk and column
in the scripts/coverage-summary.sh script.

As quite a lot of lines don't get covered at all we filter out all the
0% lines. If the file doesn't appear it is not being exercised.

Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Daniel P. Berrangé <address@hidden>


  Commit: 990e6a2754fc16501470b661c4af94ec036f1190
      
https://github.com/qemu/qemu/commit/990e6a2754fc16501470b661c4af94ec036f1190
  Author: Alex Bennée <address@hidden>
  Date:   2018-07-05 (Thu, 05 Jul 2018)

  Changed paths:
    M Makefile
    M docs/devel/testing.rst

  Log Message:
  -----------
  build-system: add clean-coverage target

This can be used to remove any stale coverage data before any
particular test run. This is useful for analysing individual tests.

Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Daniel P. Berrangé <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>---


  Commit: fe8bf5f62972ce9f227ae3e25767116a6d221b6d
      
https://github.com/qemu/qemu/commit/fe8bf5f62972ce9f227ae3e25767116a6d221b6d
  Author: Alex Bennée <address@hidden>
  Date:   2018-07-05 (Thu, 05 Jul 2018)

  Changed paths:
    M Makefile
    M docs/devel/testing.rst

  Log Message:
  -----------
  build-system: add coverage-report target

This will build a coverage report under the current directory in
reports/coverage. At the users option a report can be generated by
directly invoking something like:

  make foo/bar/coverage-report.html

Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Daniel P. Berrangé <address@hidden>


  Commit: 708b6a643c7a974ffadf64e00019bdcd60edf6e5
      
https://github.com/qemu/qemu/commit/708b6a643c7a974ffadf64e00019bdcd60edf6e5
  Author: Alex Bennée <address@hidden>
  Date:   2018-07-05 (Thu, 05 Jul 2018)

  Changed paths:
    M linux-user/Makefile.objs
    A linux-user/exit.c
    M linux-user/qemu.h
    M linux-user/syscall.c

  Log Message:
  -----------
  linux-user: introduce preexit_cleanup

To avoid repeating ourselves move our preexit clean-up code into a
helper function. I figured the continuing effort to split of the
syscalls made it worthwhile creating a new file for it now.

Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Daniel P. Berrangé <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>


  Commit: 7781afb49cdcc41b5cd06d4daa53aa1bc45f95ac
      
https://github.com/qemu/qemu/commit/7781afb49cdcc41b5cd06d4daa53aa1bc45f95ac
  Author: Alex Bennée <address@hidden>
  Date:   2018-07-05 (Thu, 05 Jul 2018)

  Changed paths:
    M linux-user/exit.c

  Log Message:
  -----------
  linux-user: add gcov support to preexit_cleanup

As we don't always take the normal exit path when running a guest we
can skip the normal exit destructors where gcov normally dumps it's
info. The GCC manual suggests long running programs use __gcov_dump()
to flush out the coverage state periodically so we use that here.

Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>


  Commit: beac6a98f6eb271f2520a329ca051313afd70a69
      
https://github.com/qemu/qemu/commit/beac6a98f6eb271f2520a329ca051313afd70a69
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2018-07-05 (Thu, 05 Jul 2018)

  Changed paths:
    M tests/docker/dockerfiles/ubuntu.docker

  Log Message:
  -----------
  docker: ubuntu: Update the package list before installing new ones

Since docker caches the different layers, updating the package
list does not invalidate the previous "apt-get update" layer,
and it is likely "apt-get install" hits an outdated repository.

See 
https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#apt-get

This fixes:

  $ make docker-image-ubuntu V=1
  ./tests/docker/docker.py build qemu:ubuntu 
tests/docker/dockerfiles/ubuntu.docker   --add-current-user
  Sending build context to Docker daemon  3.072kB
  [...]
  E: Failed to fetch 
http://archive.ubuntu.com/ubuntu/pool/main/m/mesa/libgles2-mesa_17.0.7-0ubuntu0.16.04.2_amd64.deb
  404  Not Found
  E: Failed to fetch 
http://archive.ubuntu.com/ubuntu/pool/main/m/mesa/libgles2-mesa-dev_17.0.7-0ubuntu0.16.04.2_amd64.deb
  404  Not Found
  E: Unable to fetch some archives, maybe run apt-get update or try with 
--fix-missing?
  The command '/bin/sh -c apt-get -y install $PACKAGES' returned a non-zero 
code: 100
  tests/docker/Makefile.include:40: recipe for target 'docker-image-ubuntu' 
failed
  make: *** [docker-image-ubuntu] Error 1

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>


  Commit: daf999f77acfbe3ae09b5b8b58c140d9fdf38409
      
https://github.com/qemu/qemu/commit/daf999f77acfbe3ae09b5b8b58c140d9fdf38409
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2018-07-05 (Thu, 05 Jul 2018)

  Changed paths:
    M tests/docker/dockerfiles/ubuntu.docker

  Log Message:
  -----------
  docker: ubuntu: Use SDL2

Do not test the deprecated API versions (see cabd35840749d).
Debian MXE MinGW cross images are already using SDL2.

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>


  Commit: 48feb682db13372c5cce42156a48afabfbbb28e9
      
https://github.com/qemu/qemu/commit/48feb682db13372c5cce42156a48afabfbbb28e9
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2018-07-05 (Thu, 05 Jul 2018)

  Changed paths:
    M tests/docker/dockerfiles/debian8-mxe.docker

  Log Message:
  -----------
  docker: Clean the MXE base image

Using the duplicated same package is confusing.

Reported-by: Peter Maydell <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>


  Commit: 272e551b43e9a1c88cef774b24c97bcea887c291
      
https://github.com/qemu/qemu/commit/272e551b43e9a1c88cef774b24c97bcea887c291
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2018-07-05 (Thu, 05 Jul 2018)

  Changed paths:
    M tests/docker/Makefile.include

  Log Message:
  -----------
  docker: Do not run tests in 'intermediate' images

We can still build the DOCKER_INTERMEDIATE_IMAGES images,
but they won't appear in 'make address@hidden'.

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>


  Commit: e6bfdeca8b688913270334fa89c39a9c1ee2662a
      
https://github.com/qemu/qemu/commit/e6bfdeca8b688913270334fa89c39a9c1ee2662a
  Author: Alex Bennée <address@hidden>
  Date:   2018-07-05 (Thu, 05 Jul 2018)

  Changed paths:
    M tests/docker/dockerfiles/debian-bootstrap.docker

  Log Message:
  -----------
  docker: drop QEMU build-dep from bootstrap

This is best done with any child images that actually need it.

Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>


  Commit: 300cf467fd4f520a60d3eff7e73813337165dbcd
      
https://github.com/qemu/qemu/commit/300cf467fd4f520a60d3eff7e73813337165dbcd
  Author: Alex Bennée <address@hidden>
  Date:   2018-07-05 (Thu, 05 Jul 2018)

  Changed paths:
    M tests/docker/dockerfiles/debian-bootstrap.pre

  Log Message:
  -----------
  docker: debian-bootstrap.pre allow customising of variant/url

We default to the buildd variant as most of our images are for
building. However lets give the user the ability to specify "minbase"
if they want to create a simple base image for experimentation.

Allowing the tweaking of DEB_URL means we can also bootstrap other
Debian based OS's. For example:

  make docker-binfmt-image-debian-ubuntu-bionic-arm64 \
       DEB_ARCH=arm64 DEB_TYPE=bionic \
       DEB_VARIANT=minbase DEB_URL=http://ports.ubuntu.com/ \
       EXECUTABLE=./aarch64-linux-user/qemu-aarch64

Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>


  Commit: 547cb45ea309dfdbaa8395dcc4c6330899118e56
      
https://github.com/qemu/qemu/commit/547cb45ea309dfdbaa8395dcc4c6330899118e56
  Author: Alex Bennée <address@hidden>
  Date:   2018-07-05 (Thu, 05 Jul 2018)

  Changed paths:
    M tests/docker/docker.py

  Log Message:
  -----------
  docker: add special handling for FROM:debian-%-user targets

These will have been build with debootstrap so we need to check
against the debian-bootstrap dockerfile. This does mean sticking to
debian-FOO-user as the naming conventions for boot-strapped images.
The actual cross image is built on top.

Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>


  Commit: dc338fdb07cf92b102c5ecfb4a4c259229404139
      
https://github.com/qemu/qemu/commit/dc338fdb07cf92b102c5ecfb4a4c259229404139
  Author: Alex Bennée <address@hidden>
  Date:   2018-07-05 (Thu, 05 Jul 2018)

  Changed paths:
    M tests/docker/Makefile.include

  Log Message:
  -----------
  docker: add special rule for deboostrapped images

We might as well have a custom rule for this. For one thing the
dependencies are different. As the primary dependency for
docker-image-% could never be docker-image-debian-bootstrap we can
drop that test in the main rule as well.

Missing EXECUTABLE, DEB_ARCH and DEB_TYPE are treated as hard faults
now. We also error out if the EXECUTABLE file isn't there. We should
really do this with a dependency on any source rules but currently
subdir-FOO-linux-user isn't enough on a clean build.

Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>


  Commit: 19c9a18f45fc8d8b8e96a6b8ea6074d08b6a8612
      
https://github.com/qemu/qemu/commit/19c9a18f45fc8d8b8e96a6b8ea6074d08b6a8612
  Author: Alex Bennée <address@hidden>
  Date:   2018-07-05 (Thu, 05 Jul 2018)

  Changed paths:
    M tests/docker/Makefile.include
    A tests/docker/dockerfiles/debian-powerpc-user-cross.docker

  Log Message:
  -----------
  docker: add linux-user powered cross builder for QEMU

We can't use cross compilers in the current Debian stable and Debian
sid is sketchy as hell. So for powerpc fall back to dog-fooding our
own linux-user to do the build.

As we can only build the base image with a suitably configured
source tree we fall back to checking for its existence when we can't
build it from scratch. However this does mean you don't have to keep
a static powerpc-linux-user in your active configuration just to
update the cross build image.

Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>


  Commit: cee35138b59c6d6b0808c5fa644e3f063832860f
      
https://github.com/qemu/qemu/commit/cee35138b59c6d6b0808c5fa644e3f063832860f
  Author: Peter Maydell <address@hidden>
  Date:   2018-07-05 (Thu, 05 Jul 2018)

  Changed paths:
    M .gitignore
    M .travis.yml
    M MAINTAINERS
    M Makefile
    M configure
    M docs/devel/testing.rst
    M linux-user/Makefile.objs
    A linux-user/exit.c
    M linux-user/qemu.h
    M linux-user/syscall.c
    M scripts/create_config
    A scripts/travis/coverage-summary.sh
    M tests/Makefile.include
    M tests/docker/Makefile.include
    M tests/docker/docker.py
    M tests/docker/dockerfiles/debian-bootstrap.docker
    M tests/docker/dockerfiles/debian-bootstrap.pre
    A tests/docker/dockerfiles/debian-powerpc-user-cross.docker
    M tests/docker/dockerfiles/debian8-mxe.docker
    M tests/docker/dockerfiles/travis.docker
    M tests/docker/dockerfiles/ubuntu.docker

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/stsquad/tags/pull-code-coverage-and-build-tweaks-050718-3' into staging

Code coverage and other build tweaks

  - revert 208ecb3e (and drop filter for mingw, tweak for check-tcg)
  - some travis speed-ups
  - modernise code coverage support
  - docker image cleanups
  - clean-up binfmt_misc docker infrastructure
  - add debian-powerpc-user-cross image for ppc32 build

# gpg: Signature made Thu 05 Jul 2018 17:00:02 BST
# gpg:                using RSA key FBD0DB095A9E2A44
# gpg: Good signature from "Alex Bennée (Master Work Key) <address@hidden>"
# Primary key fingerprint: 6685 AE99 E751 67BC AFC8  DF35 FBD0 DB09 5A9E 2A44

* remotes/stsquad/tags/pull-code-coverage-and-build-tweaks-050718-3:
  docker: add linux-user powered cross builder for QEMU
  docker: add special rule for deboostrapped images
  docker: add special handling for FROM:debian-%-user targets
  docker: debian-bootstrap.pre allow customising of variant/url
  docker: drop QEMU build-dep from bootstrap
  docker: Do not run tests in 'intermediate' images
  docker: Clean the MXE base image
  docker: ubuntu: Use SDL2
  docker: ubuntu: Update the package list before installing new ones
  linux-user: add gcov support to preexit_cleanup
  linux-user: introduce preexit_cleanup
  build-system: add coverage-report target
  build-system: add clean-coverage target
  travis: add gcovr summary for GCOV build
  docker: add gcovr to travis image
  .gitignore: add .gcov files
  build-system: remove per-test GCOV reporting
  travis: test out-of-tree builds
  travis: do not waste time cloning unused submodules
  Revert "Makefile: Rename TARGET_DIRS to TARGET_LIST"

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/efe2606862e7...cee35138b59c
      **NOTE:** This service been marked for deprecation: 
https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.
[Prev in Thread]
Current Thread
[Next in Thread]
[Qemu-commits] [qemu/qemu] 2b1f35: Revert "Makefile: Rename TARGET_DIRS to TARGET_LIS..., GitHub <=
Prev by Date: [Qemu-commits] [qemu/qemu] 19020d: coverity-model: Fix replay_get_byte()
Next by Date: [Qemu-commits] [qemu/qemu] 230809: hw/riscv/sifive_u: Create a SiFive U SoC object
Previous by thread: [Qemu-commits] [qemu/qemu] 19020d: coverity-model: Fix replay_get_byte()
Next by thread: [Qemu-commits] [qemu/qemu] 230809: hw/riscv/sifive_u: Create a SiFive U SoC object
Index(es):
- Date
- Thread