[Qemu-commits] [qemu/qemu] ae79c2: ahci: fix FIS I bit and PIO Setup FIS interrupt

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: ae79c2db150e17757ee1be080481be675a15ccea
      
https://github.com/qemu/qemu/commit/ae79c2db150e17757ee1be080481be675a15ccea
  Author: Paolo Bonzini <address@hidden>
  Date:   2018-06-25 (Mon, 25 Jun 2018)

  Changed paths:
    M hw/ide/ahci.c
    M hw/ide/ahci_internal.h
    M tests/libqos/ahci.c
    M tests/libqos/ahci.h

  Log Message:
  -----------
  ahci: fix FIS I bit and PIO Setup FIS interrupt

The "I" bit in PIO Setup and D2H FISes is exclusively a device concept
and the irqstatus register in the controller does not matter.  The SATA
spec says when it should be one; for D2H FISes in practice it is always
set, while the PIO Setup FIS has several subcases that are documented in
the patch.

Also, the PIO Setup FIS interrupt is actually generated _after_ data
has been received.

Someone should probably spend some time reading the SATA specification and
figuring out the more obscure fields in the PIO Setup FIS, but this is enough
to fix SeaBIOS booting from ATAPI CD-ROMs over an AHCI controller.

Fixes: 956556e131e35f387ac482ad7b41151576fef057
Reported-by: Gerd Hoffmann <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: John Snow <address@hidden>
Message-id: address@hidden
[Minor edit to avoid ATAPI comment ambiguity. --js]
Signed-off-by: John Snow <address@hidden>


  Commit: 595123df1d54ed8fbab9e1a73d5a58c5bb71058f
      
https://github.com/qemu/qemu/commit/595123df1d54ed8fbab9e1a73d5a58c5bb71058f
  Author: Peter Maydell <address@hidden>
  Date:   2018-06-26 (Tue, 26 Jun 2018)

  Changed paths:
    M hw/ide/ahci.c
    M hw/ide/ahci_internal.h
    M tests/libqos/ahci.c
    M tests/libqos/ahci.h

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/jnsnow/tags/ide-pull-request' into 
staging

Pull request

# gpg: Signature made Mon 25 Jun 2018 22:11:06 BST
# gpg:                using RSA key 7DEF8106AAFC390E
# gpg: Good signature from "John Snow (John Huston) <address@hidden>"
# Primary key fingerprint: FAEB 9711 A12C F475 812F  18F2 88A9 064D 1835 61EB
#      Subkey fingerprint: F9B7 ABDB BCAC DF95 BE76  CBD0 7DEF 8106 AAFC 390E

* remotes/jnsnow/tags/ide-pull-request:
  ahci: fix FIS I bit and PIO Setup FIS interrupt

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/35e238c93306...595123df1d54
      **NOTE:** This service been marked for deprecation: 
https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.