qemu-commits
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] def74c: target-mips: fix compiler warnings (c

From: GitHub
Subject: [Qemu-commits] [qemu/qemu] def74c: target-mips: fix compiler warnings (clang 5)
Date: Mon, 20 Mar 2017 07:30:11 -0700 
  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: def74c0cf05722b2e502d4b4f1219966c5b0cbd3
      
https://github.com/qemu/qemu/commit/def74c0cf05722b2e502d4b4f1219966c5b0cbd3
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2017-03-20 (Mon, 20 Mar 2017)

  Changed paths:
    M target/mips/helper.c

  Log Message:
  -----------
  target-mips: fix compiler warnings (clang 5)

static code analyzer complain:

target/mips/helper.c:453:5: warning: Function call argument is an uninitialized 
value
    qemu_log_mask(CPU_LOG_MMU,
    ^~~~~~~~~~~~~~~~~~~~~~~~~~

'physical' and 'prot' are uninitialized if 'ret' is not TLBRET_MATCH.

Reported-by: Clang Static Analyzer
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Yongbok Kim <address@hidden>
Signed-off-by: Yongbok Kim <address@hidden>


  Commit: 989f2aa9af7f05c323761b66c0e299059a19b7b1
      
https://github.com/qemu/qemu/commit/989f2aa9af7f05c323761b66c0e299059a19b7b1
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2017-03-20 (Mon, 20 Mar 2017)

  Changed paths:
    M target/mips/translate.c

  Log Message:
  -----------
  target-mips: remove old & unuseful comments

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Yongbok Kim <address@hidden>
Signed-off-by: Yongbok Kim <address@hidden>


  Commit: 965447eecb6b98d6dfc4dbd97f836093c7e398a0
      
https://github.com/qemu/qemu/commit/965447eecb6b98d6dfc4dbd97f836093c7e398a0
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2017-03-20 (Mon, 20 Mar 2017)

  Changed paths:
    M target/mips/translate.c

  Log Message:
  -----------
  target-mips: log bad coprocessor0 register accesses with LOG_UNIMP

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Yongbok Kim <address@hidden>
Signed-off-by: Yongbok Kim <address@hidden>


  Commit: 3570d7f6672836140f0a1ec9bf95dd5ea50a2aaa
      
https://github.com/qemu/qemu/commit/3570d7f6672836140f0a1ec9bf95dd5ea50a2aaa
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2017-03-20 (Mon, 20 Mar 2017)

  Changed paths:
    M target/mips/translate.c

  Log Message:
  -----------
  target-mips: replace break by goto cp0_unimplemented

this fixes many warnings like:

target/mips/translate.c:6253:13: warning: Value stored to 'rn' is never read
      rn = "invalid sel";
      ^    ~~~~~~~~~~~~~

Reported-by: Clang Static Analyzer
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Yongbok Kim <address@hidden>
Signed-off-by: Yongbok Kim <address@hidden>


  Commit: b44a7fb14eaebb4f606f768c66122aa54d471887
      
https://github.com/qemu/qemu/commit/b44a7fb14eaebb4f606f768c66122aa54d471887
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2017-03-20 (Mon, 20 Mar 2017)

  Changed paths:
    M Makefile.objs
    A target/mips/trace-events
    M target/mips/translate.c

  Log Message:
  -----------
  target-mips: replace few LOG_DISAS() with trace points

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Yongbok Kim <address@hidden>
Signed-off-by: Yongbok Kim <address@hidden>


  Commit: 075a1fe788d36b271ec25507466c30b9a90b5d54
      
https://github.com/qemu/qemu/commit/075a1fe788d36b271ec25507466c30b9a90b5d54
  Author: Yongbok Kim <address@hidden>
  Date:   2017-03-20 (Mon, 20 Mar 2017)

  Changed paths:
    M target/mips/translate.c

  Log Message:
  -----------
  target/mips: fix delay slot detection in gen_msa_branch()

It is unnecessary to test R6 from delay/forbidden slot check
in gen_msa_branch().

https://bugs.launchpad.net/qemu/+bug/1663287

Reported-by: Brian Campbell <address@hidden>
Signed-off-by: Yongbok Kim <address@hidden>


  Commit: c0a3172fa6bbddcc73192f2a2c48d0bf3a7ba61c
      
https://github.com/qemu/qemu/commit/c0a3172fa6bbddcc73192f2a2c48d0bf3a7ba61c
  Author: Prasad J Pandit <address@hidden>
  Date:   2017-03-20 (Mon, 20 Mar 2017)

  Changed paths:
    M hw/dma/rc4030.c

  Log Message:
  -----------
  dma: rc4030: limit interval timer reload value

The JAZZ RC4030 chipset emulator has a periodic timer and
associated interval reload register. The reload value is used
as divider when computing timer's next tick value. If reload
value is large, it could lead to divide by zero error. Limit
the interval reload value to avoid it.

Reported-by: Huawei PSIRT <address@hidden>
Signed-off-by: Prasad J Pandit <address@hidden>
Tested-by: Hervé Poussineau <address@hidden>
Signed-off-by: Yongbok Kim <address@hidden>


  Commit: c627e7526a902dd5bb1907dbbd5cf961679dfa68
      
https://github.com/qemu/qemu/commit/c627e7526a902dd5bb1907dbbd5cf961679dfa68
  Author: Hervé Poussineau <address@hidden>
  Date:   2017-03-20 (Mon, 20 Mar 2017)

  Changed paths:
    M hw/dma/rc4030.c

  Log Message:
  -----------
  dma/rc4030: translate memory accesses only when they occur

This simplifies the code a lot, and this fixes big memory leaks
introduced in a3d586f704609a45b6037534cb2f34da5dfd8895

Windows NT is now able to boot without using gigabytes of ram on the host.

Signed-off-by: Hervé Poussineau <address@hidden>
Reviewed-by: Yongbok Kim <address@hidden>
Signed-off-by: Yongbok Kim <address@hidden>


  Commit: 1b393b310f887f22608624f62e5c7bbbc01b1fe7
      
https://github.com/qemu/qemu/commit/1b393b310f887f22608624f62e5c7bbbc01b1fe7
  Author: Yongbok Kim <address@hidden>
  Date:   2017-03-20 (Mon, 20 Mar 2017)

  Changed paths:
    M hw/dma/rc4030.c

  Log Message:
  -----------
  dma/rc4030: fix a mixed declarations and code warning

Signed-off-by: Yongbok Kim <address@hidden>
Reviewed-by: Hervé Poussineau <address@hidden>


  Commit: 659f42d8c30bad9bf677652fc9d3f0ada63fd6e0
      
https://github.com/qemu/qemu/commit/659f42d8c30bad9bf677652fc9d3f0ada63fd6e0
  Author: Yongbok Kim <address@hidden>
  Date:   2017-03-20 (Mon, 20 Mar 2017)

  Changed paths:
    M MAINTAINERS

  Log Message:
  -----------
  MAINTAINERS: update for MIPS devices

Add myself to MIPSSIM and new entry for Fulong 2E.
Add an entry for Boston machine (Paul Burton).

cc: Paul Burton <address@hidden>
Signed-off-by: Yongbok Kim <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>


  Commit: e8b974f1ed01fae17cc3d63413b85d5b0a4cfcb7
      
https://github.com/qemu/qemu/commit/e8b974f1ed01fae17cc3d63413b85d5b0a4cfcb7
  Author: Peter Maydell <address@hidden>
  Date:   2017-03-20 (Mon, 20 Mar 2017)

  Changed paths:
    M MAINTAINERS
    M Makefile.objs
    M hw/dma/rc4030.c
    M target/mips/helper.c
    A target/mips/trace-events
    M target/mips/translate.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/yongbok/tags/mips-20170320' into staging

MIPS patches 2017-03-20

Changes:
* Fix clang warnings
* Fix delay slot detection in gen_msa_branch()
* Fix rc4030 interval timer
* Fix rc4030 to tranlate memory accesses only when they occur
* Fix 4c4030 a mixed declarations and code warning
* Update MAINTAINERS file

# gpg: Signature made Mon 20 Mar 2017 12:46:01 GMT
# gpg:                using RSA key 0x2238EB86D5F797C2
# gpg: Good signature from "Yongbok Kim <address@hidden>"
# gpg: WARNING: This key is not certified with sufficiently trusted signatures!
# gpg:          It is not certain that the signature belongs to the owner.
# Primary key fingerprint: 8600 4CF5 3415 A5D9 4CFA  2B5C 2238 EB86 D5F7 97C2

* remotes/yongbok/tags/mips-20170320:
  MAINTAINERS: update for MIPS devices
  dma/rc4030: fix a mixed declarations and code warning
  dma/rc4030: translate memory accesses only when they occur
  dma: rc4030: limit interval timer reload value
  target/mips: fix delay slot detection in gen_msa_branch()
  target-mips: replace few LOG_DISAS() with trace points
  target-mips: replace break by goto cp0_unimplemented
  target-mips: log bad coprocessor0 register accesses with LOG_UNIMP
  target-mips: remove old & unuseful comments
  target-mips: fix compiler warnings (clang 5)

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/32f70d765998...e8b974f1ed01
reply via email to
[Prev in Thread] Current Thread [Next in Thread]