qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 3c15d3: hw/acpi/aml-build: remove useless gli


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 3c15d3: hw/acpi/aml-build: remove useless glib version che...
Date: Fri, 06 Nov 2015 06:00:05 -0800

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 3c15d3a45045de82c744c49ff471d4c7ba405187
      
https://github.com/qemu/qemu/commit/3c15d3a45045de82c744c49ff471d4c7ba405187
  Author: Marc-André Lureau <address@hidden>
  Date:   2015-11-06 (Fri, 06 Nov 2015)

  Changed paths:
    M hw/acpi/aml-build.c

  Log Message:
  -----------
  hw/acpi/aml-build: remove useless glib version check

2.22 is the minimum version required

Signed-off-by: Marc-André Lureau <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 5accecb3a6b49d8ca79684179610583e9c7c1bf5
      
https://github.com/qemu/qemu/commit/5accecb3a6b49d8ca79684179610583e9c7c1bf5
  Author: Kevin Wolf <address@hidden>
  Date:   2015-11-06 (Fri, 06 Nov 2015)

  Changed paths:
    M gdbstub.c

  Log Message:
  -----------
  gdbstub: Fix buffer overflows in gdb_handle_packet()

Some places in gdb_handle_packet() can get an arbitrary length (most
times directly from the client) and either didn't check it at all or
checked against the wrong value, potentially causing buffer overflows.

Cc: address@hidden
Signed-off-by: Kevin Wolf <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: b21de19992cefdfef68217e50a8365ee5e535e10
      
https://github.com/qemu/qemu/commit/b21de19992cefdfef68217e50a8365ee5e535e10
  Author: Thomas Huth <address@hidden>
  Date:   2015-11-06 (Fri, 06 Nov 2015)

  Changed paths:
    M hw/display/tcx.c

  Log Message:
  -----------
  hw/display/tcx: Remove superfluous OBJECT() typecasts

The tcx_initfn() function is already supplied with an
Object *obj pointer, so there is no need to cast the
state pointer back to an Object pointer all over the
place. And while we're at it, also remove the superfluous
"return;" statement in this function.

Signed-off-by: Thomas Huth <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Acked-by: Mark Cave-Ayland <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 53d47be25a0c8bde5aa5b53625bc810f91c6271f
      
https://github.com/qemu/qemu/commit/53d47be25a0c8bde5aa5b53625bc810f91c6271f
  Author: Eric Blake <address@hidden>
  Date:   2015-11-06 (Fri, 06 Nov 2015)

  Changed paths:
    M .gitignore

  Log Message:
  -----------
  maint: Ignore ivshmem binaries

Commit a75eb03b added ivshmem-client and ivshmem-server binaries,
but did not mark them for exclusion in .gitignore.

Signed-off-by: Eric Blake <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 6ba9fe86957c3c8febf74c2495d901ac4061a673
      
https://github.com/qemu/qemu/commit/6ba9fe86957c3c8febf74c2495d901ac4061a673
  Author: Cao jin <address@hidden>
  Date:   2015-11-06 (Fri, 06 Nov 2015)

  Changed paths:
    M hw/pci/pcie.c

  Log Message:
  -----------
  fix bad indentation in pcie_cap_slot_write_config()

bad indentation conflicts with CODING_STYLE doc

Signed-off-by: Cao jin <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 3cd01b6ed8a1ae472f09cbcc47b7cba4d732f94c
      
https://github.com/qemu/qemu/commit/3cd01b6ed8a1ae472f09cbcc47b7cba4d732f94c
  Author: Eric Blake <address@hidden>
  Date:   2015-11-06 (Fri, 06 Nov 2015)

  Changed paths:
    M tests/.gitignore

  Log Message:
  -----------
  tests: ignore test-qga

Commit 62c39b30 added a new test, but did not mark it for
exclusion in .gitignore.

Signed-off-by: Eric Blake <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 2c21ec3d1818cb0395b5a9b73128e6920d44def7
      
https://github.com/qemu/qemu/commit/2c21ec3d1818cb0395b5a9b73128e6920d44def7
  Author: Paolo Bonzini <address@hidden>
  Date:   2015-11-06 (Fri, 06 Nov 2015)

  Changed paths:
    M hw/xen/xen_pt_config_init.c

  Log Message:
  -----------
  xen: fix invalid assertion

Asserting "true" is not that useful.

Reported by Coverity.

Signed-off-by: Paolo Bonzini <address@hidden>
Acked-by: Stefano Stabellini <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: a6c6d827605e416f0e127a325ee1efc9cf16afa5
      
https://github.com/qemu/qemu/commit/a6c6d827605e416f0e127a325ee1efc9cf16afa5
  Author: Thomas Huth <address@hidden>
  Date:   2015-11-06 (Fri, 06 Nov 2015)

  Changed paths:
    M hw/input/tsc210x.c

  Log Message:
  -----------
  hw/input/tsc210x: Remove superfluous memset

g_malloc0 already clears the memory, so no need for additional
memsets here. And while we're at it, let's also remove the
superfluous typecasts for the return values of g_malloc0
and use the type-safe g_new0 instead.

Signed-off-by: Thomas Huth <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 112317867d573bb053d431f098060cf996d9b2e8
      
https://github.com/qemu/qemu/commit/112317867d573bb053d431f098060cf996d9b2e8
  Author: Thomas Huth <address@hidden>
  Date:   2015-11-06 (Fri, 06 Nov 2015)

  Changed paths:
    M tests/i440fx-test.c

  Log Message:
  -----------
  tests/i44fx-test: No need for zeroing memory before memset

Change a g_malloc0 into g_malloc since the following
memset fills the whole buffer anyway.

Signed-off-by: Thomas Huth <address@hidden>
Reviewed-by: Laszlo Ersek <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: e9d49d518d5d2b0411ee2625e46662a6065a909c
      
https://github.com/qemu/qemu/commit/e9d49d518d5d2b0411ee2625e46662a6065a909c
  Author: Thomas Huth <address@hidden>
  Date:   2015-11-06 (Fri, 06 Nov 2015)

  Changed paths:
    M linux-user/syscall.c

  Log Message:
  -----------
  linux-user/syscall: Replace g_malloc0 + memcpy with g_memdup

No need to use g_malloc0 to zero the memory if we memcpy to
the whole buffer afterwards anyway. Actually, there is even
a function which combines both steps, g_memdup, so let's use
this function here instead.

Signed-off-by: Thomas Huth <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 1a13b27273cdc4f6fd18bc1e83950d47c6b5928b
      
https://github.com/qemu/qemu/commit/1a13b27273cdc4f6fd18bc1e83950d47c6b5928b
  Author: Thomas Huth <address@hidden>
  Date:   2015-11-06 (Fri, 06 Nov 2015)

  Changed paths:
    M hw/dma/pxa2xx_dma.c

  Log Message:
  -----------
  hw/dma/pxa2xx: Remove superfluous memset

g_malloc0 already clears the memory, so no need for
the additional memset here. And while we're at it,
also convert the g_malloc0 to the preferred g_new0.

Signed-off-by: Thomas Huth <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 374ec0669a1aa3affac7850a16c6cad18221c439
      
https://github.com/qemu/qemu/commit/374ec0669a1aa3affac7850a16c6cad18221c439
  Author: Paolo Bonzini <address@hidden>
  Date:   2015-11-06 (Fri, 06 Nov 2015)

  Changed paths:
    M hw/bt/sdp.c

  Log Message:
  -----------
  bt: fix use of uninitialized variable seqlen

sdp_svc_match, sdp_attr_match and sdp_svc_attr_match read the last
argument.  The only sensible way to change the code is to make that last
argument "len" instead of "seqlen" which is the length of a subsequence
in the previous "if" branch.

To make the structure of the code clearer, use "else" instead of
"else if".

Reported by Coverity.

Signed-off-by: Paolo Bonzini <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: fedf0d35aafc4f1f1e5f6dbc80cb23ae1ae49f0b
      
https://github.com/qemu/qemu/commit/fedf0d35aafc4f1f1e5f6dbc80cb23ae1ae49f0b
  Author: Markus Armbruster <address@hidden>
  Date:   2015-11-06 (Fri, 06 Nov 2015)

  Changed paths:
    M ui/console.c
    M ui/curses.c
    M ui/input-legacy.c
    M ui/keymaps.c
    M ui/sdl.c
    M ui/vnc-jobs.c
    M ui/vnc.c

  Log Message:
  -----------
  ui: Use g_new() & friends where that makes obvious sense

g_new(T, n) is neater than g_malloc(sizeof(T) * n).  It's also safer,
for two reasons.  One, it catches multiplication overflowing size_t.
Two, it returns T * rather than void *, which lets the compiler catch
more type errors.

This commit only touches allocations with size arguments of the form
sizeof(T).  Same Coccinelle semantic patch as in commit b45c03f.

Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 9de68637dff05a18d0eafcff2737e551b70bc490
      
https://github.com/qemu/qemu/commit/9de68637dff05a18d0eafcff2737e551b70bc490
  Author: Markus Armbruster <address@hidden>
  Date:   2015-11-06 (Fri, 06 Nov 2015)

  Changed paths:
    M hw/display/qxl.c

  Log Message:
  -----------
  qxl: Use g_new() & friends where that makes obvious sense

g_new(T, n) is neater than g_malloc(sizeof(T) * n).  It's also safer,
for two reasons.  One, it catches multiplication overflowing size_t.
Two, it returns T * rather than void *, which lets the compiler catch
more type errors.

This commit only touches allocations with size arguments of the form
sizeof(T).  Same Coccinelle semantic patch as in commit b45c03f.

Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Gerd Hoffmann <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 98f343395e937fa1db3a28dfb4f303f97cfddd6c
      
https://github.com/qemu/qemu/commit/98f343395e937fa1db3a28dfb4f303f97cfddd6c
  Author: Markus Armbruster <address@hidden>
  Date:   2015-11-06 (Fri, 06 Nov 2015)

  Changed paths:
    M hw/usb/ccid-card-emulated.c
    M hw/usb/dev-mtp.c
    M hw/usb/hcd-xhci.c
    M hw/usb/redirect.c

  Log Message:
  -----------
  usb: Use g_new() & friends where that makes obvious sense

g_new(T, n) is neater than g_malloc(sizeof(T) * n).  It's also safer,
for two reasons.  One, it catches multiplication overflowing size_t.
Two, it returns T * rather than void *, which lets the compiler catch
more type errors.

This commit only touches allocations with size arguments of the form
sizeof(T).  Same Coccinelle semantic patch as in commit b45c03f.

Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Gerd Hoffmann <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 9f503153c78a23bcd44409cea64442c4ecd82ea5
      
https://github.com/qemu/qemu/commit/9f503153c78a23bcd44409cea64442c4ecd82ea5
  Author: Daniel P. Berrange <address@hidden>
  Date:   2015-11-06 (Fri, 06 Nov 2015)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: remove help string for 'vnc-tls' option

The '--enable-vnc-tls' option to configure was removed in

  commit 3e305e4a4752f70c0b5c3cf5b43ec957881714f7
  Author: Daniel P. Berrange <address@hidden>
  Date:   Thu Aug 6 14:39:32 2015 +0100

    ui: convert VNC server to use QCryptoTLSSession

This removes the corresponding help string.

Signed-off-by: Daniel P. Berrange <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: b30d80546421c6ea919096b596887f496c80af0a
      
https://github.com/qemu/qemu/commit/b30d80546421c6ea919096b596887f496c80af0a
  Author: Cao jin <address@hidden>
  Date:   2015-11-06 (Fri, 06 Nov 2015)

  Changed paths:
    M include/qom/object.h
    M qom/object.c

  Log Message:
  -----------
  qom/object: fix 2 comment typos

Also change the misleading definition of macro OBJECT_CLASS_CHECK

Signed-off-by: Cao jin <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 6268520d7df9b3f183bb4397218c9287441bc04f
      
https://github.com/qemu/qemu/commit/6268520d7df9b3f183bb4397218c9287441bc04f
  Author: Paolo Bonzini <address@hidden>
  Date:   2015-11-06 (Fri, 06 Nov 2015)

  Changed paths:
    M hw/i386/pci-assign-load-rom.c

  Log Message:
  -----------
  pci-assign: do not test path with access() before opening

Using access() is a time-of-check/time-of-use race condition.  It is
okay to use them to provide better error messages, but that is pretty
much it.

In this case we can get the same error from fopen(), so just use
strerror and errno there---which actually improves the error
message most of the time.

Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 258133bda9a6f22ba436ef9b63b7c086cc80190b
      
https://github.com/qemu/qemu/commit/258133bda9a6f22ba436ef9b63b7c086cc80190b
  Author: Gonglei <address@hidden>
  Date:   2015-11-06 (Fri, 06 Nov 2015)

  Changed paths:
    M contrib/ivshmem-server/ivshmem-server.c

  Log Message:
  -----------
  ivshmem-server: fix possible OVERRUN

>>>     CID 1337991:  Memory - illegal accesses  (OVERRUN)
>>>     Decrementing "i". The value of "i" is now 65534.
218         while (i--) {
219             event_notifier_cleanup(&peer->vectors[i]);
220         }

Signed-off-by: Gonglei <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 74de807f794ac5201b2b3c38ddadeef84a676a97
      
https://github.com/qemu/qemu/commit/74de807f794ac5201b2b3c38ddadeef84a676a97
  Author: Paolo Bonzini <address@hidden>
  Date:   2015-11-06 (Fri, 06 Nov 2015)

  Changed paths:
    M target-alpha/translate.c

  Log Message:
  -----------
  target-alpha: fix uninitialized variable

I am not sure why the compiler does not catch it.  There is no
semantic change since gen_excp returns EXIT_NORETURN, but the
old code is wrong.

Reported by Coverity.

Signed-off-by: Paolo Bonzini <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 68851b98e5bf6d397498b74f1776801274ab8d48
      
https://github.com/qemu/qemu/commit/68851b98e5bf6d397498b74f1776801274ab8d48
  Author: Paolo Bonzini <address@hidden>
  Date:   2015-11-06 (Fri, 06 Nov 2015)

  Changed paths:
    M exec.c

  Log Message:
  -----------
  exec: avoid unnecessary cacheline bounce on ram_list.mru_block

Whenever the MRU cache hits for the list of RAM blocks, qemu_get_ram_block
does an unnecessary write that causes a processor cache line to bounce
from one core to another.  This causes a performance hit.

Reported-by: Emilio G. Cota <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 3ede8f699645f4ca7cdbc40d8139e5a0275b4805
      
https://github.com/qemu/qemu/commit/3ede8f699645f4ca7cdbc40d8139e5a0275b4805
  Author: Julio Guerra <address@hidden>
  Date:   2015-11-06 (Fri, 06 Nov 2015)

  Changed paths:
    M target-ppc/translate_init.c

  Log Message:
  -----------
  taget-ppc: Fix read access to IBAT registers higher than IBAT3

Fix the index used to read the IBAT's vector which results in IBAT0..3 instead
of IBAT4..N.

The bug appeared by saving/restoring contexts including IBATs values.

Signed-off-by: Julio Guerra <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: a2f31f180499593b5edb8ac5ab8ac1b92f0abcd4
      
https://github.com/qemu/qemu/commit/a2f31f180499593b5edb8ac5ab8ac1b92f0abcd4
  Author: Paolo Bonzini <address@hidden>
  Date:   2015-11-06 (Fri, 06 Nov 2015)

  Changed paths:
    M util/qemu-sockets.c

  Log Message:
  -----------
  qemu-sockets: do not test path with access() before unlinking

Using access() is a time-of-check/time-of-use race condition.  It is
okay to use them to provide better error messages, but that is pretty
much it.

This is not one such case; on the other hand, access() *will* skip
unlink() for a non-existent path, so ignore ENOENT return values from
the unlink() system call.

Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Reviewed-by: Edgar E. Iglesias <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: bd54a9f9435c85de190a82019faef16c5ecf8e46
      
https://github.com/qemu/qemu/commit/bd54a9f9435c85de190a82019faef16c5ecf8e46
  Author: Ed Maste <address@hidden>
  Date:   2015-11-06 (Fri, 06 Nov 2015)

  Changed paths:
    M net/tap-bsd.c

  Log Message:
  -----------
  tap-bsd: use user-specified tap device if it already exists

Acked-by: Roger Pau Monné <address@hidden>
Signed-off-by: Ed Maste <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 4b59f39bc9a03afcc74b2fa28da7c3189fca507c
      
https://github.com/qemu/qemu/commit/4b59f39bc9a03afcc74b2fa28da7c3189fca507c
  Author: Peter Maydell <address@hidden>
  Date:   2015-11-06 (Fri, 06 Nov 2015)

  Changed paths:
    M .gitignore
    M configure
    M contrib/ivshmem-server/ivshmem-server.c
    M exec.c
    M gdbstub.c
    M hw/acpi/aml-build.c
    M hw/bt/sdp.c
    M hw/display/qxl.c
    M hw/display/tcx.c
    M hw/dma/pxa2xx_dma.c
    M hw/i386/pci-assign-load-rom.c
    M hw/input/tsc210x.c
    M hw/pci/pcie.c
    M hw/usb/ccid-card-emulated.c
    M hw/usb/dev-mtp.c
    M hw/usb/hcd-xhci.c
    M hw/usb/redirect.c
    M hw/xen/xen_pt_config_init.c
    M include/qom/object.h
    M linux-user/syscall.c
    M net/tap-bsd.c
    M qom/object.c
    M target-alpha/translate.c
    M target-ppc/translate_init.c
    M tests/.gitignore
    M tests/i440fx-test.c
    M ui/console.c
    M ui/curses.c
    M ui/input-legacy.c
    M ui/keymaps.c
    M ui/sdl.c
    M ui/vnc-jobs.c
    M ui/vnc.c
    M util/qemu-sockets.c

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/mjt/tags/pull-trivial-patches-2015-11-06' into staging

trivial patches for 2015-11-06

# gpg: Signature made Fri 06 Nov 2015 12:42:43 GMT using RSA key ID A4C3D7DB
# gpg: Good signature from "Michael Tokarev <address@hidden>"
# gpg:                 aka "Michael Tokarev <address@hidden>"
# gpg:                 aka "Michael Tokarev <address@hidden>"

* remotes/mjt/tags/pull-trivial-patches-2015-11-06: (24 commits)
  tap-bsd: use user-specified tap device if it already exists
  qemu-sockets: do not test path with access() before unlinking
  taget-ppc: Fix read access to IBAT registers higher than IBAT3
  exec: avoid unnecessary cacheline bounce on ram_list.mru_block
  target-alpha: fix uninitialized variable
  ivshmem-server: fix possible OVERRUN
  pci-assign: do not test path with access() before opening
  qom/object: fix 2 comment typos
  configure: remove help string for 'vnc-tls' option
  usb: Use g_new() & friends where that makes obvious sense
  qxl: Use g_new() & friends where that makes obvious sense
  ui: Use g_new() & friends where that makes obvious sense
  bt: fix use of uninitialized variable seqlen
  hw/dma/pxa2xx: Remove superfluous memset
  linux-user/syscall: Replace g_malloc0 + memcpy with g_memdup
  tests/i44fx-test: No need for zeroing memory before memset
  hw/input/tsc210x: Remove superfluous memset
  xen: fix invalid assertion
  tests: ignore test-qga
  fix bad indentation in pcie_cap_slot_write_config()
  ...

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/9319738080fa...4b59f39bc9a0

reply via email to

[Prev in Thread] Current Thread [Next in Thread]