[Qemu-commits] [qemu/qemu] 125053: qga: drop hand-made guest_file_toggle_flags helper

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 125053965b05b31427ff5c75dc3b87acaa8d0505
      
https://github.com/qemu/qemu/commit/125053965b05b31427ff5c75dc3b87acaa8d0505
  Author: Denis V. Lunev <address@hidden>
  Date:   2015-11-04 (Wed, 04 Nov 2015)

  Changed paths:
    M qga/commands-posix.c

  Log Message:
  -----------
  qga: drop hand-made guest_file_toggle_flags helper

We'd better use generic qemu_set_nonblock directly.

Signed-off-by: Denis V. Lunev <address@hidden>
Reviewed-by: Yuri Pudgorodskiy <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
CC: Michael Roth <address@hidden>
Signed-off-by: Michael Roth <address@hidden>


  Commit: c87d0964ef7534d50a4c729a6ae20045b3a0cd34
      
https://github.com/qemu/qemu/commit/c87d0964ef7534d50a4c729a6ae20045b3a0cd34
  Author: Olga Krishtal <address@hidden>
  Date:   2015-11-04 (Wed, 04 Nov 2015)

  Changed paths:
    M qga/commands-win32.c

  Log Message:
  -----------
  qga: fixed CloseHandle in qmp_guest_file_open

CloseHandle use HANDLE as an argument, but not *HANDLE

Signed-off-by: Olga Krishtal <address@hidden>
Signed-off-by: Denis V. Lunev <address@hidden>
Reviewed-by: Stefan Weil <address@hidden>
CC: Michael Roth <address@hidden>
Signed-off-by: Michael Roth <address@hidden>


  Commit: fb68777312887000cd0367d72621fdd67cc4a0a0
      
https://github.com/qemu/qemu/commit/fb68777312887000cd0367d72621fdd67cc4a0a0
  Author: Olga Krishtal <address@hidden>
  Date:   2015-11-04 (Wed, 04 Nov 2015)

  Changed paths:
    M qga/commands-win32.c

  Log Message:
  -----------
  qga: set file descriptor in qmp_guest_file_open non-blocking on Win32

Set fd non-blocking to avoid common use cases (like reading from a
named pipe) from hanging the agent. This was missed in the original
code.

The patch introduces qemu_set_handle_nonoblocking, the local analog
of qemu_set_nonblock for HANDLES.
The usage of handles in qemu_set_non/block is impossible, because for
win32 there is a difference between file discriptors and file handles,
and all file ops are made via Win32 api.

Signed-off-by: Olga Krishtal <address@hidden>
Signed-off-by: Denis V. Lunev <address@hidden>
CC: Michael Roth <address@hidden>
CC: Stefan Weil <address@hidden>
Signed-off-by: Michael Roth <address@hidden>


  Commit: 8835b9df3bddf332c883c861d6a1defc12c4ebe9
      
https://github.com/qemu/qemu/commit/8835b9df3bddf332c883c861d6a1defc12c4ebe9
  Author: Peter Maydell <address@hidden>
  Date:   2015-11-05 (Thu, 05 Nov 2015)

  Changed paths:
    M qga/commands-posix.c
    M qga/commands-win32.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/mdroth/tags/qga-pull-2015-11-04-tag' 
into staging

qemu-ga patch queue

* fix file handle cleanup on w32
* use non-blocking mode for file handles on w32 to avoid
  hangs on guest-file-read/guest-file-write to pipes

# gpg: Signature made Wed 04 Nov 2015 19:36:16 GMT using RSA key ID F108B584
# gpg: Good signature from "Michael Roth <address@hidden>"
# gpg:                 aka "Michael Roth <address@hidden>"
# gpg:                 aka "Michael Roth <address@hidden>"

* remotes/mdroth/tags/qga-pull-2015-11-04-tag:
  qga: set file descriptor in qmp_guest_file_open non-blocking on Win32
  qga: fixed CloseHandle in qmp_guest_file_open
  qga: drop hand-made guest_file_toggle_flags helper

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/6c5f30cad290...8835b9df3bdd