[Qemu-commits] [qemu/qemu] 94f5a4: migration: defer migration_end & blk_mig_cleanup

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 94f5a43704129ca4995aa3385303c5ae225bde42
      
https://github.com/qemu/qemu/commit/94f5a43704129ca4995aa3385303c5ae225bde42
  Author: Liang Li <address@hidden>
  Date:   2015-11-04 (Wed, 04 Nov 2015)

  Changed paths:
    M migration/block.c
    M migration/migration.c
    M migration/ram.c

  Log Message:
  -----------
  migration: defer migration_end & blk_mig_cleanup

Because of the patch 3ea3b7fa9af067982f34b of kvm, which introduces a
lazy collapsing of small sptes into large sptes mechanism, now
migration_end() is a time consuming operation because it calls
memroy_global_dirty_log_stop(), which will trigger the dropping of small
sptes operation and takes about dozens of milliseconds, so call
migration_end() before all the vmsate data has already been transferred
to the destination will prolong VM downtime. This operation should be
deferred after all the data has been transferred to the destination.

blk_mig_cleanup() can be deferred too.

For a VM with 8G RAM, this patch can reduce the VM downtime about 30 ms.

Signed-off-by: Liang Li <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>al3
Reviewed-by: Amit Shah <address@hidden>al3
Signed-off-by: Juan Quintela <address@hidden>al3


  Commit: ea7415fac677c5c1599214ee226ab4a3a438fdd6
      
https://github.com/qemu/qemu/commit/ea7415fac677c5c1599214ee226ab4a3a438fdd6
  Author: Liang Li <address@hidden>
  Date:   2015-11-04 (Wed, 04 Nov 2015)

  Changed paths:
    M include/sysemu/sysemu.h
    M migration/migration.c
    M migration/savevm.c
    M trace-events

  Log Message:
  -----------
  migration: rename qemu_savevm_state_cancel

The function qemu_savevm_state_cancel is called after the migration
in migration_thread, it seems strange to 'cancel' it after completion,
rename it to qemu_savevm_state_cleanup looks better.

Signed-off-by: Liang Li <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>al3
Reviewed-by: Amit Shah <address@hidden>al3
Signed-off-by: Juan Quintela <address@hidden>al3


  Commit: d1a8548c10bf6d24160ec2aafa4881a3f50a8373
      
https://github.com/qemu/qemu/commit/d1a8548c10bf6d24160ec2aafa4881a3f50a8373
  Author: Liang Li <address@hidden>
  Date:   2015-11-04 (Wed, 04 Nov 2015)

  Changed paths:
    M include/migration/vmstate.h
    M migration/block.c
    M migration/ram.c
    M migration/savevm.c

  Log Message:
  -----------
  migration: rename cancel to cleanup in SaveVMHandles

'cleanup' seems more appropriate than 'cancel'.

Signed-off-by: Liang Li <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>al3
Reviewed-by: Amit Shah <address@hidden>al3
Signed-off-by: Juan Quintela <address@hidden>al3


  Commit: 6ad2a215e7170350430adfda02eb8ef47c1acd8e
      
https://github.com/qemu/qemu/commit/6ad2a215e7170350430adfda02eb8ef47c1acd8e
  Author: Liang Li <address@hidden>
  Date:   2015-11-04 (Wed, 04 Nov 2015)

  Changed paths:
    M migration/block.c
    M migration/ram.c

  Log Message:
  -----------
  migration: code clean up

Just clean up code, no behavior change.

Signed-off-by: Liang Li <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>al3
Reviewed-by: Amit Shah <address@hidden>al3
Signed-off-by: Juan Quintela <address@hidden>al3


  Commit: 96e5c9bc77acef8b7b56cbe23a8a2611feff9e34
      
https://github.com/qemu/qemu/commit/96e5c9bc77acef8b7b56cbe23a8a2611feff9e34
  Author: Mark Cave-Ayland <address@hidden>
  Date:   2015-11-04 (Wed, 04 Nov 2015)

  Changed paths:
    M scripts/analyze-migration.py

  Log Message:
  -----------
  migration: fix analyze-migration.py script

Commit 61964 "Add configuration section" broke the analyze-migration.py script
which terminates due to the unrecognised section. Fix the script by parsing
the contents of the configuration section directly into a new
ConfigurationSection object (although nothing is done with it yet).

Signed-off-by: Mark Cave-Ayland <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>al3
Signed-off-by: Juan Quintela <address@hidden>al3


  Commit: 6c5f30cad290c745f910481d0e890b3f4fad1f00
      
https://github.com/qemu/qemu/commit/6c5f30cad290c745f910481d0e890b3f4fad1f00
  Author: Peter Maydell <address@hidden>
  Date:   2015-11-05 (Thu, 05 Nov 2015)

  Changed paths:
    M include/migration/vmstate.h
    M include/sysemu/sysemu.h
    M migration/block.c
    M migration/migration.c
    M migration/ram.c
    M migration/savevm.c
    M scripts/analyze-migration.py
    M trace-events

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/juanquintela/tags/migration/20151104' 
into staging

migration/next for 20151104

# gpg: Signature made Wed 04 Nov 2015 12:45:19 GMT using RSA key ID 5872D723
# gpg: Good signature from "Juan Quintela <address@hidden>"
# gpg:                 aka "Juan Quintela <address@hidden>"

* remotes/juanquintela/tags/migration/20151104:
  migration: fix analyze-migration.py script
  migration: code clean up
  migration: rename cancel to cleanup in SaveVMHandles
  migration: rename qemu_savevm_state_cancel
  migration: defer migration_end & blk_mig_cleanup

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/2b5a79f1d961...6c5f30cad290