[Qemu-commits] [qemu/qemu] d4cd45: xen-pt: fix Negative array index read

qemu-commits
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] d4cd45: xen-pt: fix Negative array index read

From:	GitHub
Subject:	[Qemu-commits] [qemu/qemu] d4cd45: xen-pt: fix Negative array index read
Date:	Tue, 10 Mar 2015 07:30:07 -0700
  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: d4cd45028898a37afb45fb449954115b4960d4e9
      
https://github.com/qemu/qemu/commit/d4cd45028898a37afb45fb449954115b4960d4e9
  Author: Gonglei <address@hidden>
  Date:   2015-03-10 (Tue, 10 Mar 2015)

  Changed paths:
    M hw/xen/xen_pt_config_init.c

  Log Message:
  -----------
  xen-pt: fix Negative array index read

Coverity spot:
Function xen_pt_bar_offset_to_index() may return a negative
value (-1) which is used as an index to d->io_regions[] down
the line.

Let's pass index directly as an argument to
xen_pt_bar_reg_parse().

Signed-off-by: Gonglei <address@hidden>
Acked-by: Stefano Stabellini <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 14cec170ea4724e6881ba2febb20e88a942e52d3
      
https://github.com/qemu/qemu/commit/14cec170ea4724e6881ba2febb20e88a942e52d3
  Author: Gonglei <address@hidden>
  Date:   2015-03-10 (Tue, 10 Mar 2015)

  Changed paths:
    M hw/xen/xen_pt_config_init.c

  Log Message:
  -----------
  xen-pt: fix Out-of-bounds read

The array length of s->real_device.io_regions[] is
"PCI_NUM_REGIONS - 1".

Signed-off-by: Gonglei <address@hidden>
Acked-by: Stefano Stabellini <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 31da45ce04c5e886369bf88bf727cef5ccb3b12b
      
https://github.com/qemu/qemu/commit/31da45ce04c5e886369bf88bf727cef5ccb3b12b
  Author: Markus Armbruster <address@hidden>
  Date:   2015-03-10 (Tue, 10 Mar 2015)

  Changed paths:
    M hw/net/xilinx_ethlite.c

  Log Message:
  -----------
  xilinx_ethlite: Clean up after commit 2f991ad

The "fall through" added by the commit is clearly intentional.  Mark
it so.  Hushes up Coverity.

Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Peter Crosthwaite <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 0dc9daf0be2a4ebb3c6529d1c458d8ccf26cd412
      
https://github.com/qemu/qemu/commit/0dc9daf0be2a4ebb3c6529d1c458d8ccf26cd412
  Author: Borislav Petkov <address@hidden>
  Date:   2015-03-10 (Tue, 10 Mar 2015)

  Changed paths:
    M cpus.c

  Log Message:
  -----------
  memsave: Improve and disambiguate error message

When requesting a size which cannot be read, the error message shows
a different address which is misleading to the user and it looks like
something's wrong with the address parsing. This is because the input
@addr variable is incremented in the memory dumping loop:

(qemu) memsave 0xffffffff8418069c 0xb00000 mem
Invalid addr 0xffffffff849ffe9c specified

Fix that by saving the original address and size and use them in the
error message:

(qemu) memsave 0xffffffff8418069c 0xb00000 mem
Invalid addr 0xffffffff8418069c/size 11534336 specified

Signed-off-by: Borislav Petkov <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: b155eb1d0409eff4d0e7f33c746c81434f0ea629
      
https://github.com/qemu/qemu/commit/b155eb1d0409eff4d0e7f33c746c81434f0ea629
  Author: Gabriel L. Somlo <address@hidden>
  Date:   2015-03-10 (Tue, 10 Mar 2015)

  Changed paths:
    M qemu-options.hx

  Log Message:
  -----------
  smbios: document cmdline options for smbios type 2-4, 17 structures

Signed-off-by: Gabriel Somlo <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 7c601803fb5f868a05ef762eebcc32bdfd1ebfdc
      
https://github.com/qemu/qemu/commit/7c601803fb5f868a05ef762eebcc32bdfd1ebfdc
  Author: Michael Tokarev <address@hidden>
  Date:   2015-03-10 (Tue, 10 Mar 2015)

  Changed paths:
    M qemu-options.hx

  Log Message:
  -----------
  qemu-options: fix/document -incoming options

Signed-off-by: Michael Tokarev <address@hidden>


  Commit: cc5d0e04ee313d0ceee5d8e4e697142eaf240dca
      
https://github.com/qemu/qemu/commit/cc5d0e04ee313d0ceee5d8e4e697142eaf240dca
  Author: Paolo Bonzini <address@hidden>
  Date:   2015-03-10 (Tue, 10 Mar 2015)

  Changed paths:
    M util/cutils.c

  Log Message:
  -----------
  cutils: refine strtol error handling in parse_debug_env

Avoid truncation of a 64-bit long to a 32-bit int, and check for errno
(especially ERANGE).

Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 826a7cd9d94427aa72ff03f109632e48cf5f26ec
      
https://github.com/qemu/qemu/commit/826a7cd9d94427aa72ff03f109632e48cf5f26ec
  Author: Stefan Berger <address@hidden>
  Date:   2015-03-10 (Tue, 10 Mar 2015)

  Changed paths:
    M migration/qemu-file-buf.c

  Log Message:
  -----------
  Add copyright and author after file split

Signed-off-by: Stefan Berger <address@hidden>
Reviewed-by:  Dr. David Alan Gilbert <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 5b7a580f1f2d9ca04cf77d33515b29a149c01f1f
      
https://github.com/qemu/qemu/commit/5b7a580f1f2d9ca04cf77d33515b29a149c01f1f
  Author: Alberto Garcia <address@hidden>
  Date:   2015-03-10 (Tue, 10 Mar 2015)

  Changed paths:
    M include/qapi/qmp/qerror.h

  Log Message:
  -----------
  qerror.h: Swap definitions that were not in alphabetical order

Signed-off-by: Alberto Garcia <address@hidden>
Reviewed-by: John Snow <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 3599d46ba23062df580a23a50f8c103070d7365d
      
https://github.com/qemu/qemu/commit/3599d46ba23062df580a23a50f8c103070d7365d
  Author: Alberto Garcia <address@hidden>
  Date:   2015-03-10 (Tue, 10 Mar 2015)

  Changed paths:
    M qmp-commands.hx

  Log Message:
  -----------
  qmp-commands.hx: Fix several typos

Signed-off-by: Alberto Garcia <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: eec5eb42f597e652ad3b32d7bf13252966c4e85e
      
https://github.com/qemu/qemu/commit/eec5eb42f597e652ad3b32d7bf13252966c4e85e
  Author: Gonglei <address@hidden>
  Date:   2015-03-10 (Tue, 10 Mar 2015)

  Changed paths:
    M block/archipelago.c
    M hw/block/nand.c
    M qemu-img.c

  Log Message:
  -----------
  block: remove superfluous '\n' around error_report/error_setg

Signed-off-by: Gonglei <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 15e10b3499782df5d2adc0d2941e445a67d78a8a
      
https://github.com/qemu/qemu/commit/15e10b3499782df5d2adc0d2941e445a67d78a8a
  Author: Gonglei <address@hidden>
  Date:   2015-03-10 (Tue, 10 Mar 2015)

  Changed paths:
    M hw/timer/a9gtimer.c

  Log Message:
  -----------
  a9gtimer: remove superfluous '\n' around error_setg

Signed-off-by: Gonglei <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 0c267a6b40e8a85d3a6dacee853531d1e98da122
      
https://github.com/qemu/qemu/commit/0c267a6b40e8a85d3a6dacee853531d1e98da122
  Author: Gonglei <address@hidden>
  Date:   2015-03-10 (Tue, 10 Mar 2015)

  Changed paths:
    M hw/dma/pl330.c

  Log Message:
  -----------
  pl330.c: remove superfluous '\n' around error_setg

Signed-off-by: Gonglei <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 01bbbcf41fbd6a3b8d58a9a09e257f5ab1797f1d
      
https://github.com/qemu/qemu/commit/01bbbcf41fbd6a3b8d58a9a09e257f5ab1797f1d
  Author: Gonglei <address@hidden>
  Date:   2015-03-10 (Tue, 10 Mar 2015)

  Changed paths:
    M numa.c

  Log Message:
  -----------
  numa: remove superfluous '\n' around error_setg

Signed-off-by: Gonglei <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 81b07353c5e7ae9ae9360c357b7b4732b1cb03b4
      
https://github.com/qemu/qemu/commit/81b07353c5e7ae9ae9360c357b7b4732b1cb03b4
  Author: Gonglei <address@hidden>
  Date:   2015-03-10 (Tue, 10 Mar 2015)

  Changed paths:
    M exec.c
    M hw/ide/pci.c
    M hw/microblaze/boot.c
    M migration/rdma.c
    M target-s390x/kvm.c
    M trace/control.c

  Log Message:
  -----------
  Remove superfluous '\n' around error_report()

Signed-off-by: Gonglei <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: f6a16175962db8b2c7bd23374d5c138ef0171dcc
      
https://github.com/qemu/qemu/commit/f6a16175962db8b2c7bd23374d5c138ef0171dcc
  Author: Gonglei <address@hidden>
  Date:   2015-03-10 (Tue, 10 Mar 2015)

  Changed paths:
    M hw/scsi/vhost-scsi.c

  Log Message:
  -----------
  vhost-scsi: Remove superfluous '\n' around error_report()

Signed-off-by: Gonglei <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 78e5b17f0495acf19a8e7830018e95e759504a51
      
https://github.com/qemu/qemu/commit/78e5b17f0495acf19a8e7830018e95e759504a51
  Author: Gonglei <address@hidden>
  Date:   2015-03-10 (Tue, 10 Mar 2015)

  Changed paths:
    M hw/vfio/common.c

  Log Message:
  -----------
  vfio: Remove superfluous '\n' around error_report()

Signed-off-by: Gonglei <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: ebbb419aa290dad2f8eb840398f5e87db0bad3a5
      
https://github.com/qemu/qemu/commit/ebbb419aa290dad2f8eb840398f5e87db0bad3a5
  Author: Gonglei <address@hidden>
  Date:   2015-03-10 (Tue, 10 Mar 2015)

  Changed paths:
    M hw/xtensa/sim.c
    M hw/xtensa/xtfpga.c

  Log Message:
  -----------
  xtensa: Remove superfluous '\n' around error_report()

Signed-off-by: Gonglei <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 27215a22ddade35e83cc8bb4f49a5bd91b98ca19
      
https://github.com/qemu/qemu/commit/27215a22ddade35e83cc8bb4f49a5bd91b98ca19
  Author: Gonglei <address@hidden>
  Date:   2015-03-10 (Tue, 10 Mar 2015)

  Changed paths:
    M hw/tpm/tpm_passthrough.c
    M tpm.c

  Log Message:
  -----------
  tpm: Remove superfluous '\n' around error_report()

Signed-off-by: Gonglei <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: d448527a4f19979f7005949025796121bdfdfa61
      
https://github.com/qemu/qemu/commit/d448527a4f19979f7005949025796121bdfdfa61
  Author: Gonglei <address@hidden>
  Date:   2015-03-10 (Tue, 10 Mar 2015)

  Changed paths:
    M hw/arm/digic_boards.c

  Log Message:
  -----------
  arm/digic_boards: Remove superfluous '\n' around error_report()

Signed-off-by: Gonglei <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: c65476612aa4842785939fa3fbea2123cc980c75
      
https://github.com/qemu/qemu/commit/c65476612aa4842785939fa3fbea2123cc980c75
  Author: Gonglei <address@hidden>
  Date:   2015-03-10 (Tue, 10 Mar 2015)

  Changed paths:
    M hw/virtio/vhost-backend.c
    M net/vhost-user.c

  Log Message:
  -----------
  vhost: Remove superfluous '\n' around error_report()

Signed-off-by: Gonglei <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: b67072f0aba5837870163116da398005969495df
      
https://github.com/qemu/qemu/commit/b67072f0aba5837870163116da398005969495df
  Author: Thomas Huth <address@hidden>
  Date:   2015-03-10 (Tue, 10 Mar 2015)

  Changed paths:
    M include/ui/console.h
    M ui/console.c
    M ui/d3des.c
    M ui/d3des.h
    M ui/input-legacy.c

  Log Message:
  -----------
  ui: Removed unused functions

Remove qemu_console_displaystate(), qemu_remove_kbd_event_handler(),
qemu_different_endianness_pixelformat() and cpkey(), since they are
completely unused.

Signed-off-by: Thomas Huth <address@hidden>
Reviewed-by: Gerd Hoffmann <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 09526058d0a501106dcac842a455e187f1413d98
      
https://github.com/qemu/qemu/commit/09526058d0a501106dcac842a455e187f1413d98
  Author: Thomas Huth <address@hidden>
  Date:   2015-03-10 (Tue, 10 Mar 2015)

  Changed paths:
    M ui/vnc-jobs.c
    M ui/vnc-jobs.h

  Log Message:
  -----------
  ui/vnc: Remove vnc_stop_worker_thread()

This function is not used anymore, let's remove it.

Signed-off-by: Thomas Huth <address@hidden>
Reviewed-by: Gerd Hoffmann <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 611af7fdb65759193c357e7d415feabad21e3b74
      
https://github.com/qemu/qemu/commit/611af7fdb65759193c357e7d415feabad21e3b74
  Author: Thomas Huth <address@hidden>
  Date:   2015-03-10 (Tue, 10 Mar 2015)

  Changed paths:
    M include/hw/xen/xen.h
    M xen-hvm-stub.c

  Log Message:
  -----------
  xen: Remove xen_cmos_set_s3_resume()

The function is not used anymore, and thus can be deleted.

Signed-off-by: Thomas Huth <address@hidden>
Acked-by: Stefano Stabellini <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 7e781c79449ec2b3b649712c85610b147e3d41ee
      
https://github.com/qemu/qemu/commit/7e781c79449ec2b3b649712c85610b147e3d41ee
  Author: Cole Robinson <address@hidden>
  Date:   2015-03-10 (Tue, 10 Mar 2015)

  Changed paths:
    M qapi-schema.json

  Log Message:
  -----------
  qapi-schema: Fix SpiceChannel docs

The value is called channel-type, not connection-type

Signed-off-by: Cole Robinson <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 09f4fbe47314c2f13f16bf081997611f7f4251ea
      
https://github.com/qemu/qemu/commit/09f4fbe47314c2f13f16bf081997611f7f4251ea
  Author: Wang Xin <address@hidden>
  Date:   2015-03-10 (Tue, 10 Mar 2015)

  Changed paths:
    M ui/vnc_keysym.h

  Log Message:
  -----------
  qemu-char: add cyrillic characters 'numerosign' to VNC keysyms

This patch adds missing cyrillic character 'numerosign' to the VNC
keysym table, it's needed by Russian keyboard. And I get the keysym from
'<X11/keysymdef.h>', the current keysym table in Qemu was generated from
it.

Signed-off-by: Wang xin <address@hidden>
Signed-off-by: Gonglei <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 3e4c67c9ce1eafe374f3070499d25ddeffb9f3ca
      
https://github.com/qemu/qemu/commit/3e4c67c9ce1eafe374f3070499d25ddeffb9f3ca
  Author: Wang Xin <address@hidden>
  Date:   2015-03-10 (Tue, 10 Mar 2015)

  Changed paths:
    M pc-bios/keymaps/ru

  Log Message:
  -----------
  qemu-char: add cyrillic key 'numerosign' to Russian keymap

numero sign is the number sign key of Russian keyboard layout, we
get this key with 'shift + 3'. It's missing in current Russian keymap file,
this patch fixes it.
As number sign does not exsit in Russian keyboard layout[1][2], this
patch also removes the 'numbersign' from Russian keymap.

[1] http://en.wikipedia.org/wiki/Keyboard_layout#Russian
[2] http://kbd-intl.narod.ru/english/layouts

Signed-off-by: Wang Xin <address@hidden>
Signed-off-by: Gonglei <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 9d0b65e6e8f255dd86630a6873b3859fb6a5477f
      
https://github.com/qemu/qemu/commit/9d0b65e6e8f255dd86630a6873b3859fb6a5477f
  Author: Gonglei <address@hidden>
  Date:   2015-03-10 (Tue, 10 Mar 2015)

  Changed paths:
    M block/nbd.c

  Log Message:
  -----------
  nbd: fix resource leak

Signed-off-by: Gonglei <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: d71cdbfd540d91a6ae0005e59abfd782c424b07a
      
https://github.com/qemu/qemu/commit/d71cdbfd540d91a6ae0005e59abfd782c424b07a
  Author: Gonglei <address@hidden>
  Date:   2015-03-10 (Tue, 10 Mar 2015)

  Changed paths:
    M hw/sparc/leon3.c

  Log Message:
  -----------
  sparc/leon3.c: fix memory leak

Signed-off-by: Gonglei <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 6c5819c4d685bf5f3c81edb462f4d17fb99ca2b5
      
https://github.com/qemu/qemu/commit/6c5819c4d685bf5f3c81edb462f4d17fb99ca2b5
  Author: Gonglei <address@hidden>
  Date:   2015-03-10 (Tue, 10 Mar 2015)

  Changed paths:
    M hw/misc/macio/macio.c

  Log Message:
  -----------
  macio: fix possible memory leak

If ret = macio_initfn_ide() is less than 0, the timer_memory
will leak the memory it points to.

Signed-off-by: Gonglei <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: c2c17a245127cb456840e8dd9db9efc20a71e526
      
https://github.com/qemu/qemu/commit/c2c17a245127cb456840e8dd9db9efc20a71e526
  Author: Gonglei <address@hidden>
  Date:   2015-03-10 (Tue, 10 Mar 2015)

  Changed paths:
    M hw/lm32/milkymist.c

  Log Message:
  -----------
  milkymist.c: fix memory leak

Signed-off-by: Gonglei <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 84b5d556dc29c06402783e98ee0eaa3369eb48e1
      
https://github.com/qemu/qemu/commit/84b5d556dc29c06402783e98ee0eaa3369eb48e1
  Author: Gonglei <address@hidden>
  Date:   2015-03-10 (Tue, 10 Mar 2015)

  Changed paths:
    M hw/core/sysbus.c

  Log Message:
  -----------
  sysbus: fix memory leak

Signed-off-by: Gonglei <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 08156b4c34c2083552dcade929f1b8ad436678ad
      
https://github.com/qemu/qemu/commit/08156b4c34c2083552dcade929f1b8ad436678ad
  Author: Cole Robinson <address@hidden>
  Date:   2015-03-10 (Tue, 10 Mar 2015)

  Changed paths:
    M .gitignore
    M tests/qemu-iotests/.gitignore

  Log Message:
  -----------
  gitignore: Track common.env in iotests gitignore

Rather than track it in the toplevel gitignore

Signed-off-by: Cole Robinson <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: acff77b1ea90366143cb16d6fb1840e5d43b6633
      
https://github.com/qemu/qemu/commit/acff77b1ea90366143cb16d6fb1840e5d43b6633
  Author: Cole Robinson <address@hidden>
  Date:   2015-03-10 (Tue, 10 Mar 2015)

  Changed paths:
    M tests/.gitignore

  Log Message:
  -----------
  gitignore: Ignore new tests

Signed-off-by: Cole Robinson <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 2343dd11a673597aa59813fd0cac2ae42e2e0312
      
https://github.com/qemu/qemu/commit/2343dd11a673597aa59813fd0cac2ae42e2e0312
  Author: Michael Tokarev <address@hidden>
  Date:   2015-03-10 (Tue, 10 Mar 2015)

  Changed paths:
    M hw/ppc/e500.c

  Log Message:
  -----------
  e500: fix memory leak

Signed-off-by: Michael Tokarev <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Reviewed-by: Stefan Weil <address@hidden>


  Commit: d122f1a254abb91e42b4f2b2e1f8ee8980785e68
      
https://github.com/qemu/qemu/commit/d122f1a254abb91e42b4f2b2e1f8ee8980785e68
  Author: Stefan Weil <address@hidden>
  Date:   2015-03-10 (Tue, 10 Mar 2015)

  Changed paths:
    M hw/net/vhost_net.c

  Log Message:
  -----------
  vhost_net: Add missing 'static' attribute

This fixes a warning from smatch.

Signed-off-by: Stefan Weil <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 35ff0798130b654a866dc4c944e8bf45575ad990
      
https://github.com/qemu/qemu/commit/35ff0798130b654a866dc4c944e8bf45575ad990
  Author: Stefan Weil <address@hidden>
  Date:   2015-03-10 (Tue, 10 Mar 2015)

  Changed paths:
    M disas/arm.c

  Log Message:
  -----------
  disas/arm: Fix warnings caused by missing 'static' attribute

Warnings from the Sparse static analysis tool:

disas/arm.c:1552:15: warning:
 symbol 'last_type' was not declared. Should it be static?
disas/arm.c:1553:5: warning:
 symbol 'last_mapping_sym' was not declared. Should it be static?
disas/arm.c:1554:9: warning:
 symbol 'last_mapping_addr' was not declared. Should it be static?

Instead of adding 'static', the unused variables and the unused code which
refers to those variables (which was deactivated a long time ago in
commit 4b0f1a8b) are removed.

Signed-off-by: Stefan Weil <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 52b831de0099e627ee3505cb1c0c3d8eeefd3d65
      
https://github.com/qemu/qemu/commit/52b831de0099e627ee3505cb1c0c3d8eeefd3d65
  Author: Stefan Weil <address@hidden>
  Date:   2015-03-10 (Tue, 10 Mar 2015)

  Changed paths:
    M disas/microblaze.c

  Log Message:
  -----------
  disas/microblaze: Fix warnings caused by missing 'static' attribute

Warnings from the Sparse static analysis tool:

disas/microblaze.c:289:3: warning:
 symbol 'opcodes' was not declared. Should it be static?
disas/microblaze.c:570:6: warning:
 symbol 'register_prefix' was not declared. Should it be static?
disas/microblaze.c:571:6: warning:
 symbol 'special_register_prefix' was not declared. Should it be static?
disas/microblaze.c:572:6: warning:
 symbol 'fsl_register_prefix' was not declared. Should it be static?
disas/microblaze.c:573:6: warning:
 symbol 'pvr_register_prefix' was not declared. Should it be static?

Remove the unused variable special_register_prefix.
The variable pvr_register_prefix was unused, too, but can be used.
Add also 'const' where possible.

Signed-off-by: Stefan Weil <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 2a0457bbba10c208358e4e52642abeadd5f10c33
      
https://github.com/qemu/qemu/commit/2a0457bbba10c208358e4e52642abeadd5f10c33
  Author: Stefan Weil <address@hidden>
  Date:   2015-03-10 (Tue, 10 Mar 2015)

  Changed paths:
    M util/oslib-posix.c

  Log Message:
  -----------
  oslib-posix: Fix compiler warning (-Wclobbered) and simplify the code

gcc reports this warning with -Wclobbered:

util/oslib-posix.c: In function ‘os_mem_prealloc’:
util/oslib-posix.c:374:49: error: argument ‘memory’ might be clobbered by
 ‘longjmp’ or ‘vfork’ [-Werror=clobbered]

Fix this and simplify the code by using an existing macro.

Signed-off-by: Stefan Weil <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 02942db7982541716131ca486ca0d59eae107553
      
https://github.com/qemu/qemu/commit/02942db7982541716131ca486ca0d59eae107553
  Author: Stefan Weil <address@hidden>
  Date:   2015-03-10 (Tue, 10 Mar 2015)

  Changed paths:
    M migration/rdma.c

  Log Message:
  -----------
  migration: Fix coding style (whitespace issues)

* Remove trailing whitespace (fixes 9 errors from checkpatch.pl).
  One comment line was longer than 80 characters, so wrap it
  and fix a typo, too.
* Replace tabs by blanks (fixes 1 error).

Signed-off-by: Stefan Weil <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 8c1ac475e30091ba77a075d5e2136ece4f7c9cd0
      
https://github.com/qemu/qemu/commit/8c1ac475e30091ba77a075d5e2136ece4f7c9cd0
  Author: Radim Krčmář <address@hidden>
  Date:   2015-03-10 (Tue, 10 Mar 2015)

  Changed paths:
    M hw/net/virtio-net.c
    M kvm-all.c
    M qemu-img.c

  Log Message:
  -----------
  fix GCC 5.0.0 logical-not-parentheses warnings

man gcc:
  Warn about logical not used on the left hand side operand of a
  comparison.  This option does not warn if the RHS operand is of a
  boolean type.

By preferring bool over int where sensible, but without modifying any
depending code, make GCC happy in cases like this,
  qemu-img.c: In function ‘compare_sectors’:
  qemu-img.c:992:39: error: logical not is only applied to the left hand
  side of comparison [-Werror=logical-not-parentheses]
     if (!!memcmp(buf1, buf2, 512) != res) {

hw/ide/core.c:1836 doesn't throw an error,
  assert(!!s->error == !!(s->status & ERR_STAT));
even thought the second operand is int (and first hunk of this patch has
a very similar case), maybe GCC developers still have a little faith in
C programmers.

Signed-off-by: Radim Krčmář <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: c6dc3dd72b747a057770087998a1f9ef0b3f1882
      
https://github.com/qemu/qemu/commit/c6dc3dd72b747a057770087998a1f9ef0b3f1882
  Author: Radim Krčmář <address@hidden>
  Date:   2015-03-10 (Tue, 10 Mar 2015)

  Changed paths:
    M hw/misc/milkymist-pfpu.c

  Log Message:
  -----------
  milkymist-pfpu: fix GCC 5.0.0 aggressive-loop-optimizations warning

man gcc:
  Warn if in a loop with constant number of iterations the compiler
  detects undefined behavior in some statement during one or more of
  the iterations.

Milkymist pfpu has no jump instructions, so checking for MICROCODE_WORDS
instructions should have kept us in bounds of s->microcode, but i++
allowed one loop too many,

  hw/misc/milkymist-pfpu.c: In function ‘pfpu_write’:
  hw/misc/milkymist-pfpu.c:365:20: error: loop exit may only be reached after 
undefined behavior [-Werror=aggressive-loop-optimizations]
             if (i++ >= MICROCODE_WORDS) {
                ^
  hw/misc/milkymist-pfpu.c:167:14: note: possible undefined statement is here
       uint32_t insn = s->microcode[pc];
          ^

The code can still access out of bounds, because it presumes that PC register
always begins at 0, and we allow writing to it.

Signed-off-by: Radim Krčmář <address@hidden>
Acked-by: Michael Walle <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 3d0f44189178aab3a21a33ecf6a113b9abaea2bc
      
https://github.com/qemu/qemu/commit/3d0f44189178aab3a21a33ecf6a113b9abaea2bc
  Author: Paolo Bonzini <address@hidden>
  Date:   2015-03-10 (Tue, 10 Mar 2015)

  Changed paths:
    M gdbstub.c

  Log Message:
  -----------
  gdbstub: avoid possible NULL pointer dereference

Coverity reports that s->chr is checked after put_packet dereferences it.
Move the check earlier, consistent with the code used for user-mode
emulation.

Signed-off-by: Paolo Bonzini <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 438940cbc2eabbe9e403e5249dfa0be6c792c93b
      
https://github.com/qemu/qemu/commit/438940cbc2eabbe9e403e5249dfa0be6c792c93b
  Author: Michael Tokarev <address@hidden>
  Date:   2015-03-10 (Tue, 10 Mar 2015)

  Changed paths:
    M hw/9pfs/virtio-9p-local.c

  Log Message:
  -----------
  9pfs: remove useless return

Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 8437f7be3b1c49631e435c652707f2cee477149d
      
https://github.com/qemu/qemu/commit/8437f7be3b1c49631e435c652707f2cee477149d
  Author: Peter Maydell <address@hidden>
  Date:   2015-03-10 (Tue, 10 Mar 2015)

  Changed paths:
    M .gitignore
    M block/archipelago.c
    M block/nbd.c
    M cpus.c
    M disas/arm.c
    M disas/microblaze.c
    M exec.c
    M gdbstub.c
    M hw/9pfs/virtio-9p-local.c
    M hw/arm/digic_boards.c
    M hw/block/nand.c
    M hw/core/sysbus.c
    M hw/dma/pl330.c
    M hw/ide/pci.c
    M hw/lm32/milkymist.c
    M hw/microblaze/boot.c
    M hw/misc/macio/macio.c
    M hw/misc/milkymist-pfpu.c
    M hw/net/vhost_net.c
    M hw/net/virtio-net.c
    M hw/net/xilinx_ethlite.c
    M hw/ppc/e500.c
    M hw/scsi/vhost-scsi.c
    M hw/sparc/leon3.c
    M hw/timer/a9gtimer.c
    M hw/tpm/tpm_passthrough.c
    M hw/vfio/common.c
    M hw/virtio/vhost-backend.c
    M hw/xen/xen_pt_config_init.c
    M hw/xtensa/sim.c
    M hw/xtensa/xtfpga.c
    M include/hw/xen/xen.h
    M include/qapi/qmp/qerror.h
    M include/ui/console.h
    M kvm-all.c
    M migration/qemu-file-buf.c
    M migration/rdma.c
    M net/vhost-user.c
    M numa.c
    M pc-bios/keymaps/ru
    M qapi-schema.json
    M qemu-img.c
    M qemu-options.hx
    M qmp-commands.hx
    M target-s390x/kvm.c
    M tests/.gitignore
    M tests/qemu-iotests/.gitignore
    M tpm.c
    M trace/control.c
    M ui/console.c
    M ui/d3des.c
    M ui/d3des.h
    M ui/input-legacy.c
    M ui/vnc-jobs.c
    M ui/vnc-jobs.h
    M ui/vnc_keysym.h
    M util/cutils.c
    M util/oslib-posix.c
    M xen-hvm-stub.c

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/mjt/tags/pull-trivial-patches-2015-03-04' into staging

trivial patches for 2015-03-04

# gpg: Signature made Tue Mar 10 05:16:59 2015 GMT using RSA key ID A4C3D7DB
# gpg: Good signature from "Michael Tokarev <address@hidden>"
# gpg:                 aka "Michael Tokarev <address@hidden>"
# gpg:                 aka "Michael Tokarev <address@hidden>"

* remotes/mjt/tags/pull-trivial-patches-2015-03-04: (44 commits)
  9pfs: remove useless return
  gdbstub: avoid possible NULL pointer dereference
  milkymist-pfpu: fix GCC 5.0.0 aggressive-loop-optimizations warning
  fix GCC 5.0.0 logical-not-parentheses warnings
  migration: Fix coding style (whitespace issues)
  oslib-posix: Fix compiler warning (-Wclobbered) and simplify the code
  disas/microblaze: Fix warnings caused by missing 'static' attribute
  disas/arm: Fix warnings caused by missing 'static' attribute
  vhost_net: Add missing 'static' attribute
  e500: fix memory leak
  gitignore: Ignore new tests
  gitignore: Track common.env in iotests gitignore
  sysbus: fix memory leak
  milkymist.c: fix memory leak
  macio: fix possible memory leak
  sparc/leon3.c: fix memory leak
  nbd: fix resource leak
  qemu-char: add cyrillic key 'numerosign' to Russian keymap
  qemu-char: add cyrillic characters 'numerosign' to VNC keysyms
  qapi-schema: Fix SpiceChannel docs
  ...

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/277263e1b320...8437f7be3b1c
[Prev in Thread]
Current Thread
[Next in Thread]
[Qemu-commits] [qemu/qemu] d4cd45: xen-pt: fix Negative array index read, GitHub <=
Prev by Date: [Qemu-commits] [qemu/qemu] ee9a56: spapr_vio/spapr_iommu: Move VIO bypass where it be...
Next by Date: [Qemu-commits] [qemu/qemu] 315a13: coroutine: Fix use after free with qemu_coroutine_...
Previous by thread: [Qemu-commits] [qemu/qemu] ee9a56: spapr_vio/spapr_iommu: Move VIO bypass where it be...
Next by thread: [Qemu-commits] [qemu/qemu] 315a13: coroutine: Fix use after free with qemu_coroutine_...
Index(es):
- Date
- Thread