[Qemu-commits] [qemu/qemu] f27701: rules.mak: remove $(sort) from extract-libs

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: f27701510cdce9f76cdad0aaf9fb0bbcb23d299a
      
https://github.com/qemu/qemu/commit/f27701510cdce9f76cdad0aaf9fb0bbcb23d299a
  Author: Paolo Bonzini <address@hidden>
  Date:   2014-06-16 (Mon, 16 Jun 2014)

  Changed paths:
    M rules.mak

  Log Message:
  -----------
  rules.mak: remove $(sort) from extract-libs

Duplicate removal was added to extract-libs in order to avoid including
the same library multiple times into the linking command line; this could
potentially happen when using "foo.mo-libs" (which adds the library to
all components, causing it to appear N times if the module is composed
of N objects).  However, sorting and removing duplicates causes problems
with static linking, and also with space-separated linker options as
found in some Mac OS X packaging systems.  Furthermore, the "optimization"
is really a non-problem since we do not expect .mo modules to be composed
of many files.

Reported-by: Sean Bruno <address@hidden>
Tested-by: Sean Bruno <address@hidden>
Reviewed-by: Fam Zheng <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>