[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] c19904: wdt_i6300esb: fix vmstate versioning

From: GitHub
Subject: [Qemu-commits] [qemu/qemu] c19904: wdt_i6300esb: fix vmstate versioning
Date: Tue, 18 Jun 2013 12:30:08 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: c1990468d5a13c8f1d9111fcca0a78a6adad062b
  Author: Michael Roth <address@hidden>
  Date:   2013-06-18 (Tue, 18 Jun 2013)

  Changed paths:
    M hw/watchdog/wdt_i6300esb.c

  Log Message:
  wdt_i6300esb: fix vmstate versioning

When this VMSD was introduced it's version fields were set to
sizeof(I6300State), making them essentially random from build to build,
version to version.

To fix this, we lock in a high version id and low minimum version id to
support old->new migration from all prior versions of this device's
state. This should work since the device state has not changed since
its introduction.

The potentially breaks migration from 1.5+ to 1.5, but since the
versioning was essentially random prior to this patch, new->old
migration was not consistently functional to begin with.

Reported-by: Nicholas Thomas <address@hidden>
Suggested-by: Peter Maydell <address@hidden>
Cc: address@hidden
Signed-off-by: Michael Roth <address@hidden>
Signed-off-by: Anthony Liguori <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]