qemu-commits
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 391b7b: qemu-socket: allow hostnames starting

From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 391b7b: qemu-socket: allow hostnames starting with a digit
Date: Tue, 18 Jun 2013 09:00:10 -0700 
  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 391b7b9701ba3318e890ec0cba97a3c654bfa667
      
https://github.com/qemu/qemu/commit/391b7b9701ba3318e890ec0cba97a3c654bfa667
  Author: Ján Tomko <address@hidden>
  Date:   2013-06-18 (Tue, 18 Jun 2013)

  Changed paths:
    M util/qemu-sockets.c

  Log Message:
  -----------
  qemu-socket: allow hostnames starting with a digit

According to RFC 1123 [1], hostnames can start with a digit too.

[1] http://tools.ietf.org/html/rfc1123#page-13

Signed-off-by: Ján Tomko <address@hidden>
Cc: address@hidden
[Use strspn, not strcspn. - Paolo]
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 23307908790cd8fad91220863d7712c571ddc977
      
https://github.com/qemu/qemu/commit/23307908790cd8fad91220863d7712c571ddc977
  Author: Ján Tomko <address@hidden>
  Date:   2013-06-18 (Tue, 18 Jun 2013)

  Changed paths:
    M block/nbd.c

  Log Message:
  -----------
  nbd: strip braces from literal IPv6 address in URI

Otherwise they would get passed to getaddrinfo and fail with:
address resolution failed for [::1]:1234: Name or service not known

(Broken by commit v1.4.0-736-gf17c90b)

Signed-off-by: Ján Tomko <address@hidden>
Cc: address@hidden
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 7721c7f7c272fd2ed9d58500b7e99c33ab8a1af1
      
https://github.com/qemu/qemu/commit/7721c7f7c272fd2ed9d58500b7e99c33ab8a1af1
  Author: Pavel Hrdina <address@hidden>
  Date:   2013-06-18 (Tue, 18 Jun 2013)

  Changed paths:
    M hw/scsi/scsi-disk.c

  Log Message:
  -----------
  scsi: reset cdrom tray statuses on scsi_disk_reset

Tray statuses should be also reset. Some guests may lock the tray and
right after resetting the guest it should be unlocked and closed. This
is done on power-on, reset and resume from suspend/hibernate on bare-metal.

This fix is already committed for IDE CD.
Check the commit a7f3d65b65b8c86a5ff0c0abcfefb45e2ec6fe4c.

Test results on bare-metal:
  - on reset/power-on the CD-ROM tray is closed even before the monitor
    is turned on
  - on resume from suspend/hibernate the tray is also closed before
    the monitor is turned on

>From test results it seems that this behavior is OS and probably BIOS
independent.

Cc: address@hidden
Signed-off-by: Pavel Hrdina <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 53254e569f8e07501f3e0098bd57d2b780e52faa
      
https://github.com/qemu/qemu/commit/53254e569f8e07501f3e0098bd57d2b780e52faa
  Author: Paolo Bonzini <address@hidden>
  Date:   2013-06-18 (Tue, 18 Jun 2013)

  Changed paths:
    M hw/scsi/scsi-generic.c

  Log Message:
  -----------
  scsi-generic: fix sign extension of READ CAPACITY(10) data

Issuing the READ CAPACITY(10) command in the guest will cause QEMU
to update its knowledge of the maximum accessible LBA in the disk.
The recorded maximum LBA will be wrong if the disk is bigger than
1TB, because ldl_be_p returns a signed int.

When this is fixed, a latent bug will be unmasked.  If the READ
CAPACITY(10) command reported an overflow (0xFFFFFFFF), we must
not overwrite the previously-known maximum accessible LBA, or the guest
will fail to access the disk above the first 2TB.

Cc: address@hidden
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: d836f8d35dc418e24c3b11e2ea67d361b867b650
      
https://github.com/qemu/qemu/commit/d836f8d35dc418e24c3b11e2ea67d361b867b650
  Author: Pavel Hrdina <address@hidden>
  Date:   2013-06-18 (Tue, 18 Jun 2013)

  Changed paths:
    M hw/scsi/scsi-generic.c

  Log Message:
  -----------
  scsi-generic: check the return value of bdrv_aio_ioctl in execute_command

This fixes the bug introduced by this commit ad54ae80c73f.
The bdrv_aio_ioctl() still could return null and we should return an error
in that case.

Cc: address@hidden
Signed-off-by: Pavel Hrdina <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 18e673b8f350e1d789b8a50d209eb4a4252ebbda
      
https://github.com/qemu/qemu/commit/18e673b8f350e1d789b8a50d209eb4a4252ebbda
  Author: Pavel Hrdina <address@hidden>
  Date:   2013-06-18 (Tue, 18 Jun 2013)

  Changed paths:
    M hw/scsi/scsi-disk.c

  Log Message:
  -----------
  scsi-disk: scsi-block device for scsi pass-through should not be removable

This patch adds a new SCSI_DISK_F_NO_REMOVABLE_DEVOPS feature. By this
feature we can set that the scsi-block (scsi pass-through) device will still
be removable from the guest side, but from monitor it cannot be removed.

Cc: address@hidden
Signed-off-by: Pavel Hrdina <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 0e22a2d18998fd183c8181663981eb681ca977e9
      
https://github.com/qemu/qemu/commit/0e22a2d18998fd183c8181663981eb681ca977e9
  Author: Stefan Hajnoczi <address@hidden>
  Date:   2013-06-18 (Tue, 18 Jun 2013)

  Changed paths:
    M hw/scsi/vhost-scsi.c

  Log Message:
  -----------
  vhost-scsi: fix k->set_guest_notifiers() NULL dereference

Coverity picked up a copy-paste bug.  In vhost_scsi_start() we check for
!k->set_guest_notifiers and error out.  The check probably got copied
but instead of erroring we actually use the function pointer!

Cc: Nicholas Bellinger <address@hidden>
Cc: Asias He <address@hidden>
Cc: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: f0d2a4d4d63dd2f0f3ecb2d591b979b0e7f24a22
      
https://github.com/qemu/qemu/commit/f0d2a4d4d63dd2f0f3ecb2d591b979b0e7f24a22
  Author: Paolo Bonzini <address@hidden>
  Date:   2013-06-18 (Tue, 18 Jun 2013)

  Changed paths:
    M block/iscsi.c

  Log Message:
  -----------
  iscsi: simplify freeing of tasks

Always free them in the iscsi_aio_*_acb functions and remove the
checks in their callers.  Remove ifs when the task struct was
previously dereferenced (spotted by Coverity).

Cc: address@hidden
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 1288844e7c4ede59509bf697a4cca0f2215a1ce3
      
https://github.com/qemu/qemu/commit/1288844e7c4ede59509bf697a4cca0f2215a1ce3
  Author: Paolo Bonzini <address@hidden>
  Date:   2013-06-18 (Tue, 18 Jun 2013)

  Changed paths:
    M block/iscsi.c

  Log Message:
  -----------
  iscsi: reorganize iscsi_readcapacity_sync

Avoid the goto, and use the same retry logic for the 10- and 16-
byte versions.

Cc: address@hidden
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 5b456438f5bb395ed6b1eec95e18ce7a7a884a0a
      
https://github.com/qemu/qemu/commit/5b456438f5bb395ed6b1eec95e18ce7a7a884a0a
  Author: Cole Robinson <address@hidden>
  Date:   2013-06-18 (Tue, 18 Jun 2013)

  Changed paths:
    M hw/s390x/s390-virtio-bus.c
    M hw/s390x/virtio-ccw.c
    M hw/virtio/virtio-pci.c

  Log Message:
  -----------
  virtio-rng: Fix crash with non-default backend

'default_backend' isn't always set, but 'rng' is, so use that.

$ ./x86_64-softmmu/qemu-system-x86_64 -object 
rng-random,id=rng0,filename=/dev/random -device virtio-rng-pci,rng=rng0
Segmentation fault (core dumped)

Regressed with virtio refactoring in 59ccd20a9ac719cff82180429458728f03ec612f

CC: address@hidden
Signed-off-by: Cole Robinson <address@hidden>
Acked-by: Amit Shah <address@hidden>
Acked-by: Michael S. Tsirkin <address@hidden>
Tested-by: Michael Roth <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: 7d8f4b34a4bb6996d958da211f1dfb2686c7d82b
      
https://github.com/qemu/qemu/commit/7d8f4b34a4bb6996d958da211f1dfb2686c7d82b
  Author: Anthony Liguori <address@hidden>
  Date:   2013-06-18 (Tue, 18 Jun 2013)

  Changed paths:
    M block/nbd.c
    M util/qemu-sockets.c

  Log Message:
  -----------
  Merge remote-tracking branch 'bonzini/nbd-next' into staging

# By Ján Tomko
# Via Paolo Bonzini
* bonzini/nbd-next:
  nbd: strip braces from literal IPv6 address in URI
  qemu-socket: allow hostnames starting with a digit


  Commit: 3ed8a8430a896088db55ae029e9eac200aedbe5c
      
https://github.com/qemu/qemu/commit/3ed8a8430a896088db55ae029e9eac200aedbe5c
  Author: Anthony Liguori <address@hidden>
  Date:   2013-06-18 (Tue, 18 Jun 2013)

  Changed paths:
    M block/iscsi.c
    M hw/scsi/scsi-disk.c
    M hw/scsi/scsi-generic.c
    M hw/scsi/vhost-scsi.c

  Log Message:
  -----------
  Merge remote-tracking branch 'bonzini/scsi-next' into staging

# By Paolo Bonzini (3) and others
# Via Paolo Bonzini
* bonzini/scsi-next:
  iscsi: reorganize iscsi_readcapacity_sync
  iscsi: simplify freeing of tasks
  vhost-scsi: fix k->set_guest_notifiers() NULL dereference
  scsi-disk: scsi-block device for scsi pass-through should not be removable
  scsi-generic: check the return value of bdrv_aio_ioctl in execute_command
  scsi-generic: fix sign extension of READ CAPACITY(10) data
  scsi: reset cdrom tray statuses on scsi_disk_reset

Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


Compare: https://github.com/qemu/qemu/compare/afd59989db90...3ed8a8430a89
reply via email to
[Prev in Thread] Current Thread [Next in Thread]