[Qemu-commits] [qemu/qemu] 99835e: compiler: fix warning with GCC 4.8.0

qemu-commits

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 99835e: compiler: fix warning with GCC 4.8.0

From:	GitHub
Subject:	[Qemu-commits] [qemu/qemu] 99835e: compiler: fix warning with GCC 4.8.0
Date:	Wed, 27 Mar 2013 09:30:18 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 99835e00849369bab726a4dc4ceed1f6f9ed967c
      
https://github.com/qemu/qemu/commit/99835e00849369bab726a4dc4ceed1f6f9ed967c
  Author: Paolo Bonzini <address@hidden>
  Date:   2013-03-27 (Wed, 27 Mar 2013)

  Changed paths:
    M include/qemu/compiler.h

  Log Message:
  -----------
  compiler: fix warning with GCC 4.8.0

GCC 4.8.0 introduces a new warning:

    block/qcow2-snapshot.c: In function 'qcow2_write_snapshots’:
    block/qcow2-snapshot.c:252:18: error: typedef 'qemu_build_bug_on__253'
        locally defined but not used [-Werror=unused-local-typedefs]
   QEMU_BUILD_BUG_ON(offsetof(QCowHeader, snapshots_offset) !=
            ^
    cc1: all warnings being treated as errors

(Caret diagnostics aren't perfect yet with macros... :)) Work around it
with __attribute__((unused)).

Signed-off-by: Paolo Bonzini <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: 16665b943b23e953220df257e7e04e669aa384d5
      
https://github.com/qemu/qemu/commit/16665b943b23e953220df257e7e04e669aa384d5
  Author: Hans de Goede <address@hidden>
  Date:   2013-03-27 (Wed, 27 Mar 2013)

  Changed paths:
    M hw/usb/dev-serial.c
    M hw/usb/redirect.c
    M include/char/char.h
    M qemu-char.c
    M spice-qemu-char.c

  Log Message:
  -----------
  qemu-char: Rename opened to be_open

Rename the opened variable to be_open to reflect that it contains the
opened state of the backend.

Signed-off-by: Hans de Goede <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: fee204fd46016c168ca4d404d04e2c06b8b34770
      
https://github.com/qemu/qemu/commit/fee204fd46016c168ca4d404d04e2c06b8b34770
  Author: Hans de Goede <address@hidden>
  Date:   2013-03-27 (Wed, 27 Mar 2013)

  Changed paths:
    M backends/baum.c
    M include/char/char.h
    M qemu-char.c
    M ui/console.c
    M ui/gtk.c

  Log Message:
  -----------
  qemu-char: Rename qemu_chr_generic_open to qemu_chr_be_generic_open

To better reflect that it is for handling a backend being opened.

Signed-off-by: Hans de Goede <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: c0c4bd2cfae0fb83696000f1bfc355f22e2b41cb
      
https://github.com/qemu/qemu/commit/c0c4bd2cfae0fb83696000f1bfc355f22e2b41cb
  Author: Hans de Goede <address@hidden>
  Date:   2013-03-27 (Wed, 27 Mar 2013)

  Changed paths:
    M include/char/char.h
    M qemu-char.c

  Log Message:
  -----------
  qemu-char: Add fe_open tracking

Add tracking of the fe_open state to struct CharDriverState.

Signed-off-by: Hans de Goede <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: 190832289fe670f764fb277e4dcaf00f94ca6553
      
https://github.com/qemu/qemu/commit/190832289fe670f764fb277e4dcaf00f94ca6553
  Author: Hans de Goede <address@hidden>
  Date:   2013-03-27 (Wed, 27 Mar 2013)

  Changed paths:
    M hw/usb/redirect.c
    M hw/virtio-console.c
    M include/char/char.h
    M qemu-char.c

  Log Message:
  -----------
  qemu-char: Automatically do fe_open / fe_close on qemu_chr_add_handlers

Most frontends can't really determine if the guest actually has the frontend
side open. So lets automatically generate fe_open / fe_close as soon as a
frontend becomes ready (as signalled by calling qemu_chr_add_handlers) /
becomes non ready (as signalled by setting all handlers to NULL).

And allow frontends which can actually determine if the guest is listening to
opt-out of this.

Signed-off-by: Hans de Goede <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: 8e25daa87ac98c9070365b42dcfc070e47fca934
      
https://github.com/qemu/qemu/commit/8e25daa87ac98c9070365b42dcfc070e47fca934
  Author: Hans de Goede <address@hidden>
  Date:   2013-03-27 (Wed, 27 Mar 2013)

  Changed paths:
    M hw/virtio-console.c
    M include/char/char.h
    M qemu-char.c

  Log Message:
  -----------
  qemu-char: Cleanup: consolidate fe_open/fe_close into fe_set_open

Signed-off-by: Hans de Goede <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: 574b711a92db094a2d4e7ca707f3b34437a64246
      
https://github.com/qemu/qemu/commit/574b711a92db094a2d4e7ca707f3b34437a64246
  Author: Hans de Goede <address@hidden>
  Date:   2013-03-27 (Wed, 27 Mar 2013)

  Changed paths:
    M include/char/char.h
    M qemu-char.c
    M spice-qemu-char.c

  Log Message:
  -----------
  qemu-char: Consolidate guest_close/guest_open into a set_fe_open callback

Signed-off-by: Hans de Goede <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: 85d91e3295f3af21e4d4a19f1f6691c0bf2ed10c
      
https://github.com/qemu/qemu/commit/85d91e3295f3af21e4d4a19f1f6691c0bf2ed10c
  Author: Hans de Goede <address@hidden>
  Date:   2013-03-27 (Wed, 27 Mar 2013)

  Changed paths:
    M hw/qdev-properties-system.c
    M qemu-char.c

  Log Message:
  -----------
  qemu-char: Move incrementing of avail_connections to qdev-properties-system

The decrement of avail_connections is done in qdev-properties-system move
the increment there too for proper balancing of the calls.

Signed-off-by: Hans de Goede <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: a59bcd31c91397f8c67b6902e7716d626c5070e6
      
https://github.com/qemu/qemu/commit/a59bcd31c91397f8c67b6902e7716d626c5070e6
  Author: Hans de Goede <address@hidden>
  Date:   2013-03-27 (Wed, 27 Mar 2013)

  Changed paths:
    M qemu-char.c

  Log Message:
  -----------
  qemu-char: add_handlers: Don't re-send the be_open event on unregister

Resending the be_open event only is useful when a frontend is registering, not
when it is unregistering.

Signed-off-by: Hans de Goede <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: b2c1394af13b46a72cd27ff580cdd1d9bb1e8934
      
https://github.com/qemu/qemu/commit/b2c1394af13b46a72cd27ff580cdd1d9bb1e8934
  Author: Hans de Goede <address@hidden>
  Date:   2013-03-27 (Wed, 27 Mar 2013)

  Changed paths:
    M hw/virtio-console.c
    M hw/virtio-serial-bus.c
    M hw/virtio-serial.h

  Log Message:
  -----------
  virtio-serial: Consolidate guest_open/guest_close into set_guest_connected

Signed-off-by: Hans de Goede <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: bc6b815d9e34778aa7fbe785ecfa0b216c96f576
      
https://github.com/qemu/qemu/commit/bc6b815d9e34778aa7fbe785ecfa0b216c96f576
  Author: Alon Levy <address@hidden>
  Date:   2013-03-27 (Wed, 27 Mar 2013)

  Changed paths:
    M hw/virtio-serial-bus.c

  Log Message:
  -----------
  virtio-serial: propagate guest_connected to the port on post_load

When migrating a host with with a spice agent running the mouse becomes
non operational after the migration due to the agent state being
inconsistent between the guest and the client.

After migration the spicevmc backend on the destination has never been notified
of the (non 0) guest_connected state. Virtio-serial holds this state
information and migrates it, this patch properly propagates this information
to virtio-console and through that to interested chardev backends.

rhbz #725965

Signed-off-by: Hans de Goede <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: e280ff5e9159ed227a117339c1157143627cab96
      
https://github.com/qemu/qemu/commit/e280ff5e9159ed227a117339c1157143627cab96
  Author: Hans de Goede <address@hidden>
  Date:   2013-03-27 (Wed, 27 Mar 2013)

  Changed paths:
    M spice-qemu-char.c

  Log Message:
  -----------
  spice-qemu-char: Drop hackish vmc_register on spice_chr_write

Now that the core takes care of fe_open tracking we no longer need this hack.

Signed-off-by: Hans de Goede <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


Compare: https://github.com/qemu/qemu/compare/404e7a4f4af7...e280ff5e9159

[Prev in Thread]

Current Thread

[Next in Thread]

[Qemu-commits] [qemu/qemu] 99835e: compiler: fix warning with GCC 4.8.0, GitHub <=

Prev by Date: [Qemu-commits] [qemu/qemu] 0402a5: qdev: DEVICE_DELETED event
Next by Date: [Qemu-commits] [qemu/qemu] 142c6b: vl.c: call bdrv_init_with_whitelist() before cmdli...
Previous by thread: [Qemu-commits] [qemu/qemu] 0402a5: qdev: DEVICE_DELETED event
Next by thread: [Qemu-commits] [qemu/qemu] 142c6b: vl.c: call bdrv_init_with_whitelist() before cmdli...
Index(es):
- Date
- Thread