[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 8/8] qapi: Stop using whitespace for alignment in comments
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH v2 8/8] qapi: Stop using whitespace for alignment in comments |
|
Date: |
Tue, 3 May 2022 11:25:33 -0500 |
|
User-agent: |
NeoMutt/20220415-26-c08bba |
On Tue, May 03, 2022 at 09:37:37AM +0200, Andrea Bolognani wrote:
> Perfectly aligned things look pretty, but keeping them that
> way as the schema evolves requires churn, and in some cases
> newly-added lines are not aligned properly.
>
> Overall, trying to align things is just not worth the trouble.
I'm in favor of commiting 7+8 squashed as a single patch. 7 alone is
indeed a churn magnet, so I'm either for stopping the series at 6, or
going all the way to 8 via a single additional step.
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
- [PATCH v2 1/8] qapi: Drop stray trailing symbol, (continued)
- [PATCH v2 1/8] qapi: Drop stray trailing symbol, Andrea Bolognani, 2022/05/03
- [PATCH v2 3/8] qapi: Add missing separators between sections, Andrea Bolognani, 2022/05/03
- [PATCH v2 2/8] qapi: Fix comment indentation, Andrea Bolognani, 2022/05/03
- [PATCH v2 4/8] qapi: Drop unnecessary empty lines in comments, Andrea Bolognani, 2022/05/03
- [PATCH v2 5/8] qapi: Drop unnecessary empty lines outside of comments, Andrea Bolognani, 2022/05/03
- [PATCH v2 6/8] qapi: Drop unnecessary whitespace in comments, Andrea Bolognani, 2022/05/03
- [PATCH v2 7/8] qapi: Reduce whitespace used for alignment in comments, Andrea Bolognani, 2022/05/03
- [PATCH v2 8/8] qapi: Stop using whitespace for alignment in comments, Andrea Bolognani, 2022/05/03
- Re: [PATCH v2 8/8] qapi: Stop using whitespace for alignment in comments,
Eric Blake <=
- Re: [PATCH v2 0/8] qapi: Primarily whitespace tweaks, Markus Armbruster, 2022/05/16