[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 6/8] qapi: Drop unnecessary whitespace in comments
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH v2 6/8] qapi: Drop unnecessary whitespace in comments |
|
Date: |
Tue, 3 May 2022 11:23:05 -0500 |
|
User-agent: |
NeoMutt/20220415-26-c08bba |
On Tue, May 03, 2022 at 10:40:35AM +0200, Markus Armbruster wrote:
> Andrea Bolognani <abologna@redhat.com> writes:
>
> > The only instances that get changed are those in which the
> > additional whitespace was not (or couldn't possibly be) used for
> > alignment purposes.
> >
> > Signed-off-by: Andrea Bolognani <abologna@redhat.com>
>
> This mixes complete no-brainers with "I consider it an improvement, but
> folks might disagree" (a few examples marked below for illustration).
>
> Well, folks, if you disagree, speak up! I don't:
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
>
No complaints from me for the changes made in this patch.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
- [PATCH v2 0/8] qapi: Primarily whitespace tweaks, Andrea Bolognani, 2022/05/03
- [PATCH v2 1/8] qapi: Drop stray trailing symbol, Andrea Bolognani, 2022/05/03
- [PATCH v2 3/8] qapi: Add missing separators between sections, Andrea Bolognani, 2022/05/03
- [PATCH v2 2/8] qapi: Fix comment indentation, Andrea Bolognani, 2022/05/03
- [PATCH v2 4/8] qapi: Drop unnecessary empty lines in comments, Andrea Bolognani, 2022/05/03
- [PATCH v2 5/8] qapi: Drop unnecessary empty lines outside of comments, Andrea Bolognani, 2022/05/03
- [PATCH v2 6/8] qapi: Drop unnecessary whitespace in comments, Andrea Bolognani, 2022/05/03
- [PATCH v2 7/8] qapi: Reduce whitespace used for alignment in comments, Andrea Bolognani, 2022/05/03
- [PATCH v2 8/8] qapi: Stop using whitespace for alignment in comments, Andrea Bolognani, 2022/05/03
- Re: [PATCH v2 0/8] qapi: Primarily whitespace tweaks, Markus Armbruster, 2022/05/16