[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 8/9] hw/block/pflash_cfi01: Clarify trace events
From: |
David Edmondson |
Subject: |
Re: [PATCH 8/9] hw/block/pflash_cfi01: Clarify trace events |
Date: |
Wed, 10 Mar 2021 11:01:44 +0000 |
On Wednesday, 2021-03-10 at 00:50:27 +01, Philippe Mathieu-Daudé wrote:
> Use the 'mode_read_array' event when we set the device in such
> mode, and use the 'reset' event in DeviceReset handler.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: David Edmondson <david.edmondson@oracle.com>
> ---
> hw/block/pflash_cfi01.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/block/pflash_cfi01.c b/hw/block/pflash_cfi01.c
> index 03472ea5b64..2618e00926d 100644
> --- a/hw/block/pflash_cfi01.c
> +++ b/hw/block/pflash_cfi01.c
> @@ -663,7 +663,7 @@ static void pflash_write(PFlashCFI01 *pfl, hwaddr offset,
> "\n", __func__, offset, pfl->wcycle, pfl->cmd, value);
>
> mode_read_array:
> - trace_pflash_reset();
> + trace_pflash_mode_read_array();
> memory_region_rom_device_set_romd(&pfl->mem, true);
> pfl->wcycle = 0;
> pfl->cmd = 0x00; /* This model reset value for READ_ARRAY (not CFI) */
> @@ -886,6 +886,7 @@ static void pflash_cfi01_system_reset(DeviceState *dev)
> {
> PFlashCFI01 *pfl = PFLASH_CFI01(dev);
>
> + trace_pflash_reset();
> /*
> * The command 0x00 is not assigned by the CFI open standard,
> * but QEMU historically uses it for the READ_ARRAY command (0xff).
> --
> 2.26.2
dme.
--
At least they're not lonely.
- Re: [PATCH 6/9] hw/block/pflash_cfi02: Rename register_memory(true) as mode_read_array, (continued)
[PATCH 7/9] hw/block/pflash_cfi02: Factor out DeviceReset method, Philippe Mathieu-Daudé, 2021/03/09
[PATCH 8/9] hw/block/pflash_cfi01: Clarify trace events, Philippe Mathieu-Daudé, 2021/03/09
[PATCH 9/9] hw/block/pflash_cfi01: Extract pflash_mode_read_array(), Philippe Mathieu-Daudé, 2021/03/09