[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 4/9] qapi/misc: Restrict balloon-related commands to machi
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v3 4/9] qapi/misc: Restrict balloon-related commands to machine code |
Date: |
Wed, 27 May 2020 06:49:23 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Philippe Mathieu-Daudé <address@hidden> writes:
> On 5/26/20 11:31 AM, Philippe Mathieu-Daudé wrote:
>> +Laurent
>>
>> On 5/26/20 11:04 AM, Markus Armbruster wrote:
>>> Philippe Mathieu-Daudé <address@hidden> writes:
>>>
>>>> On 5/26/20 9:38 AM, Markus Armbruster wrote:
>>>>> Philippe Mathieu-Daudé <address@hidden> writes:
>>>>>
>>>>>> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
>>>>>
>>>>> A brief note on why restricting "to machine code" is useful would be
>>>>> nice. Same for the other patches.
>>>>>
>>>>> Acked-by: Markus Armbruster <address@hidden>
>>>>>
>>>>
>>>> What about this?
>>>>
>>>> "QEMU can do system-mode and user-mode emulation.
>>>> Only system mode emulate a machine.
>>>> Remove this feature from the user-mode emulation."
>>>
>>> Is is a feature of user-mode emulation before the patch? Or is it just
>>> dead code?
>>>
>>> Hint: QMP commands tend to be dead code when the program doesn't expose
>>> a QMP monitor :)
>>
>> Maybe a 'corollary' question, "How user-mode users use QMP?"
>>
>
> I can't find a way to start a user-mode process with a QMP socket, is
> there one?
As far as I can tell, only qemu-system-FOO and qemu-storage-daemon
provide QMP monitors:
* Monitors need to be initialized with monitor_init(). Two callers:
monitor_init_hmp(), monitor_init_qmp().
* monitor_init() calls both, and is the common wat to create a monitor.
Called by vl.c via monitor_init_opts(), and by qemu-storage-daemon.
* monitor_init_hmp() has additional callers, but HMP doesn't matter
here.
- [PATCH v3 3/9] qapi/misc.json: Correct balloon documentation, (continued)
- [PATCH v3 3/9] qapi/misc.json: Correct balloon documentation, Philippe Mathieu-Daudé, 2020/05/25
- [PATCH v3 4/9] qapi/misc: Restrict balloon-related commands to machine code, Philippe Mathieu-Daudé, 2020/05/25
- Re: [PATCH v3 4/9] qapi/misc: Restrict balloon-related commands to machine code, David Hildenbrand, 2020/05/26
- Re: [PATCH v3 4/9] qapi/misc: Restrict balloon-related commands to machine code, Markus Armbruster, 2020/05/26
- Re: [PATCH v3 4/9] qapi/misc: Restrict balloon-related commands to machine code, Philippe Mathieu-Daudé, 2020/05/26
- Re: [PATCH v3 4/9] qapi/misc: Restrict balloon-related commands to machine code, Markus Armbruster, 2020/05/26
- Re: [PATCH v3 4/9] qapi/misc: Restrict balloon-related commands to machine code, Philippe Mathieu-Daudé, 2020/05/26
- Re: [PATCH v3 4/9] qapi/misc: Restrict balloon-related commands to machine code, Philippe Mathieu-Daudé, 2020/05/26
- Re: [PATCH v3 4/9] qapi/misc: Restrict balloon-related commands to machine code,
Markus Armbruster <=
- Re: [PATCH v3 4/9] qapi/misc: Restrict balloon-related commands to machine code, Philippe Mathieu-Daudé, 2020/05/27
[PATCH v3 5/9] qapi/misc: Restrict query-vm-generation-id command to machine code, Philippe Mathieu-Daudé, 2020/05/25
[PATCH v3 6/9] qapi/misc: Move query-uuid command to machine code, Philippe Mathieu-Daudé, 2020/05/25
[PATCH v3 7/9] qapi/misc: Restrict ACPI commands to machine code, Philippe Mathieu-Daudé, 2020/05/25
[PATCH v3 8/9] qapi/misc: Restrict PCI commands to machine code, Philippe Mathieu-Daudé, 2020/05/25
[PATCH v3 9/9] qapi/misc: Restrict device memory commands to machine code, Philippe Mathieu-Daudé, 2020/05/25