[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/7] block/nvme: clarify that free_req_queue is protected by
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 5/7] block/nvme: clarify that free_req_queue is protected by q->lock |
Date: |
Tue, 26 May 2020 14:04:47 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 5/19/20 7:11 PM, Stefan Hajnoczi wrote:
> Existing users access free_req_queue under q->lock. Document this.
>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> block/nvme.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/nvme.c b/block/nvme.c
> index 3ad4f27e1c..e32bff26ff 100644
> --- a/block/nvme.c
> +++ b/block/nvme.c
> @@ -57,7 +57,6 @@ typedef struct {
> } NVMeRequest;
>
> typedef struct {
> - CoQueue free_req_queue;
> QemuMutex lock;
>
> /* Fields protected by BQL */
> @@ -65,6 +64,7 @@ typedef struct {
> uint8_t *prp_list_pages;
>
> /* Fields protected by @lock */
> + CoQueue free_req_queue;
> NVMeQueue sq, cq;
> int cq_phase;
> int free_req_head;
>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
- [PATCH 2/7] block/nvme: drop tautologous assertion, (continued)
- [PATCH 2/7] block/nvme: drop tautologous assertion, Stefan Hajnoczi, 2020/05/19
- [PATCH 3/7] block/nvme: don't access CQE after moving cq.head, Stefan Hajnoczi, 2020/05/19
- [PATCH 4/7] block/nvme: switch to a NVMeRequest freelist, Stefan Hajnoczi, 2020/05/19
- [PATCH 5/7] block/nvme: clarify that free_req_queue is protected by q->lock, Stefan Hajnoczi, 2020/05/19
- [PATCH 6/7] block/nvme: keep BDRVNVMeState pointer in NVMeQueuePair, Stefan Hajnoczi, 2020/05/19
- [PATCH 7/7] block/nvme: support nested aio_poll(), Stefan Hajnoczi, 2020/05/19