[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/7] block/nvme: drop tautologous assertion
|
From: |
Sergio Lopez |
|
Subject: |
Re: [PATCH 2/7] block/nvme: drop tautologous assertion |
|
Date: |
Mon, 25 May 2020 10:08:03 +0200 |
On Tue, May 19, 2020 at 06:11:33PM +0100, Stefan Hajnoczi wrote:
> nvme_process_completion() explicitly checks cid so the assertion that
> follows is always true:
>
> if (cid == 0 || cid > NVME_QUEUE_SIZE) {
> ...
> continue;
> }
> assert(cid <= NVME_QUEUE_SIZE);
>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> block/nvme.c | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Sergio Lopez <address@hidden>
signature.asc
Description: PGP signature
- [PATCH 0/7] block/nvme: support nested aio_poll(), Stefan Hajnoczi, 2020/05/19
- [PATCH 1/7] block/nvme: poll queues without q->lock, Stefan Hajnoczi, 2020/05/19
- [PATCH 2/7] block/nvme: drop tautologous assertion, Stefan Hajnoczi, 2020/05/19
- [PATCH 3/7] block/nvme: don't access CQE after moving cq.head, Stefan Hajnoczi, 2020/05/19
- [PATCH 4/7] block/nvme: switch to a NVMeRequest freelist, Stefan Hajnoczi, 2020/05/19
- [PATCH 5/7] block/nvme: clarify that free_req_queue is protected by q->lock, Stefan Hajnoczi, 2020/05/19
- [PATCH 6/7] block/nvme: keep BDRVNVMeState pointer in NVMeQueuePair, Stefan Hajnoczi, 2020/05/19