[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 7/7] migration/block-dirty-bitmap: forbid migration by gen
From: |
Eric Blake |
Subject: |
Re: [PATCH v3 7/7] migration/block-dirty-bitmap: forbid migration by generated node-name |
Date: |
Thu, 21 May 2020 16:05:14 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 |
On 5/15/20 7:40 AM, Vladimir Sementsov-Ogievskiy wrote:
It actually never worked with libvirt, as auto-generated names are
different on source and destination.
It's unsafe and useless to migrate by auto-generated node-names, so
let's forbid it.
Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Reviewed-by: Andrey Shinkevich <address@hidden>
---
migration/block-dirty-bitmap.c | 7 +++++++
1 file changed, 7 insertions(+)
Reviewed-by: Eric Blake <address@hidden>
diff --git a/migration/block-dirty-bitmap.c b/migration/block-dirty-bitmap.c
index e0e081ce60..f5744c35e6 100644
--- a/migration/block-dirty-bitmap.c
+++ b/migration/block-dirty-bitmap.c
@@ -285,6 +285,13 @@ static int add_bitmaps_to_list(BlockDriverState *bs, const
char *bs_name)
return -1;
}
+ if (bs_name[0] == '#') {
+ error_report("Found bitmap '%s' in a node with auto-generated "
+ "name: %s. It can't be migrated",
Maybe compress to:
"Bitmap '%s' in auto-generated node '%s' can't be migrated"
+ bdrv_dirty_bitmap_name(bitmap), bs_name);
+ return -1;
+ }
+
FOR_EACH_DIRTY_BITMAP(bs, bitmap) {
if (!bdrv_dirty_bitmap_name(bitmap)) {
continue;
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
- [PATCH v3 4/7] migration/block-dirty-bitmap: fix bitmaps pre-blockdev migration during mirror job, (continued)
- [PATCH v3 5/7] iotests: 194: test also migration of dirty bitmap, Vladimir Sementsov-Ogievskiy, 2020/05/15
- [PATCH v3 3/7] block/dirty-bitmap: add bdrv_has_named_bitmaps helper, Vladimir Sementsov-Ogievskiy, 2020/05/15
- [PATCH v3 6/7] migration/block-dirty-bitmap: add_bitmaps_to_list: check disk name once, Vladimir Sementsov-Ogievskiy, 2020/05/15
- [PATCH v3 7/7] migration/block-dirty-bitmap: forbid migration by generated node-name, Vladimir Sementsov-Ogievskiy, 2020/05/15
- Re: [PATCH v3 7/7] migration/block-dirty-bitmap: forbid migration by generated node-name,
Eric Blake <=