|
From: | Eric Blake |
Subject: | Re: [PATCH v3 4/7] migration/block-dirty-bitmap: fix bitmaps pre-blockdev migration during mirror job |
Date: | Thu, 21 May 2020 16:01:59 -0500 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 |
On 5/19/20 5:51 AM, Vladimir Sementsov-Ogievskiy wrote:
18.05.2020 23:36, Eric Blake wrote:On 5/15/20 7:40 AM, Vladimir Sementsov-Ogievskiy wrote:Important thing for bitmap migration is to select destination block node to obtain the migrated bitmap.
+ /* Skip filters without bitmaos */ + while (bs && bs->drv && bs->drv->is_filter && + !bdrv_has_named_bitmaps(bs)) + { + bs = bs->backing->bs ?: bs->file->bs;Is this correct, or should it be: bs = bs->backing ? bs->backing->bs : bs->file->bs;Hmm, yes, otherwise it should crash on file-based filter :)Otherwise looks reasonable, but I'm hesitant to include it in today's bitmap pull request in order to give it more review/testing time. It should be ready for a pull request next week, though.
Can you post a v4, to make it easier for me to build? -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
[Prev in Thread] | Current Thread | [Next in Thread] |