|
From: | Eric Blake |
Subject: | Re: [PATCH 2/8] block/vpc: return ZERO block-status when appropriate |
Date: | Wed, 6 May 2020 16:18:16 -0500 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 |
On 5/6/20 4:25 AM, Vladimir Sementsov-Ogievskiy wrote:
In case when get_image_offset() returns -1, we do zero out the corresponding chunk of qiov. So, this should be reported as ZERO. After block-status update, it never reports 0, so setting unallocated_blocks_are_zero doesn't make sense. Drop it.
Same analysis as in patch 1 as to the lone two clients that cared, and the fact that we are changing 'qemu-io -c map' output by reporting data as allocated now. But I concur that as there is never a backing file, the change is not a regression, but rather a bug fix.
Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden> --- block/vpc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
While the commit message could be improved, the code change itself looks correct.
Reviewed-by: Eric Blake <address@hidden> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
[Prev in Thread] | Current Thread | [Next in Thread] |