qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 30/31] qcow2: Add subcluster support to qcow2_measure()


From: Eric Blake
Subject: Re: [PATCH v5 30/31] qcow2: Add subcluster support to qcow2_measure()
Date: Wed, 6 May 2020 13:13:51 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0

On 5/5/20 12:38 PM, Alberto Garcia wrote:
Extended L2 entries are bigger than normal L2 entries so this has an
impact on the amount of metadata needed for a qcow2 file.

Signed-off-by: Alberto Garcia <address@hidden>
Reviewed-by: Max Reitz <address@hidden>
---
  block/qcow2.c | 19 ++++++++++++-------
  1 file changed, 12 insertions(+), 7 deletions(-)

Should this be hoisted earlier in the series, before 28/31?

Should there be iotest coverage?

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




reply via email to

[Prev in Thread] Current Thread [Next in Thread]