[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 32/33] block: Pass BdrvChildRole in remaining cases
From: |
Kevin Wolf |
Subject: |
Re: [PATCH v3 32/33] block: Pass BdrvChildRole in remaining cases |
Date: |
Wed, 6 May 2020 19:13:15 +0200 |
Am 18.02.2020 um 13:42 hat Max Reitz geschrieben:
> These calls have no real use for the child role yet, but it will not
> harm to give one.
>
> Notably, the bdrv_root_attach_child() call in blockjob.c is left
> unmodified because there is not much the generic BlockJob object wants
> from its children.
>
> Signed-off-by: Max Reitz <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> diff --git a/block/vvfat.c b/block/vvfat.c
> index 8f4ff5a97e..d4f4218924 100644
> --- a/block/vvfat.c
> +++ b/block/vvfat.c
> @@ -3186,7 +3186,7 @@ static int enable_write_target(BlockDriverState *bs,
> Error **errp)
> options = qdict_new();
> qdict_put_str(options, "write-target.driver", "qcow");
> s->qcow = bdrv_open_child(s->qcow_filename, options, "write-target", bs,
> - &child_vvfat_qcow, 0, false, errp);
> + &child_vvfat_qcow, BDRV_CHILD_DATA, false,
> errp);
Doesn't it contain metadata, too?
Kevin
- Re: [PATCH v3 32/33] block: Pass BdrvChildRole in remaining cases,
Kevin Wolf <=