Re: [PATCH v3 26/33] block: Use child_of_bds in remaining places

[Kevin Wolf]

Am 18.02.2020 um 13:42 hat Max Reitz geschrieben:
> Replace child_file by child_of_bds in all remaining places (excluding
> tests).
> 
> Signed-off-by: Max Reitz <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>

> diff --git a/block/blkreplay.c b/block/blkreplay.c
> index f97493f45a..71628f4d56 100644
> --- a/block/blkreplay.c
> +++ b/block/blkreplay.c
> @@ -27,8 +27,9 @@ static int blkreplay_open(BlockDriverState *bs, QDict 
> *options, int flags,
>      int ret;
>  
>      /* Open the image file */
> -    bs->file = bdrv_open_child(NULL, options, "image",
> -                               bs, &child_file, 0, false, &local_err);
> +    bs->file = bdrv_open_child(NULL, options, "image", bs, &child_of_bds,
> +                               BDRV_CHILD_DATA | BDRV_CHILD_PRIMARY,
> +                               false, &local_err);

Why isn't blkreplay a filter?

Kevin