[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PULL 07/22] vpc: Return 0 from vpc_co_create() on success
From: |
Kevin Wolf |
Subject: |
[Qemu-block] [PULL 07/22] vpc: Return 0 from vpc_co_create() on success |
Date: |
Thu, 12 Sep 2019 15:45:49 +0200 |
From: Max Reitz <address@hidden>
blockdev_create_run() directly uses .bdrv_co_create()'s return value as
the job's return value. Jobs must return 0 on success, not just any
nonnegative value. Therefore, using blockdev-create for VPC images may
currently fail as the vpc driver may return a positive integer.
Because there is no point in returning a positive integer anywhere in
the block layer (all non-negative integers are generally treated as
complete success), we probably do not want to add more such cases.
Therefore, fix this problem by making the vpc driver always return 0 in
case of success.
Suggested-by: Kevin Wolf <address@hidden>
Cc: address@hidden
Signed-off-by: Max Reitz <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>
---
block/vpc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/block/vpc.c b/block/vpc.c
index b25aab0425..5cd3890780 100644
--- a/block/vpc.c
+++ b/block/vpc.c
@@ -885,6 +885,7 @@ static int create_dynamic_disk(BlockBackend *blk, uint8_t
*buf,
goto fail;
}
+ ret = 0;
fail:
return ret;
}
@@ -908,7 +909,7 @@ static int create_fixed_disk(BlockBackend *blk, uint8_t
*buf,
return ret;
}
- return ret;
+ return 0;
}
static int calculate_rounded_image_size(BlockdevCreateOptionsVpc *vpc_opts,
--
2.20.1
- [Qemu-block] [PULL 00/22] Block layer patches, Kevin Wolf, 2019/09/12
- [Qemu-block] [PULL 01/22] qcow2: Fix the calculation of the maximum L2 cache size, Kevin Wolf, 2019/09/12
- [Qemu-block] [PULL 03/22] block/file-posix: Reduce xfsctl() use, Kevin Wolf, 2019/09/12
- [Qemu-block] [PULL 02/22] job: drop job_drain, Kevin Wolf, 2019/09/12
- [Qemu-block] [PULL 04/22] iotests: Test reverse sub-cluster qcow2 writes, Kevin Wolf, 2019/09/12
- [Qemu-block] [PULL 05/22] pr-manager: Fix invalid g_free() crash bug, Kevin Wolf, 2019/09/12
- [Qemu-block] [PULL 07/22] vpc: Return 0 from vpc_co_create() on success,
Kevin Wolf <=
- [Qemu-block] [PULL 06/22] file-posix: Fix has_write_zeroes after NO_FALLBACK, Kevin Wolf, 2019/09/12
- [Qemu-block] [PULL 08/22] iotests: Add supported protocols to execute_test(), Kevin Wolf, 2019/09/12
- [Qemu-block] [PULL 10/22] iotests: Restrict nbd Python tests to nbd, Kevin Wolf, 2019/09/12
- [Qemu-block] [PULL 09/22] iotests: Restrict file Python tests to file, Kevin Wolf, 2019/09/12
- [Qemu-block] [PULL 11/22] iotests: Test blockdev-create for vpc, Kevin Wolf, 2019/09/12
- [Qemu-block] [PULL 12/22] iotests: skip 232 when run tests as root, Kevin Wolf, 2019/09/12
- [Qemu-block] [PULL 13/22] block/nfs: add support for nfs_umount, Kevin Wolf, 2019/09/12
- [Qemu-block] [PULL 15/22] iotests: exclude killed processes from running under Valgrind, Kevin Wolf, 2019/09/12
- [Qemu-block] [PULL 16/22] iotests: Add casenotrun report to bash tests, Kevin Wolf, 2019/09/12
- [Qemu-block] [PULL 14/22] iotests: allow Valgrind checking all QEMU processes, Kevin Wolf, 2019/09/12